[dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action

DPDK patches and discussions
 help / color / mirror / Atom feed

* [dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action
@ 2021-01-26  3:38 Alexander Kozyrev
  2021-01-26  3:43 ` Stephen Hemminger
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Alexander Kozyrev @ 2021-01-26  3:38 UTC (permalink / raw)
  To: dev
  Cc: viacheslavo, orika, thomas, ferruh.yigit, andrew.rybchenko,
	jerinjacobk, ajit.khaparde

IPv6 DSCP field ID is missing from the original list of Field IDs
for MODIFY_FIELD action. Add it to support IPv6 header fully.

Fixes: 73b68f4c54a ("ethdev: introduce generic modify flow action")

Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
---
 lib/librte_ethdev/rte_flow.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
index 46e8ee70ab..68c68cdd6c 100644
--- a/lib/librte_ethdev/rte_flow.h
+++ b/lib/librte_ethdev/rte_flow.h
@@ -2842,6 +2842,7 @@ enum rte_flow_field_id {
 	RTE_FLOW_FIELD_IPV4_TTL,
 	RTE_FLOW_FIELD_IPV4_SRC,
 	RTE_FLOW_FIELD_IPV4_DST,
+	RTE_FLOW_FIELD_IPV6_DSCP,
 	RTE_FLOW_FIELD_IPV6_HOPLIMIT,
 	RTE_FLOW_FIELD_IPV6_SRC,
 	RTE_FLOW_FIELD_IPV6_DST,
-- 
2.24.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action
  2021-01-26  3:38 [dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action Alexander Kozyrev
@ 2021-01-26  3:43 ` Stephen Hemminger
  2021-01-26  5:21   ` Alexander Kozyrev
  2021-01-26  5:36 ` Ajit Khaparde
  2021-01-26 15:13 ` [dpdk-dev] [PATCH v2] " Alexander Kozyrev
  2 siblings, 1 reply; 8+ messages in thread
From: Stephen Hemminger @ 2021-01-26  3:43 UTC (permalink / raw)
  To: Alexander Kozyrev
  Cc: dev, viacheslavo, orika, thomas, ferruh.yigit, andrew.rybchenko,
	jerinjacobk, ajit.khaparde

On Tue, 26 Jan 2021 03:38:24 +0000
Alexander Kozyrev <akozyrev@nvidia.com> wrote:

> IPv6 DSCP field ID is missing from the original list of Field IDs
> for MODIFY_FIELD action. Add it to support IPv6 header fully.
> 
> Fixes: 73b68f4c54a ("ethdev: introduce generic modify flow action")
> 
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
> ---
>  lib/librte_ethdev/rte_flow.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> index 46e8ee70ab..68c68cdd6c 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -2842,6 +2842,7 @@ enum rte_flow_field_id {
>  	RTE_FLOW_FIELD_IPV4_TTL,
>  	RTE_FLOW_FIELD_IPV4_SRC,
>  	RTE_FLOW_FIELD_IPV4_DST,
> +	RTE_FLOW_FIELD_IPV6_DSCP,
>  	RTE_FLOW_FIELD_IPV6_HOPLIMIT,
>  	RTE_FLOW_FIELD_IPV6_SRC,
>  	RTE_FLOW_FIELD_IPV6_DST,

Adding field in middle of enum will break ABI.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action
  2021-01-26  3:43 ` Stephen Hemminger
@ 2021-01-26  5:21   ` Alexander Kozyrev
  2021-01-26  5:35     ` Ajit Khaparde
  2021-01-26  5:44     ` Stephen Hemminger
  0 siblings, 2 replies; 8+ messages in thread
From: Alexander Kozyrev @ 2021-01-26  5:21 UTC (permalink / raw)
  To: Stephen Hemminger
  Cc: dev, Slava Ovsiienko, Ori Kam, NBU-Contact-Thomas Monjalon,
	ferruh.yigit, andrew.rybchenko, jerinjacobk, ajit.khaparde

> From: Stephen Hemminger <stephen@networkplumber.org> on Monday, January 25, 2021 22:44
> 
> On Tue, 26 Jan 2021 03:38:24 +0000
> Alexander Kozyrev <akozyrev@nvidia.com> wrote:
> 
> > IPv6 DSCP field ID is missing from the original list of Field IDs
> > for MODIFY_FIELD action. Add it to support IPv6 header fully.
> >
> > Fixes: 73b68f4c54a ("ethdev: introduce generic modify flow action")
> >
> > Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
> > ---
> >  lib/librte_ethdev/rte_flow.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> > index 46e8ee70ab..68c68cdd6c 100644
> > --- a/lib/librte_ethdev/rte_flow.h
> > +++ b/lib/librte_ethdev/rte_flow.h
> > @@ -2842,6 +2842,7 @@ enum rte_flow_field_id {
> >  	RTE_FLOW_FIELD_IPV4_TTL,
> >  	RTE_FLOW_FIELD_IPV4_SRC,
> >  	RTE_FLOW_FIELD_IPV4_DST,
> > +	RTE_FLOW_FIELD_IPV6_DSCP,
> >  	RTE_FLOW_FIELD_IPV6_HOPLIMIT,
> >  	RTE_FLOW_FIELD_IPV6_SRC,
> >  	RTE_FLOW_FIELD_IPV6_DST,
> 
> Adding field in middle of enum will break ABI.

I added the rte_flow_field_id enum a week ago into 20.11-rc1.
I believe it is not too late to make it right without breaking ABI, don't you think so?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action
  2021-01-26  5:21   ` Alexander Kozyrev
@ 2021-01-26  5:35     ` Ajit Khaparde
  2021-01-26  5:44     ` Stephen Hemminger
  1 sibling, 0 replies; 8+ messages in thread
From: Ajit Khaparde @ 2021-01-26  5:35 UTC (permalink / raw)
  To: Alexander Kozyrev
  Cc: Stephen Hemminger, dev, Slava Ovsiienko, Ori Kam,
	NBU-Contact-Thomas Monjalon, ferruh.yigit, andrew.rybchenko,
	jerinjacobk

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

On Mon, Jan 25, 2021 at 9:21 PM Alexander Kozyrev <akozyrev@nvidia.com> wrote:
>
> > From: Stephen Hemminger <stephen@networkplumber.org> on Monday, January 25, 2021 22:44
> >
> > On Tue, 26 Jan 2021 03:38:24 +0000
> > Alexander Kozyrev <akozyrev@nvidia.com> wrote:
> >
> > > IPv6 DSCP field ID is missing from the original list of Field IDs
> > > for MODIFY_FIELD action. Add it to support IPv6 header fully.
> > >
> > > Fixes: 73b68f4c54a ("ethdev: introduce generic modify flow action")
> > >
> > > Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
> > > ---
> > >  lib/librte_ethdev/rte_flow.h | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> > > index 46e8ee70ab..68c68cdd6c 100644
> > > --- a/lib/librte_ethdev/rte_flow.h
> > > +++ b/lib/librte_ethdev/rte_flow.h
> > > @@ -2842,6 +2842,7 @@ enum rte_flow_field_id {
> > >     RTE_FLOW_FIELD_IPV4_TTL,
> > >     RTE_FLOW_FIELD_IPV4_SRC,
> > >     RTE_FLOW_FIELD_IPV4_DST,
> > > +   RTE_FLOW_FIELD_IPV6_DSCP,
> > >     RTE_FLOW_FIELD_IPV6_HOPLIMIT,
> > >     RTE_FLOW_FIELD_IPV6_SRC,
> > >     RTE_FLOW_FIELD_IPV6_DST,
> >
> > Adding field in middle of enum will break ABI.
>
> I added the rte_flow_field_id enum a week ago into 20.11-rc1.
21.02-rc1

> I believe it is not too late to make it right without breaking ABI, don't you think so?

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action
  2021-01-26  5:21   ` Alexander Kozyrev
  2021-01-26  5:35     ` Ajit Khaparde
@ 2021-01-26  5:44     ` Stephen Hemminger
  1 sibling, 0 replies; 8+ messages in thread
From: Stephen Hemminger @ 2021-01-26  5:44 UTC (permalink / raw)
  To: Alexander Kozyrev
  Cc: dev, Slava Ovsiienko, Ori Kam, NBU-Contact-Thomas Monjalon,
	ferruh.yigit, andrew.rybchenko, jerinjacobk, ajit.khaparde

On Tue, 26 Jan 2021 05:21:23 +0000
Alexander Kozyrev <akozyrev@nvidia.com> wrote:

> > From: Stephen Hemminger <stephen@networkplumber.org> on Monday, January 25, 2021 22:44
> > 
> > On Tue, 26 Jan 2021 03:38:24 +0000
> > Alexander Kozyrev <akozyrev@nvidia.com> wrote:
> >   
> > > IPv6 DSCP field ID is missing from the original list of Field IDs
> > > for MODIFY_FIELD action. Add it to support IPv6 header fully.
> > >
> > > Fixes: 73b68f4c54a ("ethdev: introduce generic modify flow action")
> > >
> > > Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
> > > ---
> > >  lib/librte_ethdev/rte_flow.h | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> > > index 46e8ee70ab..68c68cdd6c 100644
> > > --- a/lib/librte_ethdev/rte_flow.h
> > > +++ b/lib/librte_ethdev/rte_flow.h
> > > @@ -2842,6 +2842,7 @@ enum rte_flow_field_id {
> > >  	RTE_FLOW_FIELD_IPV4_TTL,
> > >  	RTE_FLOW_FIELD_IPV4_SRC,
> > >  	RTE_FLOW_FIELD_IPV4_DST,
> > > +	RTE_FLOW_FIELD_IPV6_DSCP,
> > >  	RTE_FLOW_FIELD_IPV6_HOPLIMIT,
> > >  	RTE_FLOW_FIELD_IPV6_SRC,
> > >  	RTE_FLOW_FIELD_IPV6_DST,  
> > 
> > Adding field in middle of enum will break ABI.  
> 
> I added the rte_flow_field_id enum a week ago into 20.11-rc1.
> I believe it is not too late to make it right without breaking ABI, don't you think so?

Ok if not in release yet


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action
  2021-01-26  3:38 [dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action Alexander Kozyrev
  2021-01-26  3:43 ` Stephen Hemminger
@ 2021-01-26  5:36 ` Ajit Khaparde
  2021-01-26 15:13 ` [dpdk-dev] [PATCH v2] " Alexander Kozyrev
  2 siblings, 0 replies; 8+ messages in thread
From: Ajit Khaparde @ 2021-01-26  5:36 UTC (permalink / raw)
  To: Alexander Kozyrev
  Cc: dpdk-dev, Slava Ovsiienko, Ori Kam, Thomas Monjalon,
	Ferruh Yigit, Andrew Rybchenko, Jerin Jacob

[-- Attachment #1: Type: text/plain, Size: 981 bytes --]

On Mon, Jan 25, 2021 at 7:38 PM Alexander Kozyrev <akozyrev@nvidia.com> wrote:
>
> IPv6 DSCP field ID is missing from the original list of Field IDs
> for MODIFY_FIELD action. Add it to support IPv6 header fully.
>
> Fixes: 73b68f4c54a ("ethdev: introduce generic modify flow action")
>
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

> ---
>  lib/librte_ethdev/rte_flow.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> index 46e8ee70ab..68c68cdd6c 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -2842,6 +2842,7 @@ enum rte_flow_field_id {
>         RTE_FLOW_FIELD_IPV4_TTL,
>         RTE_FLOW_FIELD_IPV4_SRC,
>         RTE_FLOW_FIELD_IPV4_DST,
> +       RTE_FLOW_FIELD_IPV6_DSCP,
>         RTE_FLOW_FIELD_IPV6_HOPLIMIT,
>         RTE_FLOW_FIELD_IPV6_SRC,
>         RTE_FLOW_FIELD_IPV6_DST,
> --
> 2.24.1
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dpdk-dev] [PATCH v2] ethdev: add IPv6 DSCP option for modify field action
  2021-01-26  3:38 [dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action Alexander Kozyrev
  2021-01-26  3:43 ` Stephen Hemminger
  2021-01-26  5:36 ` Ajit Khaparde
@ 2021-01-26 15:13 ` Alexander Kozyrev
  2021-01-27 11:52   ` Ferruh Yigit
  2 siblings, 1 reply; 8+ messages in thread
From: Alexander Kozyrev @ 2021-01-26 15:13 UTC (permalink / raw)
  To: dev
  Cc: viacheslavo, orika, thomas, ferruh.yigit, andrew.rybchenko,
	jerinjacobk, ajit.khaparde

IPv6 DSCP field ID is missing from the original list of Field IDs
for MODIFY_FIELD action. Add it to support IPv6 header fully.
Add ipv6_dscp option for the corresponding header field in testpmd.

Fixes: 73b68f4c54a ("ethdev: introduce generic modify flow action")

Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

---
v1: https://patchwork.dpdk.org/patch/87271/
v2: Squashed with testpmd patch:
https://patchwork.dpdk.org/patch/87273/
---
 app/test-pmd/cmdline_flow.c  | 2 +-
 lib/librte_ethdev/rte_flow.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 0618611ab1..fb1cba932b 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -592,7 +592,7 @@ static const char *const modify_field_ids[] = {
 	"start", "mac_dst", "mac_src",
 	"vlan_type", "vlan_id", "mac_type",
 	"ipv4_dscp", "ipv4_ttl", "ipv4_src", "ipv4_dst",
-	"ipv6_hoplimit", "ipv6_src", "ipv6_dst",
+	"ipv6_dscp", "ipv6_hoplimit", "ipv6_src", "ipv6_dst",
 	"tcp_port_src", "tcp_port_dst",
 	"tcp_seq_num", "tcp_ack_num", "tcp_flags",
 	"udp_port_src", "udp_port_dst",
diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
index 46e8ee70ab..68c68cdd6c 100644
--- a/lib/librte_ethdev/rte_flow.h
+++ b/lib/librte_ethdev/rte_flow.h
@@ -2842,6 +2842,7 @@ enum rte_flow_field_id {
 	RTE_FLOW_FIELD_IPV4_TTL,
 	RTE_FLOW_FIELD_IPV4_SRC,
 	RTE_FLOW_FIELD_IPV4_DST,
+	RTE_FLOW_FIELD_IPV6_DSCP,
 	RTE_FLOW_FIELD_IPV6_HOPLIMIT,
 	RTE_FLOW_FIELD_IPV6_SRC,
 	RTE_FLOW_FIELD_IPV6_DST,
-- 
2.24.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v2] ethdev: add IPv6 DSCP option for modify field action
  2021-01-26 15:13 ` [dpdk-dev] [PATCH v2] " Alexander Kozyrev
@ 2021-01-27 11:52   ` Ferruh Yigit
  0 siblings, 0 replies; 8+ messages in thread
From: Ferruh Yigit @ 2021-01-27 11:52 UTC (permalink / raw)
  To: Alexander Kozyrev, dev
  Cc: viacheslavo, orika, thomas, andrew.rybchenko, jerinjacobk, ajit.khaparde

On 1/26/2021 3:13 PM, Alexander Kozyrev wrote:
> IPv6 DSCP field ID is missing from the original list of Field IDs
> for MODIFY_FIELD action. Add it to support IPv6 header fully.
> Add ipv6_dscp option for the corresponding header field in testpmd.
> 
> Fixes: 73b68f4c54a ("ethdev: introduce generic modify flow action")
> 
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> 

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-01-27 11:52 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-26  3:38 [dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action Alexander Kozyrev
2021-01-26  3:43 ` Stephen Hemminger
2021-01-26  5:21   ` Alexander Kozyrev
2021-01-26  5:35     ` Ajit Khaparde
2021-01-26  5:44     ` Stephen Hemminger
2021-01-26  5:36 ` Ajit Khaparde
2021-01-26 15:13 ` [dpdk-dev] [PATCH v2] " Alexander Kozyrev
2021-01-27 11:52   ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).