From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6FC5A09E4; Thu, 28 Jan 2021 12:38:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C7754067A; Thu, 28 Jan 2021 12:38:42 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id DE54C40395 for ; Thu, 28 Jan 2021 12:38:39 +0100 (CET) IronPort-SDR: 85hkefMOTSGsj3VTzBNYPrYZpBgigOLuaAZrqQqPcW5EcLaxKy6cyw3KcIu9wuqN0fFY8xufdV +9GJU7+okqSg== X-IronPort-AV: E=McAfee;i="6000,8403,9877"; a="244305213" X-IronPort-AV: E=Sophos;i="5.79,382,1602572400"; d="scan'208";a="244305213" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 03:38:38 -0800 IronPort-SDR: KNIBnfNOb1Az6dvL1aYW0Dc9HqbF8AB1/+h00RCP7UngohCktOSEboINB0HpYS4ljfbK9DdGk2 PzBXAWEF/bIg== X-IronPort-AV: E=Sophos;i="5.79,382,1602572400"; d="scan'208";a="388767967" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.11.53]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 28 Jan 2021 03:38:37 -0800 Date: Thu, 28 Jan 2021 11:38:32 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com Message-ID: <20210128113832.GE899@bricha3-MOBL.ger.corp.intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> <20210127173330.1671341-1-bruce.richardson@intel.com> <20210127173330.1671341-8-bruce.richardson@intel.com> <5391890.O0HVAa98rt@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5391890.O0HVAa98rt@thomas> Subject: Re: [dpdk-dev] [PATCH v6 7/8] devtools: remove check-includes script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 28, 2021 at 12:10:41PM +0100, Thomas Monjalon wrote: > 27/01/2021 18:33, Bruce Richardson: > > +* The ``check-includes.sh`` script for checking DPDK header files has > > been + removed, being replaced by the ``check_includes`` build option > > described above. > > How do they compare? Is the new test checking C++ compliance? pedantic? > The new support does not do either of those things - though pedantic checks should be fairly easy to do - so I'm ok to drop this patch and not remove the script. Unfortunately, in my limited testing of it, the script has some usability issues now that on build all the lib includes are no longer copies to a single include folder. There is no automatic detection of include paths for other dependent headers, which means that to run the tool on e.g. ethdev lib, you need to set up the CFLAGS to include the paths to the net, eal, kvargs, meter, etc. libraries. Then again, it may work well on an installed DPDK instance for testing, but the fact that nobody has complained about it being hard to use before indicates that it is not being used, and if it's not being used I felt it as well to just drop it. /Bruce