From: David Hunt <david.hunt@intel.com> To: dev@dpdk.org Cc: david.hunt@intel.com, stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com> Subject: [dpdk-dev] [PATCH v5 2/6] power: make channel msg functions public Date: Fri, 29 Jan 2021 10:21:45 +0000 Message-ID: <20210129102149.24463-3-david.hunt@intel.com> (raw) In-Reply-To: <20210129102149.24463-1-david.hunt@intel.com> From: Bruce Richardson <bruce.richardson@intel.com> Move the 2 public functions into rte_power_guest_channel.h Fixes: 210c383e247b ("power: packet format for vm power management") Fixes: cd0d5547e873 ("power: vm communication channels in guest") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> Signed-off-by: David Hunt <david.hunt@intel.com> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com> --- changes in v3 * Mark both added functions as experimental changes in v4 * add @internal tag for Doxygen * add @warning EXPERIMENTAL tag for Doxygen * improve description of lcore param changes in v5 * moved version.map additions from patch 3 to patch 2 --- lib/librte_power/guest_channel.h | 40 +---------------- lib/librte_power/rte_power_guest_channel.h | 50 ++++++++++++++++++++++ lib/librte_power/version.map | 4 ++ 3 files changed, 55 insertions(+), 39 deletions(-) diff --git a/lib/librte_power/guest_channel.h b/lib/librte_power/guest_channel.h index d3d87f0ae..69020b030 100644 --- a/lib/librte_power/guest_channel.h +++ b/lib/librte_power/guest_channel.h @@ -65,21 +65,7 @@ void guest_channel_host_disconnect(unsigned int lcore_id); */ int guest_channel_send_msg(struct channel_packet *pkt, unsigned int lcore_id); -/** - * Send a message contained in pkt over the Virtio-Serial to the host endpoint. - * - * @param pkt - * Pointer to a populated struct channel_packet - * - * @param lcore_id - * lcore_id. - * - * @return - * - 0 on success. - * - Negative on error. - */ -int rte_power_guest_channel_send_msg(struct channel_packet *pkt, - unsigned int lcore_id); + /** * Read a message contained in pkt over the Virtio-Serial @@ -103,30 +89,6 @@ int power_guest_channel_read_msg(void *pkt, size_t pkt_len, unsigned int lcore_id); -/** - * Receive a message contained in pkt over the Virtio-Serial - * from the host endpoint. - * - * @param pkt - * Pointer to channel_packet or - * channel_packet_freq_list struct. - * - * @param pkt_len - * Size of expected data packet. - * - * @param lcore_id - * lcore_id. - * - * @return - * - 0 on success. - * - Negative on error. - */ -__rte_experimental -int -rte_power_guest_channel_receive_msg(void *pkt, - size_t pkt_len, - unsigned int lcore_id); - #ifdef __cplusplus } diff --git a/lib/librte_power/rte_power_guest_channel.h b/lib/librte_power/rte_power_guest_channel.h index ef3b064a8..c500c0cda 100644 --- a/lib/librte_power/rte_power_guest_channel.h +++ b/lib/librte_power/rte_power_guest_channel.h @@ -116,6 +116,56 @@ struct channel_packet_caps_list { uint8_t num_vcpu; }; +/** + * @internal + * + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Send a message contained in pkt over the Virtio-Serial to the host endpoint. + * + * @param pkt + * Pointer to a populated struct channel_packet. + * + * @param lcore_id + * Use channel specific to this lcore_id. + * + * @return + * - 0 on success. + * - Negative on error. + */ +__rte_experimental +int rte_power_guest_channel_send_msg(struct channel_packet *pkt, + unsigned int lcore_id); + +/** + * @internal + * + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Receive a message contained in pkt over the Virtio-Serial + * from the host endpoint. + * + * @param pkt + * Pointer to channel_packet or + * channel_packet_freq_list struct. + * + * @param pkt_len + * Size of expected data packet. + * + * @param lcore_id + * Use channel specific to this lcore_id. + * + * @return + * - 0 on success. + * - Negative on error. + */ +__rte_experimental +int rte_power_guest_channel_receive_msg(void *pkt, + size_t pkt_len, + unsigned int lcore_id); + #ifdef __cplusplus } diff --git a/lib/librte_power/version.map b/lib/librte_power/version.map index 69ca9af61..13f0af3b2 100644 --- a/lib/librte_power/version.map +++ b/lib/librte_power/version.map @@ -34,4 +34,8 @@ EXPERIMENTAL { rte_power_guest_channel_receive_msg; rte_power_poll_stat_fetch; rte_power_poll_stat_update; + + # added in 21.02 + rte_power_guest_channel_receive_msg; + rte_power_guest_channel_send_msg; }; -- 2.17.1
next prev parent reply other threads:[~2021-01-29 10:23 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-17 11:36 [dpdk-dev] [PATCH v1] power: fix make build for power apps David Hunt 2021-01-08 14:30 ` [dpdk-dev] [PATCH 0/6] " David Hunt 2021-01-08 14:30 ` [dpdk-dev] [PATCH v2 1/6] power: create guest channel public header file David Hunt 2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 0/6] power: fix make build for power apps David Hunt 2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 1/6] power: create guest channel public header file David Hunt 2021-01-20 15:09 ` Burakov, Anatoly 2021-01-20 15:12 ` David Hunt 2021-01-21 17:21 ` [dpdk-dev] [PATCH v4 0/6] power: fix make build for power apps David Hunt 2021-01-21 17:21 ` [dpdk-dev] [PATCH v4 1/6] power: create guest channel public header file David Hunt 2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 0/6] power: fix make build for power apps David Hunt 2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 1/6] power: create guest channel public header file David Hunt 2021-01-29 10:21 ` David Hunt [this message] 2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 3/6] power: rename public structs David Hunt 2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 4/6] power: rename defines David Hunt 2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 5/6] power: add new header file to export list David Hunt 2021-01-29 10:21 ` [dpdk-dev] [PATCH v5 6/6] power: clean up includes David Hunt 2021-01-29 10:30 ` [dpdk-dev] [PATCH v5 0/6] power: fix make build for power apps Thomas Monjalon 2021-01-21 17:21 ` [dpdk-dev] [PATCH v4 2/6] power: make channel msg functions public David Hunt 2021-01-22 12:12 ` Burakov, Anatoly 2021-02-22 9:53 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit 2021-01-21 17:21 ` [dpdk-dev] [PATCH v4 3/6] power: rename public structs David Hunt 2021-01-22 12:15 ` Burakov, Anatoly 2021-01-22 12:18 ` Burakov, Anatoly 2021-01-22 12:18 ` Burakov, Anatoly 2021-01-28 22:57 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon 2021-02-22 9:56 ` Ferruh Yigit 2021-01-21 17:21 ` [dpdk-dev] [PATCH v4 4/6] power: rename defines David Hunt 2021-01-22 13:50 ` Burakov, Anatoly 2021-01-21 17:22 ` [dpdk-dev] [PATCH v4 5/6] power: add new header file to export list David Hunt 2021-01-22 13:51 ` Burakov, Anatoly 2021-01-21 17:22 ` [dpdk-dev] [PATCH v4 6/6] power: clean up includes David Hunt 2021-01-22 13:53 ` Burakov, Anatoly 2021-01-29 10:27 ` [dpdk-dev] [dpdk-stable] [PATCH v4 0/6] power: fix make build for power apps Thomas Monjalon 2021-02-24 14:54 ` [dpdk-dev] [PATCH] power: remove duplicated symbols from map file Ferruh Yigit 2021-02-25 9:11 ` David Marchand 2021-02-25 10:41 ` Ferruh Yigit 2021-02-25 10:44 ` David Marchand 2021-02-25 10:54 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit 2021-02-25 14:38 ` David Marchand 2021-03-02 12:42 ` David Marchand 2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 2/6] power: make channel msg functions public David Hunt 2021-01-20 14:26 ` Burakov, Anatoly 2021-01-20 15:08 ` David Hunt 2021-01-20 15:23 ` Burakov, Anatoly 2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 3/6] power: rename public structs David Hunt 2021-01-20 14:27 ` Burakov, Anatoly 2021-01-20 15:03 ` David Hunt 2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 4/6] power: rename defines David Hunt 2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 5/6] power: add new header file to export list David Hunt 2021-01-20 14:28 ` Burakov, Anatoly 2021-01-20 15:01 ` David Hunt 2021-01-20 15:17 ` Burakov, Anatoly 2021-01-20 15:08 ` Bruce Richardson 2021-01-20 15:18 ` Burakov, Anatoly 2021-01-20 15:29 ` David Hunt 2021-01-20 15:43 ` Burakov, Anatoly 2021-01-20 13:55 ` [dpdk-dev] [PATCH v3 6/6] power: clean up includes David Hunt 2021-01-08 14:30 ` [dpdk-dev] [PATCH v2 2/6] power: make channel msg functions public David Hunt 2021-01-19 14:31 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon 2021-01-19 14:51 ` David Hunt 2021-01-08 14:30 ` [dpdk-dev] [PATCH v2 3/6] power: rename public structs David Hunt 2021-01-08 14:30 ` [dpdk-dev] [PATCH v2 4/6] power: rename defines David Hunt 2021-01-08 14:30 ` [dpdk-dev] [PATCH v2 5/6] power: add new header file to export list David Hunt 2021-01-08 14:30 ` [dpdk-dev] [PATCH v2 6/6] power: clean up includes David Hunt 2021-01-13 11:08 ` [dpdk-dev] [PATCH 0/6] power: fix make build for power apps Burakov, Anatoly 2021-01-13 11:14 ` David Hunt 2021-01-13 11:18 ` Burakov, Anatoly 2021-01-13 13:25 ` David Hunt 2021-01-13 17:30 ` Burakov, Anatoly
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210129102149.24463-3-david.hunt@intel.com \ --to=david.hunt@intel.com \ --cc=bruce.richardson@intel.com \ --cc=dev@dpdk.org \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git