From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE9FBA052A; Tue, 2 Feb 2021 13:23:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 139F92402AD; Tue, 2 Feb 2021 13:23:09 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id E99EE2402AD for ; Tue, 2 Feb 2021 13:23:07 +0100 (CET) IronPort-SDR: oZ3esIaScslOH7O03tSzXP896i7S+/yGeKLE6+Sr59gTwbcOEJQMJ0DhA0hKEVCwKCGca0iC0i k3V5zzBMJcFA== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="180919901" X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="180919901" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 04:23:06 -0800 IronPort-SDR: qY3fTucVE4i2Q7knWyKVo/RdekJFVN2ITc6bhVGpvlxmPViUz5u3m56/YN995mW6hew2Ls5aaD F3bZuXFiBdsw== X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="370628824" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.15.2]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 02 Feb 2021 04:23:05 -0800 Date: Tue, 2 Feb 2021 12:23:02 +0000 From: Bruce Richardson To: David Marchand Cc: dev , Thomas Monjalon Message-ID: <20210202122302.GB139@bricha3-MOBL.ger.corp.intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> <20210129164823.3205861-1-bruce.richardson@intel.com> <20210129164823.3205861-9-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v7 08/10] buildtools/chkincs: add app to verify header includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Feb 02, 2021 at 12:36:34PM +0100, David Marchand wrote: > On Fri, Jan 29, 2021 at 5:49 PM Bruce Richardson > wrote: > > diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build > > new file mode 100644 > > index 0000000000..f345e87551 > > --- /dev/null > > +++ b/buildtools/chkincs/meson.build > > @@ -0,0 +1,36 @@ > > +# SPDX-License-Identifier: BSD-3-Clause > > +# Copyright(c) 2021 Intel Corporation > > + > > +if not get_option('check_includes') > > + build = false > > + subdir_done() > > +endif > > + > > +if is_windows > > + # for windows, the shebang line in the script won't work. > > + error('option "check_includes" is not supported on windows') > > +endif > > + > > +gen_c_file_for_header = find_program('gen_c_file_for_header.py') > > +gen_c_files = generator(gen_c_file_for_header, > > + output: '@BASENAME@.c', > > + arguments: ['@INPUT@', '@OUTPUT@']) > > + > > +cflags = machine_args > > +cflags += '-Wno-unused-function' # needed if we include generic headers > > With http://patchwork.dpdk.org/patch/87567/, we have no direct > inclusion of the generic headers remaining. > This flag could be removed. > WDYT? > If it can be removed, it should be, IMHO. /Bruce