From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58403A052A; Tue, 2 Feb 2021 18:48:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 460A6240381; Tue, 2 Feb 2021 18:48:59 +0100 (CET) Received: from mail1.bemta26.messagelabs.com (mail1.bemta26.messagelabs.com [85.158.142.115]) by mails.dpdk.org (Postfix) with ESMTP id 9E14424037A; Tue, 2 Feb 2021 18:48:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rbbn.com; s=rbbnselector03122020; t=1612288137; i=@rbbn.com; bh=V8bzTjJRHPQKeH76MURKHZR2vwz7ben5tZyAkFnva2M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=EkYgKteqibU6/crrIu903gFD9V/Sg6yG7c8gjHxscVN0QTo5xDqzpd22cHMwFECpA /u2OpTqblTmIhw3hS4rHk6a5iHRMR55INEMLjGMF940nrMrGViQLSIbadBUMv/g1nA afHNtdhB7sYAC3AhcDQisLYyUPeAxikRn2uOV8UtoMsmTf4hqK0gXWsyR942by8+Vf qagWHjvVx7Y1y8aj5TZkrOgUZMyFtwM2EB7Y2DN4jzJhIeQ/XCI2322GX/AWEW2Q/P Lw5+NsRYQ4Ac8GreaP5kiK4Ximnz4Erimrla1NDQARaIINDr5ZSPMg5C/Ih/PH19zw MS1mk1hdvjgIw== Received: from [100.113.6.165] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-4.bemta.az-b.eu-central-1.aws.symcld.net id F4/50-50748-88099106; Tue, 02 Feb 2021 17:48:56 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJJsWRWlGSWpSXmKPExsWSoW++WrdjgmS CwaQ5mhbvPm1nsrhzooXVYubBF+wW868uZbf41/GH3WJP414WBzaPXwuWsnr0Nr9jC2CKYs3M S8qvSGDNuP5wLVvBDYGKjzMPMzUwXuXtYuTiYBRYyizx/dwc5i5GTiDnGIvE1bssEIlVjBKd8 /8wgiRYBHYzSxyboAiR6GKU6NgxjQ3EERKYzyTRO/sRlHOHUWLjg3vsIC1sAioSN1ungM0VEQ iXOLh1H1icWcBBYsWaJlYQW1jAT+Jn60uoFaoSC47tBIvzChhL3F/2gAXElhDQkDiwbhcbiM0 pYCJxYMpNoJkcQMuMJTZ/8IQYKSFx8MULsLCEgILEt4faIOdICExjlJh9fiMTSI2QgLTEq6Pz WSDGC0qcnPkEaryOxN9FjawQNTOZJNZ+ioCIy0ocPTsHqsZXYuP/V2wQtpbEs+dHWSF2qUjcf mIDEc6RuHp+MVSJmsTSM5+hbDmJU73nmCBsGYmJey6wQNy2h0Xix/sOlgmMurOQvDALyXkLGJ lWMVomFWWmZ5TkJmbm6BoaGOgaGhrrmugaGZjqJVbpJumlluomp+aVFCUCZfUSy4v1iitzk3N S9PJSSzYxAlNNSiHL2R2MX15/0DvEKMnBpCTK62IgmSDEl5SfUpmRWJwRX1Sak1p8iFGGg0NJ glewHygnWJSanlqRlpkDTHswaQkOHiUR3mUgad7igsTc4sx0iNQpRl2OCS/nLmIWYsnLz0uVE ue1AikSACnKKM2DGwFLwZcYZaWEeRkZGBiEeApSi3IzS1DlXzGKczAqCfNu7gOawpOZVwK36R XQEUxAR3zcKgZyREkiQkqqgWn2y+4exoCjsoksuc9dstSmz91a9zxYkXHf8R+/4/bVa2+bcGH fvSm8W0ticr05nt5j/zlRwd2rO/3g6tmXi89la9ztv/zlwNzv+fuPb3NvehKtdqxNujc2xXs2 bxLP1l8PP2zcc3L/qoab0VvTr9e0GrZbXTWI/3v+C1udlHbNy9sr7Q4FZn7YNu3H3hSXWZbS6 d/jp4ibztmxwtXv/OKH8rdlOI+eVMs8+cD1QM0JvUtrJG+YtpxYqPk82OWEkPAhlpVvesT+JV /+LerJWXRs/4m2xw4rtm0Nfq5Yp33hju/Xz5YhKbser7219q35dZFLV/7o2Z4qVc2LO3vou8d 3jidz731m+L9A/db1R0onmpRYijMSDbWYi4oTAYVfers8BAAA X-Env-Sender: sodey@rbbn.com X-Msg-Ref: server-8.tower-248.messagelabs.com!1612288134!128002!1 X-Originating-IP: [104.47.55.171] X-SYMC-ESS-Client-Auth: mailfrom-relay-check=pass X-StarScan-Received: X-StarScan-Version: 9.60.3; banners=rbbn.com,-,- X-VirusChecked: Checked Received: (qmail 5633 invoked from network); 2 Feb 2021 17:48:55 -0000 Received: from mail-bn8nam12lp2171.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) (104.47.55.171) by server-8.tower-248.messagelabs.com with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 2 Feb 2021 17:48:55 -0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CM+V1jHjDsFSSIUZTC6wGkRo5E3zEB1nFI+CVFDbCVJVLpr1gMO0Fq3Kx0PWshIhzUpF2fCRzkB3WlP80l+LhevZKc8XNeV48cde/WEyUh+q53PyBr2OwW0aZ1aXFvge3Ijtxd59NBBKsNNLA3Gk9JwmtGvG+TFIrT1zb0LsNKnVmU0nL0JdbCbhrCFzZVqpOF5OgR6i+RmFkeo9PUVhGeQKDToMM/EV3z5vVVwcoipw1xbtPZrhqJbks6fnQCC6u+iTOeSjCgR9xyh7ZUOYageXInYnG0MBYWWup2NeTPtC+pmhtTJquJ5rK8MHs+Z6IG3D0fQMuRdFiVByyBhdBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ElRF/X2kdy48XiX80A5DKqu9BfX5UC+oeMZuzYLD7Jc=; b=cvnxuUhqB8Ptil5c1jbWQZpV/XxIyZUEyYZLAMFW2sJei0pqCoBYq9CQ6VSgov67xIicBnyG1LN5POC5MpasBq6IMjzF+kyT3hUibOwgSIjT3syKftlP3rvL4fZVYwPNy2zYcnqOgUp4jmm9rcgskgnLce9mklPS0UCT+TFn7BkOeCQha1H9B/zDgbAdlyXbFWf5kwWDn7Dd/KoqVqkov5uKbSq8e/613Sm5xLNrwucfK+C/hesGYgx+jCkwbsC4SfHwbSxvYG8rXWf8ncBizC8TQJGy0wyv2a8+ZmrkM4lXn2BNqcIw789ZYlm95rsxQJypd5Y3XPoN9mI1IpN9Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=rbbn.com; dmarc=pass action=none header.from=rbbn.com; dkim=pass header.d=rbbn.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SonusNetworks.onmicrosoft.com; s=selector2-SonusNetworks-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ElRF/X2kdy48XiX80A5DKqu9BfX5UC+oeMZuzYLD7Jc=; b=MU6+QdLDSo9QvpGjTNRpaVeD+T2oe1u34Bjx3r6LwN5L4aU+FAqelpvr502jp9oDUPfp8f1SKy1o+NHkPX7gZuSQ6INs7kNqaQlHF97ppcBjPR49STCzCQ8hHirrYipY37u2X1JB2BHR+k5aSntTexW1ajHLds1MKGfvJMn43TU= Received: from MN2PR03MB4781.namprd03.prod.outlook.com (2603:10b6:208:ae::23) by MN2PR03MB4719.namprd03.prod.outlook.com (2603:10b6:208:106::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.17; Tue, 2 Feb 2021 17:48:52 +0000 Received: from MN2PR03MB4781.namprd03.prod.outlook.com ([fe80::98a1:94ae:41f1:cc8]) by MN2PR03MB4781.namprd03.prod.outlook.com ([fe80::98a1:94ae:41f1:cc8%7]) with mapi id 15.20.3805.027; Tue, 2 Feb 2021 17:48:52 +0000 From: "Dey, Souvik" To: rasland@nvidia.com, viacheslavo@nvidia.com, matan@nvidia.com, shahafs@nvidia.com Cc: dev@dpdk.org, stable@dpdk.org, Souvik Dey Date: Tue, 2 Feb 2021 12:48:40 -0500 Message-Id: <20210202174841.15784-1-sodey@rbbn.com> X-Mailer: git-send-email 2.9.3.windows.1 In-Reply-To: <20210202035352.24512-1-sodey@rbbn.com> References: <20210202035352.24512-1-sodey@rbbn.com> Content-Type: text/plain X-Originating-IP: [72.70.55.110] X-ClientProxiedBy: BL1PR13CA0203.namprd13.prod.outlook.com (2603:10b6:208:2be::28) To MN2PR03MB4781.namprd03.prod.outlook.com (2603:10b6:208:ae::23) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from SODEY-LMA.sonusnet.com (72.70.55.110) by BL1PR13CA0203.namprd13.prod.outlook.com (2603:10b6:208:2be::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3825.17 via Frontend Transport; Tue, 2 Feb 2021 17:48:51 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6ec069a9-0a94-4d83-427e-08d8c7a2cd6c X-MS-TrafficTypeDiagnostic: MN2PR03MB4719: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XFFG3jLi4DmQWW0/xg0ghkmXvX7imtEQNDMKwm4lzJJfeQJYb5lzBAt7m+8BKaoicUJCJACuHCrXXRElYopR6QbUt38uTUN2EQKZzyDFJTJC5vRO2G/MH8lmCi2+PVC3ixzw6NkE7fsyiuU6i/hUypHhZ0cyU5Fu2WC/2DqhMK3zLTUJPpJCtoRLjTBL5mw9Frg4cG7ILelY9TV5GkHmEjjTVtiKJzyONR5+8qUDYIXYKqbB2TGgZDE5TfExHyUWn30JVJ9jPHXAw0pT8TKI/EojwGETtLLbBc4btMhZ+SNKX8pYLXk7t7nmxgbIGJIxbOLOWbEq4otq0A1Aje8f9z6MJfbfxeT3mr52GSjPwb0mgvL0yFV8gAPPNijxQ57gr8T5On1qnPX/wYs0wBrXomqWSBa56PMvRSPHV9/abImtq6k/jXJv4GuBfQyKOinJP/r2iN/nWCXu+vCTueV2eY8UdD+ndZhPnEXu/nebi+6KQ/DwaLz+PXam2IlznRCg1C2q2PE4qMtUvToRdH9FSQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR03MB4781.namprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(396003)(136003)(346002)(39860400002)(83380400001)(66476007)(8676002)(8936002)(52116002)(2906002)(86362001)(6666004)(1076003)(66946007)(66556008)(26005)(478600001)(186003)(36756003)(6506007)(6486002)(6512007)(316002)(16526019)(2616005)(107886003)(956004)(4326008)(5660300002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?DW74xpaQivfeY+gg3iJkBRjfgnvy6Qqln8V8Kdj7yhAAtO+9/fzKlOb7e0n+?= =?us-ascii?Q?19wOp9GGW3jY8Ikhar/R91MMZhMrBJh6d+J23LhyyR39W00Rcmd21rsxcpdS?= =?us-ascii?Q?vZfxntYIYKX81bgJWhBFv+dPNjQF3g7hiMIw/oL/ahWNGv8SNeSbjbq/SnwC?= =?us-ascii?Q?1FSfQ++ve97LMJhMxIK+sukIN9cZFtYBitKFuZTwByKIyxsQbHD2gCXfK2pt?= =?us-ascii?Q?6XxX7QSr+f9L0EEwXMpSpZOF87E73FauaOSUYgi5IyxF+460K4MbBrLGSrHx?= =?us-ascii?Q?qtbyhqh14/ctAd4BsEcCVFPMWbjMnVLoSqnLDKk/vlredsKbjcYHnZowHAAr?= =?us-ascii?Q?q7Q0uV1M83bzswNtm9gAaUqAT+u5mIQLXYguUAUQIs21rcY4tQt8lVlngAvG?= =?us-ascii?Q?uHskMgaeZC0QLXPMNULj9/GjpfRBgDbGGJ2gF8AxXx8sI2SCAyskjF5wSANX?= =?us-ascii?Q?ICbtqczgDHzm1qV0cJcjxpT/RYpiqQ/jR2WXboImzKFplBWUpHZn03WGgtzV?= =?us-ascii?Q?1uJAjrME6u33BVlQGtlayLs+5XP1pKE0chg1ePstS9Csz2ohQa+TUyxoe8xc?= =?us-ascii?Q?R/f6yZjzd9igItcIxUtBVr3vSYZgf+7+/iCr7H4hsoHN91ftrcEc9DJxan1+?= =?us-ascii?Q?Sk0cOW9IoNFUD8Ek1BrW3mpZ1feq+T1QD/sm+MgqEK2qCm8bkWt1Kq0Nddvv?= =?us-ascii?Q?Y/xvfJGgmbcJYT9VeQt0iB/7lUDHlkEHwtGJBGE3jzNPFGyKcx+NZ/XWsBwH?= =?us-ascii?Q?B5AKsatHvOkCK4Ije+JI4jpokqk6gq1XxlDo9QluILRGsBMz39DUyEmb8DWd?= =?us-ascii?Q?8cZHHJBTtDv4tmn0csJXv0WIzehe4oo9dnzH+yAjRU5hU7kVIndfhAyPP8Cw?= =?us-ascii?Q?1fcB0J/ED6FUUyYJUlRnog56ZrpUqdbLdpkYmnGfr8rUWwetYuKIL7aXy8Mr?= =?us-ascii?Q?AFUR8JpkIKQM9NiE4/NCRQ/khe7cjIMvZy5Z75XfeBAB/zYCSE2+vjgqBhSt?= =?us-ascii?Q?AZo9V8xLCDvgSU2U3IsClveFeo1bxGmUwJeiDJcct2CI52+bHLsequFQ3+MD?= =?us-ascii?Q?Sjrx+fpT?= X-OriginatorOrg: rbbn.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ec069a9-0a94-4d83-427e-08d8c7a2cd6c X-MS-Exchange-CrossTenant-AuthSource: MN2PR03MB4781.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2021 17:48:52.0707 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Dp05p5p5QpKKiZZGU5pAiSWn0k6ko6FXhZwYJd01Wlj6nTZvmTZ6CfbNMXPUhwl+ X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB4719 Subject: [dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched MAC to internal table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Souvik Dey As the internal MAC table is divided into Unicast and Multicast address sections, we should check the type of synched MAC address before storing it to the internal table. Currently the check is not done, and the synched MAC of 33:33:00:00:00:01 gets stored in the unicast section (mostly index 1) causing all subsequent mlx5_set_mc_addr_list() to fail with error -EADDRINUSE, as the mac_list contains the MAC 33:33:00:00:00:01. This denies adding of any new multicast address to the internal list and also fails to add the MAC address to the device in case of SR-IOV VF. Fixes: f22442cb5d42 ('net/mlx5: reduce Netlink commands dependencies') Fixes: ccdcba53a3f4 ('net/mlx5: use Netlink to add/remove MAC addresses') Cc: stable@dpdk.org Signed-off-by: Souvik Dey --- v2: * net/ -> common/ * space after mlx5: * synched -> synched * section -> sections * rewording which causes -> causing * typo: case (to remove) * added Fixes for LTS ML --- v3: * Changed the "" in Fixes tags to ''. --- drivers/common/mlx5/linux/mlx5_nl.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/common/mlx5/linux/mlx5_nl.c b/drivers/common/mlx5/linux/mlx5_nl.c index 40d8620..ef7a521 100644 --- a/drivers/common/mlx5/linux/mlx5_nl.c +++ b/drivers/common/mlx5/linux/mlx5_nl.c @@ -758,11 +758,21 @@ mlx5_nl_mac_addr_sync(int nlsk_fd, unsigned int iface_idx, break; if (j != n) continue; - /* Find the first entry available. */ - for (j = 0; j != n; ++j) { - if (rte_is_zero_ether_addr(&mac_addrs[j])) { - mac_addrs[j] = macs[i]; - break; + if (rte_is_multicast_ether_addr(&macs[i])) { + /* Find the first entry available. */ + for (j = MLX5_MAX_UC_MAC_ADDRESSES; j != n; ++j) { + if (rte_is_zero_ether_addr(&mac_addrs[j])) { + mac_addrs[j] = macs[i]; + break; + } + } + } else { + /* Find the first entry available. */ + for (j = 0; j != MLX5_MAX_UC_MAC_ADDRESSES; ++j) { + if (rte_is_zero_ether_addr(&mac_addrs[j])) { + mac_addrs[j] = macs[i]; + break; + } } } } -- 2.9.3.windows.1 Notice: This e-mail together with any attachments may contain information of Ribbon Communications Inc. and its Affiliates that is confidential and/or proprietary for the sole use of the intended recipient. Any review, disclosure, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please notify the sender immediately and then delete all copies, including any attachments.