From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Ranjit Menon <ranjit.menon@intel.com>
Cc: Khoa To <khot@linux.microsoft.com>,
dev@dpdk.org, pallavi.kadam@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] bus/pci/windows: support for PCI scan allowed and blocked lists
Date: Fri, 19 Feb 2021 00:23:05 +0300 [thread overview]
Message-ID: <20210219002305.0000e93d@sovereign> (raw)
In-Reply-To: <2da301ca-f163-97a7-692d-2cfeecf819bd@intel.com>
On Thu, 18 Feb 2021 10:53:54 -0800, Ranjit Menon wrote:
> > +
> > + if (get_device_pci_address(dev_info, &device_info_data, &addr) != 0)
> > + continue;
> > +
> > + if (rte_pci_ignore_device(&addr))
> > + continue;
> > +
> > ret = pci_scan_one(dev_info, &device_info_data);
> > if (ret == ERROR_SUCCESS)
> > found_device++;
> I think this change can be made inside the pci_scan_one() function where
> we already call
>
> get_device_pci_address().
+1, even to place this check before other actions in pci_scan_one().
next prev parent reply other threads:[~2021-02-18 21:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 5:40 [dpdk-dev] [PATCH] " Khoa To
2021-02-18 18:40 ` [dpdk-dev] [PATCH v2] " Khoa To
2021-02-18 18:53 ` Ranjit Menon
2021-02-18 21:23 ` Dmitry Kozlyuk [this message]
2021-03-01 6:22 ` [dpdk-dev] [PATCH v3] " Khoa To
2021-03-01 6:52 ` [dpdk-dev] [PATCH v4] " Khoa To
2021-03-04 0:21 ` Ranjit Menon
2021-03-04 0:26 ` Khoa To
2021-03-04 7:14 ` Dmitry Kozlyuk
2021-03-16 21:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219002305.0000e93d@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=dev@dpdk.org \
--cc=khot@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).