From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E923DA034F; Sun, 21 Feb 2021 11:24:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4AE0422A281; Sun, 21 Feb 2021 11:24:14 +0100 (CET) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by mails.dpdk.org (Postfix) with ESMTP id 8F9CF22A27C for ; Sun, 21 Feb 2021 11:24:12 +0100 (CET) Received: by mail-lj1-f172.google.com with SMTP id e8so7557571ljj.5 for ; Sun, 21 Feb 2021 02:24:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=n4R6utB+e8JXWlB1CE6oGJkVI5FXWJ33s1qgGp0xCG0=; b=QcA41ceKquFPCRySKDd4XWJnAz41IEqu/3Xj/93/899GKMzppuIS1C8Z17FG8AmSqa pIzO7vYQSJGLrAu2IHKZ9ILFGEZKzJTbFt6voRsA+GAdxHjGuqktWvcubQHFWGjPBylE pnvILooaBCr1zAK7fNK7Ac3IPSmPWMkAPpNltpko8nkCdTOFugAVVZKUxKnua9YxvP01 L8+guJtgD5ANuHbieUXhTYSOjlhvfSd8Rovbyst6rYubwjOHNcE7spdBPkzVDVUnD0Vu 8Oi/so9MsfvBoE0I9XSZDf2m6lmJGcaaL0lyv2iT9G40j9Pppo/a6mdQ8VqXTN5sFt5/ nBhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=n4R6utB+e8JXWlB1CE6oGJkVI5FXWJ33s1qgGp0xCG0=; b=PUtWrXvWLmssmUbhfPJmxCU91+GfWy0PO4OCOrnoITf+/RDTUpVXr1vpwJUzcvyQAP dOK3isY04HWQrvTwSaZ+ka4rs+fZJzks+Cfvhjlx19YExgm1ClvYc5YsnwJP4iPZLget qF2AMgAMNAsqgsE4jlD+g95eQxcuQPqzMyO+bEEsD2UUhbF7vGfSXEAjTz41i3Ifyum0 9MvLbYeKMB9VZsskW6a5YeInqDW1Ffk8SPCCasBGUPG+yFpRorbw7TkZ6b46Jak7ka3j sRpMUunOpJXr8OgvWi57LkB8Iyo/f2VUwp6Wtekzzwkg1hOMo42cazlAoX3tt08PL97D 34Jg== X-Gm-Message-State: AOAM530ugjCdIvKpGXrqBBY+oY3Whqpga0D13yShtIjkA6dgkSksCSXm 37j9M1H2kmYQF8Hniq/wSag= X-Google-Smtp-Source: ABdhPJzX67HIauzgpHL2BbJkgO/tERZuLyasNvNltW4zlQJvUvFfxDxloWh67GPsoMI9FsRfP7UDcg== X-Received: by 2002:a19:ae02:: with SMTP id f2mr10541531lfc.129.1613903052111; Sun, 21 Feb 2021 02:24:12 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id h14sm1569674lji.65.2021.02.21.02.24.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Feb 2021 02:24:11 -0800 (PST) Date: Sun, 21 Feb 2021 13:24:10 +0300 From: Dmitry Kozlyuk To: Tal Shnaiderman Cc: "dev@dpdk.org" , Tyler Retzlaff , Nick Connolly , Bruce Richardson , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Message-ID: <20210221132410.3a42e3ad@sovereign> In-Reply-To: References: <20210220232910.772-1-dmitry.kozliuk@gmail.com> <20210221012831.14643-1-dmitry.kozliuk@gmail.com> <20210221012831.14643-8-dmitry.kozliuk@gmail.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 7/7] eal/windows: do not expose POSIX symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, 21 Feb 2021 08:59:50 +0000, Tal Shnaiderman wrote: [...] > > -#ifndef close > > -#define close _close > > -#endif > > mlx5 uses close() in mlx5.c and is broken after this change above, BTW why not add an rte_close instead of local definition? I'm reluctant to add file manipulation API to EAL. It would be replication of POSIX with "rte_" prefix, while standard C has everything needed to deal with files (and IOCTLs are platform-specific code anyway). I think libraries and PMDs striving to be cross-platform should move to using FILE* some day. For now, local definitions keep them running without any risk of breakage. Thanks for all your comments, it's weird I didn't hit the failures locally. Will fix in v3.