From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50DA3A034F; Mon, 22 Feb 2021 23:34:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0CFF140138; Mon, 22 Feb 2021 23:34:33 +0100 (CET) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by mails.dpdk.org (Postfix) with ESMTP id 2BA234003C for ; Mon, 22 Feb 2021 23:34:31 +0100 (CET) Received: by mail-pg1-f176.google.com with SMTP id t11so11142143pgu.8 for ; Mon, 22 Feb 2021 14:34:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VUYPgVGK9lIihK0L2fay8FvWgDOfDf54vKvS27rDLeg=; b=F+6ewpRfIDyhln7CekakOPdPhcR1KKU4+srW58DFc/DqMsixa/jydAwU+csrKPozv5 j5YqrP57LSR15MtVjUID20ks/gYi/46hjZ2KrUE3Kxc4odxOk6XTn9iQpS2wngT80h9X hZEDM8HXt8QUciaFubsg1NvkhYdBPLFh5ySEzojouZLz8T5Jc2n3dmeSXREM/cm10faJ SLYnTtY4FDqXcektvyBD0HPfJK8Aj4v7kQarVQI8vsKTMImq92bDfqby5Yv6KE4FjLsG dQ3JaSUhq9OrkRj+Oyxq5hO4tuwleD0+pY6ma/K9ga8YJZfvzdZMwhiNyzO7zxVONq6l QSfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VUYPgVGK9lIihK0L2fay8FvWgDOfDf54vKvS27rDLeg=; b=U78+QmVAfEOk/HT+vGxbW6/H25twOtZqfy2AnOngHBFB/vgaCcCsN2Fh1X8tGmdihm M4KI+8Nm7X0uvqmcolABY/3bPmUv/SekOsL9zb4hCx4uGcc0UxMzF5cmHXvtP+A2V7x2 FT0N3YeKKUnA4sv/S1XLX6FQV7JQww3PoiwnTFfJz2jcvzZyH62ildmHCG3xUykwhTTm dbz53TXaOB5n2RIXSTRKMj79SWyy+KLSiHgn0cbxNBt8ATRp3jPb0/Imw/7X/nxPr5Ek DPkNbjZe4qMQp4XVbcBSP+CboJd++XThxKrgH8yHeGxiFv+IzD1MMdSFw0qB4VFIHrD+ ezWQ== X-Gm-Message-State: AOAM531NyQ2grh3o1zKrsGG+NdvGpH9hgu1Mrc6ijETE+us8AGKpC5kW AkOQsN1RPDTIoO0CLfhGZZN3MA== X-Google-Smtp-Source: ABdhPJxjUXojO08IPz+waPM775O1zaga7KvN+w8BFVvs6RvvwOExbq198enI4FAFg16X5bSax4dEGQ== X-Received: by 2002:a63:6705:: with SMTP id b5mr2618647pgc.165.1614033270125; Mon, 22 Feb 2021 14:34:30 -0800 (PST) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id 134sm20874288pfc.113.2021.02.22.14.34.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Feb 2021 14:34:29 -0800 (PST) Date: Mon, 22 Feb 2021 14:34:22 -0800 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com, Timothy McDaniel , Hemant Agrawal , Nipun Gupta , Mattias =?UTF-8?B?UsO2bm5ibG9t?= , Jerin Jacob , Pavan Nikhilesh , Liang Ma , Peter Mccarthy , Harry van Haaren , Abhinandan Gujjar , Jay Jayatheerthan , Erik Gabriel Carrillo Message-ID: <20210222143422.65e50231@hermes.local> In-Reply-To: <20210129164823.3205861-7-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> <20210129164823.3205861-1-bruce.richardson@intel.com> <20210129164823.3205861-7-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 06/10] eventdev: make driver-only headers private X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There are many vendors (including some internal Microsoft projects) with drivers that are not in the DPDK tree. Breaking them is not something that should be done, and certainly not in a release that claims API/ABI compatibility. Although these fields should not have been exposed to user in normal header files, you can't just remove them now. Please revert this commit before 20.02 final release. A better solution (like __rte_internal) can be added in the 21.11 release.