From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8FBC1A0565; Thu, 4 Mar 2021 00:54:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 511BB40FDF; Thu, 4 Mar 2021 00:54:34 +0100 (CET) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id 6EC9440147 for ; Thu, 4 Mar 2021 00:54:32 +0100 (CET) Received: by mail-pj1-f47.google.com with SMTP id s23so5460438pji.1 for ; Wed, 03 Mar 2021 15:54:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VqUiq+DX11xv/i+pbrB2ybFlxeh99xDtNbJqkZ4xPtY=; b=1Ka2Cm0N7VVviCgq06IVOdcjEbUF2q1B1EAz5zw/88enOYqoL/d2pI/WCP20LTs7zo MCpTRottz7UiVVlqEGbhFZ5gqGmLrCK3VtHXXMSuCEqK3kLajSjULola8st2VugHctD+ nPjv06U3T91wXZv9+TFd8YcSBs6e1V2XX7yRJ+lCJxWxks6gK4+opUi1+9XfqfCdKiG7 idQkINXHGPXhnp2LONCGGjKJ6JK9vcNCWNtrP6ylS41fMq/Vl8lq9aQxwZVLObbRSIw8 qkSv5A3NWmoftW01b0d0215cvojpjqcrrVqeRxA7zdDjwslIgQ8iJPsI24+7OfWpwDEQ NoLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VqUiq+DX11xv/i+pbrB2ybFlxeh99xDtNbJqkZ4xPtY=; b=m4zcoVizoWU6cyLC4N31CknQ1IkXBobEAZ5Dn46WvZxbrdcsLpv/pwoz8tn9br/qqH XhIBdyNacpNNVsy4tFlH9zRICLqOoOR10wvp0AWeL2UR80W7jW5L7InIo0OjyJFXOzWq 2jc2dJ1PNB9vpPIubB7SWGNlKuQOX02VKzpFvQPLsCxPkT8EyH7KQPoN8Ff3V0uEzung Zg/Av1SpMcW2ZOjVP/+T/YEOdXD0B0dffQCGgHcdlLsmceQMvVl7u5IX9ZQ3IRYgtF5r ybc/R70o9CZbNf8tlGkflAUO1CoKkMzbLbDnKm2mU9RasTZzOAUrZreKqIm7lK4MAreN THyQ== X-Gm-Message-State: AOAM533a+i4AwkKn8JSCtqVTZ9VfYa5U1ysbaALUlfTntpClQc5ZQz5E KITRnsej3S22pIw229oWnffw8A== X-Google-Smtp-Source: ABdhPJwZVB25jEEf5ubUA5f7w1WEN+3f3rY/gwccwvrYhK12XTrFNcllnBnDJBUCgminIy2lKhysLA== X-Received: by 2002:a17:90a:1b4e:: with SMTP id q72mr1484528pjq.113.1614815671512; Wed, 03 Mar 2021 15:54:31 -0800 (PST) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id x14sm25974490pfm.207.2021.03.03.15.54.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 15:54:31 -0800 (PST) Date: Wed, 3 Mar 2021 15:54:22 -0800 From: Stephen Hemminger To: Dmitry Kozlyuk Cc: dev@dpdk.org, Ferruh Yigit , Pallavi Kadam , Dmitry Malloy , Narcisa Ana Maria Vasile , Ray Kinsella , Neil Horman Message-ID: <20210303155422.6bead163@hermes.local> In-Reply-To: <20210303225121.16146-1-dmitry.kozliuk@gmail.com> References: <20210303225121.16146-1-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] doc: announce renaming of rte_ether_hdr fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > + > +* net: ``s_addr`` and ``d_addr`` fields of ``rte_ether_hdr`` structure > + will be renamed to ``src_addr`` and ``dst_addr`` respectively in DPDK 20.11 > + in order to avoid conflict with Windows Sockets headers. If those fields were a problem now, there might be others in future. Don't use src_addr and dst_addr because those are already used in rte_ipv4_hdr. Linux and FreeBSD use: struct ether_header { uint8_t ether_dhost[ETH_ALEN]; /* destination eth addr */ uint8_t ether_shost[ETH_ALEN]; /* source ether addr */ uint16_t ether_type; /* packet type ID field */ } __attribute__ ((__packed__)); So why not ether_dhost/ether_shost?