From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABB4EA0567; Tue, 9 Mar 2021 15:04:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B3314069D; Tue, 9 Mar 2021 15:04:20 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 7C5704068A for ; Tue, 9 Mar 2021 15:04:19 +0100 (CET) IronPort-SDR: WEmDygc4kxyEwvL/wWFGjjePFMtMQisnTjC8zt9o4xwjJ7ZHAzfMfBJokUA3e6JxcAiyx9x4zT z4J/ygWhUwpQ== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="167511213" X-IronPort-AV: E=Sophos;i="5.81,234,1610438400"; d="scan'208";a="167511213" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2021 06:04:00 -0800 IronPort-SDR: obH4pHgI1rqM+XWktNYXjmEqEW8a9gAB4T3ATX2kNTwEfYr5KWL1mSUtWmIhmD9ohgQrBY3S5g W6e74bIu8+SQ== X-IronPort-AV: E=Sophos;i="5.81,234,1610438400"; d="scan'208";a="447509398" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.21.187]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 09 Mar 2021 06:03:58 -0800 Date: Tue, 9 Mar 2021 14:03:55 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20210309140355.GA1141@bricha3-MOBL.ger.corp.intel.com> References: <20210308222339.819494-1-thomas@monjalon.net> <20210309105952.GB1127@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210309105952.GB1127@bricha3-MOBL.ger.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH] eal: prefix telemetry initialization message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 09, 2021 at 10:59:52AM +0000, Bruce Richardson wrote: > On Mon, Mar 08, 2021 at 11:23:38PM +0100, Thomas Monjalon wrote: > > If the telemetry library initialization has some issue, > > the error message is returned in a string > > (to avoid circular dependency with EAL log system). > > > > In order to make clear where the message comes from, > > a prefix is added. > > Before: EAL: message > > After: EAL: telemetry: message > > > > Signed-off-by: Thomas Monjalon > > --- > Acked-by: Bruce Richardson By the way, I have a nearly completed patch for the telemetry library to switch it to doing its own logging instead of passing back a string. It does require a function pointer to rte_log to be passed to the init call, but thereafter things are pretty normal in it and simplifies things. I'll send it on as soon as it is ready. /Bruce