* [dpdk-dev] [PATCH 0/2] bnxt bug fixes
@ 2021-03-10 7:50 Kalesh A P
2021-03-10 7:50 ` [dpdk-dev] [PATCH 1/2] net/bnxt: fix HWRM and FW incompatibility handling Kalesh A P
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Kalesh A P @ 2021-03-10 7:50 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, ajit.khaparde
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
This series contain couple of bug fixes in bnxt PMD.
Kalesh AP (2):
net/bnxt: fix HWRM and FW incompatibility handling
net/bnxt: mute some failure logs
drivers/net/bnxt/bnxt_hwrm.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
--
2.10.1
^ permalink raw reply [flat|nested] 11+ messages in thread* [dpdk-dev] [PATCH 1/2] net/bnxt: fix HWRM and FW incompatibility handling
2021-03-10 7:50 [dpdk-dev] [PATCH 0/2] bnxt bug fixes Kalesh A P
@ 2021-03-10 7:50 ` Kalesh A P
2021-03-10 7:50 ` [dpdk-dev] [PATCH 2/2] net/bnxt: mute some failure logs Kalesh A P
2021-03-11 23:58 ` [dpdk-dev] [PATCH 0/2] bnxt bug fixes Ajit Khaparde
2 siblings, 0 replies; 11+ messages in thread
From: Kalesh A P @ 2021-03-10 7:50 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, ajit.khaparde
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Fix to return an error when the HWRM version that the driver
is compiled against is incompatible with the FW that is actually
running on the card. This is determined based on the req length
indicated by FW against the value supported in the HWRM.
Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code")
Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
drivers/net/bnxt/bnxt_hwrm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 0b5318e..582f4d1 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -1143,6 +1143,7 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout)
if (bp->max_req_len > resp->max_req_win_len) {
PMD_DRV_LOG(ERR, "Unsupported request length\n");
rc = -EINVAL;
+ goto error;
}
bp->chip_num = rte_le_to_cpu_16(resp->chip_num);
--
2.10.1
^ permalink raw reply [flat|nested] 11+ messages in thread* [dpdk-dev] [PATCH 2/2] net/bnxt: mute some failure logs
2021-03-10 7:50 [dpdk-dev] [PATCH 0/2] bnxt bug fixes Kalesh A P
2021-03-10 7:50 ` [dpdk-dev] [PATCH 1/2] net/bnxt: fix HWRM and FW incompatibility handling Kalesh A P
@ 2021-03-10 7:50 ` Kalesh A P
2021-03-11 23:58 ` [dpdk-dev] [PATCH 0/2] bnxt bug fixes Ajit Khaparde
2 siblings, 0 replies; 11+ messages in thread
From: Kalesh A P @ 2021-03-10 7:50 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, ajit.khaparde
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
In the init path, driver ignores few of the HWRM command failures.
There is no need to log the error message in those cases.
Fixes: 3fb93bc7c349 ("net/bnxt: initialize parent PF information")
Fixes: 4e3f887bec4b ("net/bnxt: support HWRM port PHY qcaps")
Cc: stable@dpdk.org
Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_hwrm.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 582f4d1..8927d41 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -1414,7 +1414,7 @@ int bnxt_hwrm_port_phy_qcaps(struct bnxt *bp)
rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
- HWRM_CHECK_RESULT();
+ HWRM_CHECK_RESULT_SILENT();
bp->port_cnt = resp->port_cnt;
if (resp->supported_speeds_auto_mode)
@@ -3250,7 +3250,7 @@ int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp)
rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
- HWRM_CHECK_RESULT();
+ HWRM_CHECK_RESULT_SILENT();
memcpy(bp->parent->mac_addr, resp->mac_address, RTE_ETHER_ADDR_LEN);
bp->parent->vnic = rte_le_to_cpu_16(resp->dflt_vnic_id);
@@ -3259,7 +3259,7 @@ int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp)
/* FIXME: Temporary workaround - remove when firmware issue is fixed. */
if (bp->parent->vnic == 0) {
- PMD_DRV_LOG(ERR, "Error: parent VNIC unavailable.\n");
+ PMD_DRV_LOG(DEBUG, "parent VNIC unavailable.\n");
/* Use hard-coded values appropriate for current Wh+ fw. */
if (bp->parent->fid == 2)
bp->parent->vnic = 0x100;
@@ -4263,7 +4263,7 @@ int bnxt_hwrm_port_led_qcaps(struct bnxt *bp)
req.port_id = bp->pf->port_id;
rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
- HWRM_CHECK_RESULT();
+ HWRM_CHECK_RESULT_SILENT();
if (resp->num_leds > 0 && resp->num_leds < BNXT_MAX_LED) {
unsigned int i;
--
2.10.1
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [dpdk-dev] [PATCH 0/2] bnxt bug fixes
2021-03-10 7:50 [dpdk-dev] [PATCH 0/2] bnxt bug fixes Kalesh A P
2021-03-10 7:50 ` [dpdk-dev] [PATCH 1/2] net/bnxt: fix HWRM and FW incompatibility handling Kalesh A P
2021-03-10 7:50 ` [dpdk-dev] [PATCH 2/2] net/bnxt: mute some failure logs Kalesh A P
@ 2021-03-11 23:58 ` Ajit Khaparde
2 siblings, 0 replies; 11+ messages in thread
From: Ajit Khaparde @ 2021-03-11 23:58 UTC (permalink / raw)
To: Kalesh A P; +Cc: dpdk-dev, Ferruh Yigit
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
On Tue, Mar 9, 2021 at 11:28 PM Kalesh A P
<kalesh-anakkur.purayil@broadcom.com> wrote:
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> This series contain couple of bug fixes in bnxt PMD.
>
> Kalesh AP (2):
> net/bnxt: fix HWRM and FW incompatibility handling
> net/bnxt: mute some failure logs
Patchset applied to dpdk-next-net-brcm.
>
> drivers/net/bnxt/bnxt_hwrm.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> --
> 2.10.1
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH 0/2] bnxt bug fixes
@ 2020-05-22 17:32 Kalesh A P
0 siblings, 0 replies; 11+ messages in thread
From: Kalesh A P @ 2020-05-22 17:32 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, ajit.khaparde
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 576 bytes --]
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
These are two bug fixes observed during regression testing
with DPDK 20.05-rc3.
Please apply.
Kalesh AP (1):
net/bnxt: fix the check for validating link speed
Rahul Gupta (1):
net/bnxt: performance fix for Arm
drivers/net/bnxt/bnxt.h | 1 +
drivers/net/bnxt/bnxt_cpr.h | 6 +++---
drivers/net/bnxt/bnxt_ethdev.c | 2 +-
drivers/net/bnxt/bnxt_hwrm.c | 14 +++++++++-----
drivers/net/bnxt/bnxt_ring.h | 24 +++++++++++++-----------
5 files changed, 27 insertions(+), 20 deletions(-)
--
2.10.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH 0/2] bnxt bug fixes
@ 2020-05-06 6:27 Kalesh A P
2020-05-07 3:22 ` Ajit Khaparde
0 siblings, 1 reply; 11+ messages in thread
From: Kalesh A P @ 2020-05-06 6:27 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, ajit.khaparde
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Please apply.
Kalesh AP (2):
net/bnxt: fix to alloc FW specified TQM ring context memory
net/bnxt: fix TQM ring context memory sizing formulas
drivers/net/bnxt/bnxt.h | 2 +-
drivers/net/bnxt/bnxt_ethdev.c | 21 +++++++++++++--------
drivers/net/bnxt/bnxt_hwrm.c | 31 +++++++++++++++++++------------
3 files changed, 33 insertions(+), 21 deletions(-)
--
2.10.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH 0/2] bnxt bug fixes
2020-05-06 6:27 Kalesh A P
@ 2020-05-07 3:22 ` Ajit Khaparde
0 siblings, 0 replies; 11+ messages in thread
From: Ajit Khaparde @ 2020-05-07 3:22 UTC (permalink / raw)
To: Kalesh A P; +Cc: dpdk-dev, Ferruh Yigit
On Tue, May 5, 2020 at 11:11 PM Kalesh A P <
kalesh-anakkur.purayil@broadcom.com> wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> Please apply.
>
> Kalesh AP (2):
> net/bnxt: fix to alloc FW specified TQM ring context memory
> net/bnxt: fix TQM ring context memory sizing formulas
>
Thanks Kalesh, Patches applied to dpdk-next-net-brcm.
>
> drivers/net/bnxt/bnxt.h | 2 +-
> drivers/net/bnxt/bnxt_ethdev.c | 21 +++++++++++++--------
> drivers/net/bnxt/bnxt_hwrm.c | 31 +++++++++++++++++++------------
> 3 files changed, 33 insertions(+), 21 deletions(-)
>
> --
> 2.10.1
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH 0/2] bnxt bug fixes
@ 2020-04-23 15:02 Kalesh A P
2020-04-23 22:50 ` Ajit Khaparde
0 siblings, 1 reply; 11+ messages in thread
From: Kalesh A P @ 2020-04-23 15:02 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, ajit.khaparde
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Please apply.
Kalesh AP (1):
net/bnxt: fix to reset VNIC rxq count on VNIC free
Rahul Gupta (1):
net/bnxt: fix for memleak during queue restart
drivers/net/bnxt/bnxt_ethdev.c | 2 ++
drivers/net/bnxt/bnxt_hwrm.c | 12 ------------
drivers/net/bnxt/bnxt_rxr.c | 44 ++++++++++++++++++++++++------------------
3 files changed, 27 insertions(+), 31 deletions(-)
--
2.10.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH 0/2] bnxt bug fixes
2020-04-23 15:02 Kalesh A P
@ 2020-04-23 22:50 ` Ajit Khaparde
0 siblings, 0 replies; 11+ messages in thread
From: Ajit Khaparde @ 2020-04-23 22:50 UTC (permalink / raw)
To: Kalesh A P; +Cc: dpdk-dev, Ferruh Yigit
On Thu, Apr 23, 2020 at 7:46 AM Kalesh A P <
kalesh-anakkur.purayil@broadcom.com> wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> Please apply.
>
Applied to dpdk-next-net-brcm. Thanks
>
> Kalesh AP (1):
> net/bnxt: fix to reset VNIC rxq count on VNIC free
>
> Rahul Gupta (1):
> net/bnxt: fix for memleak during queue restart
>
> drivers/net/bnxt/bnxt_ethdev.c | 2 ++
> drivers/net/bnxt/bnxt_hwrm.c | 12 ------------
> drivers/net/bnxt/bnxt_rxr.c | 44
> ++++++++++++++++++++++++------------------
> 3 files changed, 27 insertions(+), 31 deletions(-)
>
> --
> 2.10.1
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH 0/2] bnxt bug fixes
@ 2020-02-20 4:12 Kalesh A P
2020-02-20 6:23 ` Ajit Khaparde
0 siblings, 1 reply; 11+ messages in thread
From: Kalesh A P @ 2020-02-20 4:12 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, ajit.khaparde
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
These are couple of bnxt PMD bug fixes. Please apply.
Kalesh AP (2):
net/bnxt: fix segmentation fault handling async events on port stop
net/bnxt: fix race when port is stopped and async events are received
drivers/net/bnxt/bnxt_cpr.c | 6 ++++++
drivers/net/bnxt/bnxt_hwrm.c | 12 +++++++++---
2 files changed, 15 insertions(+), 3 deletions(-)
--
2.10.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH 0/2] bnxt bug fixes
2020-02-20 4:12 Kalesh A P
@ 2020-02-20 6:23 ` Ajit Khaparde
0 siblings, 0 replies; 11+ messages in thread
From: Ajit Khaparde @ 2020-02-20 6:23 UTC (permalink / raw)
To: Kalesh A P; +Cc: dpdk-dev, Ferruh Yigit
On Wed, Feb 19, 2020 at 7:55 PM Kalesh A P <
kalesh-anakkur.purayil@broadcom.com> wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> These are couple of bnxt PMD bug fixes. Please apply.
>
Patches applied to dpdk-next-net-brcm.
>
> Kalesh AP (2):
> net/bnxt: fix segmentation fault handling async events on port stop
> net/bnxt: fix race when port is stopped and async events are received
>
> drivers/net/bnxt/bnxt_cpr.c | 6 ++++++
> drivers/net/bnxt/bnxt_hwrm.c | 12 +++++++++---
> 2 files changed, 15 insertions(+), 3 deletions(-)
>
> --
> 2.10.1
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-03-11 23:58 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-10 7:50 [dpdk-dev] [PATCH 0/2] bnxt bug fixes Kalesh A P
2021-03-10 7:50 ` [dpdk-dev] [PATCH 1/2] net/bnxt: fix HWRM and FW incompatibility handling Kalesh A P
2021-03-10 7:50 ` [dpdk-dev] [PATCH 2/2] net/bnxt: mute some failure logs Kalesh A P
2021-03-11 23:58 ` [dpdk-dev] [PATCH 0/2] bnxt bug fixes Ajit Khaparde
-- strict thread matches above, loose matches on Subject: below --
2020-05-22 17:32 Kalesh A P
2020-05-06 6:27 Kalesh A P
2020-05-07 3:22 ` Ajit Khaparde
2020-04-23 15:02 Kalesh A P
2020-04-23 22:50 ` Ajit Khaparde
2020-02-20 4:12 Kalesh A P
2020-02-20 6:23 ` Ajit Khaparde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).