From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3FBB6A056A;
	Thu, 11 Mar 2021 18:01:05 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B8A84406A3;
	Thu, 11 Mar 2021 18:01:04 +0100 (CET)
Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com
 [209.85.167.49]) by mails.dpdk.org (Postfix) with ESMTP id DB1E44014D
 for <dev@dpdk.org>; Thu, 11 Mar 2021 18:01:03 +0100 (CET)
Received: by mail-lf1-f49.google.com with SMTP id n16so40964883lfb.4
 for <dev@dpdk.org>; Thu, 11 Mar 2021 09:01:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=jOLHBlchWMbDUbEx0aLQigdMW58c4On1HNdL1Qo2BXk=;
 b=dq6KzweAogexKmIKoP0JkWW0CagDZAPJHOkhVkXTzmhRd65su6mOSxPk0OdeCnKO+v
 oITX0miBOjkJxaYdKdHEHBMAJ9RzuuEtCDYBeUIWrZw3n8jLlbqlaDJ+y80d1QuNi7lC
 Sd92DMwjbtQJNY1p+fNVqTbCOssmHvKBH8uMmR1TT2kwqC4t9qcxCUTCYyp87Dl5wXYf
 eT1qVYofbDMFM0MUNwyCUMS5t7ynuwjbAFc1EY8L6KQdKH89RFoQo2xzYPYmhOv/yrZ4
 d3F7GisSYhHDldfY7MVtafx92EHUivqaZAA6XZDdz2wRbT+2RV7/0jAyi8zeeugSlPPJ
 LdhQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=jOLHBlchWMbDUbEx0aLQigdMW58c4On1HNdL1Qo2BXk=;
 b=kPAEWBL3OBiFNacOoqzfUB8OUVmWMgoZp3JD3JF1vNEXGydvESxeJ0WRAVfx0/LHK9
 OLQpbUEmtHaT3luWF5wdFsNg2NzwVoKrplvV4/Odtcv4KMUY6rA7i/XB3/yawPJVAFXt
 Yl0niXV3Vh73Sx72AKfHsOO31gLt8tzLIb+uczroYB1DGzx67vllDWi5D4pLgEZTnckm
 3QLCyedLRxFwTfRkJoh4I+ctn3mXCOn09efUoSrQIEWoasOYFQu+99MJzdYjaIUaBS0B
 3Vcx16op1DbxJLTtiReAs0NVMeOAlja0MC5kxat6psWHidMx5z4apIB65wj7TeE/Jz4d
 5jjg==
X-Gm-Message-State: AOAM5308d369VA24Ecl81xlKQTH1FeGow1QGvXApwSsRjQVbTe82QfYR
 2VPXlzmn+hKh9RZ8fKpVFN8=
X-Google-Smtp-Source: ABdhPJwtpCbIAGn3o0GLQHAtgNSXFC2+W4Yi7PhkWKK1DJtsblVlRQZUJYFSjBMcBakh9iN9HmaKug==
X-Received: by 2002:a05:6512:20c6:: with SMTP id
 u6mr2777300lfr.493.1615482063198; 
 Thu, 11 Mar 2021 09:01:03 -0800 (PST)
Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru.
 [37.110.65.23])
 by smtp.gmail.com with ESMTPSA id h23sm989127lfm.299.2021.03.11.09.01.02
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 11 Mar 2021 09:01:02 -0800 (PST)
Date: Thu, 11 Mar 2021 20:01:01 +0300
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: John Alexander <John.Alexander@datapath.co.uk>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>,
 Pallavi Kadam <pallavi.kadam@intel.com>, Dmitry Malloy
 <dmitrym@microsoft.com>, Narcisa Ana Maria Vasile
 <navasile@linux.microsoft.com>, Stephen Hemminger
 <stephen@networkplumber.org>, Tyler Retzlaff
 <roretzla@linux.microsoft.com>, Declan Doherty <declan.doherty@intel.com>,
 Fiona Trahe <fiona.trahe@intel.com>, Ashish Gupta
 <ashish.gupta@marvell.com>, Ray Kinsella <mdr@ashroe.eu>, Neil Horman
 <nhorman@tuxdriver.com>
Message-ID: <20210311200101.2031f1e0@sovereign>
In-Reply-To: <AM9PR09MB490036DF57F7D4BE28B449D9B4909@AM9PR09MB4900.eurprd09.prod.outlook.com>
References: <20210303225121.16146-1-dmitry.kozliuk@gmail.com>
 <20210310235421.23259-1-dmitry.kozliuk@gmail.com>
 <AM9PR09MB490036DF57F7D4BE28B449D9B4909@AM9PR09MB4900.eurprd09.prod.outlook.com>
X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] doc: announce API changes for Windows
 compatibility
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2021-03-11 16:19 (UTC+0000), John Alexander:
[...]
> > * `struct rte_param_log2_range`, `struct rte_crypto_param_range`:
> > 
> >     * `min` -> `minimum`
> >     * `max` -> `maximum`  
> 
> 
> The min/max macros in the Windows headers cause issues with C++ projects also (breaks std::min/std::max).  The fix there is to "#define NOMINMAX" prior to including windows.h, maybe that's appropriate here too?

We don't control include order in user code and we shouldn't #undef system
macros in public headers. We could push_macro/pop_macro around structure
definition and have min/max undefined in DPDK internal code, so that including
this header always works. Then, if user wants to access the fields, they
should take care of macros themselves.