From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 321CEA0524; Sat, 20 Mar 2021 12:27:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B8554067A; Sat, 20 Mar 2021 12:27:46 +0100 (CET) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by mails.dpdk.org (Postfix) with ESMTP id 0DB1840395 for ; Sat, 20 Mar 2021 12:27:45 +0100 (CET) Received: by mail-lf1-f43.google.com with SMTP id n138so14008785lfa.3 for ; Sat, 20 Mar 2021 04:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p104YE+3z7v8Ap12Kz5/uNnDrfeU4BjM4a+Ao2bnplg=; b=g3FHEPGfIxb5Pf0Ql2yr+e8NkwqW1WmdPVGQ8VPBSeH7LCn4dxtdYHJPpXlpPKDNZ1 Ki6b01ASL8KWxLy3dMx+5hZIUlgi7X9CFm+g5Uoq1TpXotSMZ2vxAQ4C2BLAmbrJt6Nr sV9NW44+5cBvoIVMPEpc3ZMqHQA3YpJ+phLM33QlZxNSkDrtezHAjELok8nddNWJuPC2 LCALCGosWsAbJhNPc48O/4Y2rjikF7po8TxaA24/YmXP4lMVP0rbVftoLVBpclMS0G/v jaULhO+HbLIFxNsPCgh1qms7xcQJlQcUICTCsJG1RTRR8BP58uMSICJyV5Nshyw+5Kqt Mf+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p104YE+3z7v8Ap12Kz5/uNnDrfeU4BjM4a+Ao2bnplg=; b=iTbGwbCOQVGeRSsEiJ4GmkgO+1fuAjhQfxrQuwQC8HulDcT0dvr6lPKzzeQA+5ZmiU Qflws5umqqGo3lo/Pv+i6pFDd2+65+Kw3MrsEaohVg4aGsh3WWx5dZ0qQq8hIDuyy5lb FeX0pTsy70ZCj9MD6xRu7ELH39lTRrmtYEwPbgEJf5U1PWwJOvJAGClUhSUvpci9Og4J GlTLCCKZFIPrKffAadOxR1xd8cX4HZxULgLvD6bGDGvICS37yNpnbXkv/mRZaOMIj6Al PeiZxeZukK8Cf0zciw5z9Eyzdxk9lMkOytQxoT4D7UpU8Kst4sY7gdUKO7xZ0uhmEVwA Vg9A== X-Gm-Message-State: AOAM533JKT9K8Bkb/Z57A7Spmu/vKcixJ1bCxm0yuMQxJqB2zC8YmvGf iMGZvZRDI2HKRPyM/Hx+wSCYow8xGGMLxg== X-Google-Smtp-Source: ABdhPJyDmGsQa6bzZNJ4HyYhE4LTCKO1vRFDNVyXGBXU8C++9VWsodDuxEbcQdu0Ux9rtQNnNWzhWA== X-Received: by 2002:a19:309:: with SMTP id 9mr3677393lfd.268.1616239664230; Sat, 20 Mar 2021 04:27:44 -0700 (PDT) Received: from localhost.localdomain (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id v26sm913976lfe.276.2021.03.20.04.27.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Mar 2021 04:27:43 -0700 (PDT) From: Dmitry Kozlyuk To: dev@dpdk.org Cc: Tyler Retzlaff , Jie Zhou , Dmitry Kozlyuk Date: Sat, 20 Mar 2021 14:27:28 +0300 Message-Id: <20210320112733.13160-1-dmitry.kozliuk@gmail.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20210306000500.8698-1-dmitry.kozliuk@gmail.com> References: <20210306000500.8698-1-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v5 0/5] eal/windows: do not expose POSIX symbols X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Windows, EAL contains two sets of functions and macros for POSIX compatibility: and a networking shim (socket headers). The latter conflicts with system headers and should not exist. Exposing the former from EAL can break consumer own POSIX compatibility layer and is against standards in general. Hide these symbols from external consumers, while keeping them available for DPDK code. v5: * Unify series with removing Windows networking shim to eliminate dependency between series and CI failures. * RTE_BUILD_INTERNAL -> rte_os_internal.h (Thomas Monjalon). * Remove release notes: hidden symbols were never part of API. v4: * Instead of creating wrappers and replacing POSIX names in lib/ and drivers/, provide POSIX names only to internal consumers. * Move renaming from librte_cmdline to librte_eal. Dmitry Kozlyuk (5): eal: add sleep API eal/windows: hide asprintf() shim eal: make OS shims internal net: provide IP-related API on any OS net: replace Windows networking shim drivers/bus/pci/private.h | 4 +- drivers/bus/vdev/vdev_private.h | 2 + drivers/common/mlx5/mlx5_common.h | 1 + drivers/net/i40e/i40e_ethdev.c | 1 + drivers/net/i40e/i40e_fdir.c | 1 + drivers/net/mlx5/mlx5.h | 2 +- drivers/net/mlx5/mlx5_flow.c | 4 +- drivers/net/mlx5/mlx5_flow.h | 4 +- drivers/net/mlx5/mlx5_mac.c | 1 - examples/cmdline/commands.c | 5 - examples/cmdline/parse_obj_list.c | 2 - lib/librte_cmdline/cmdline.c | 5 - lib/librte_cmdline/cmdline_os_windows.c | 2 - lib/librte_cmdline/cmdline_parse.c | 2 - lib/librte_cmdline/cmdline_parse_etheraddr.c | 6 -- lib/librte_cmdline/cmdline_parse_ipaddr.c | 6 -- lib/librte_cmdline/cmdline_parse_ipaddr.h | 2 +- lib/librte_cmdline/cmdline_private.h | 1 + lib/librte_cmdline/cmdline_socket.c | 4 - lib/librte_eal/common/eal_common_config.c | 1 - lib/librte_eal/common/eal_common_errno.c | 4 + lib/librte_eal/common/eal_common_options.c | 2 +- lib/librte_eal/common/eal_common_timer.c | 5 +- lib/librte_eal/common/eal_internal_cfg.h | 1 + lib/librte_eal/common/eal_private.h | 11 +++ .../freebsd/include/rte_os_internal.h | 14 +++ lib/librte_eal/include/rte_thread.h | 11 +++ .../linux/include/rte_os_internal.h | 14 +++ lib/librte_eal/rte_eal_exports.def | 2 + lib/librte_eal/unix/rte_thread.c | 10 +- lib/librte_eal/version.map | 3 + lib/librte_eal/windows/eal.c | 30 ++++++ lib/librte_eal/windows/eal_hugepages.c | 1 - lib/librte_eal/windows/eal_lcore.c | 1 - lib/librte_eal/windows/eal_memalloc.c | 1 - lib/librte_eal/windows/eal_thread.c | 9 +- lib/librte_eal/windows/include/arpa/inet.h | 30 ------ lib/librte_eal/windows/include/netinet/in.h | 38 -------- lib/librte_eal/windows/include/netinet/ip.h | 10 -- lib/librte_eal/windows/include/rte_os.h | 92 +------------------ .../windows/include/rte_os_internal.h | 36 ++++++++ lib/librte_eal/windows/include/sys/socket.h | 24 ----- lib/librte_ethdev/ethdev_private.h | 2 + lib/librte_ethdev/rte_ethdev.c | 13 +-- lib/librte_ethdev/rte_ethdev_core.h | 1 - lib/librte_kvargs/rte_kvargs.c | 1 + lib/librte_net/rte_ether.h | 26 ++++-- lib/librte_net/rte_ip.h | 7 ++ lib/librte_net/rte_net.c | 1 + 49 files changed, 202 insertions(+), 254 deletions(-) create mode 100644 lib/librte_eal/freebsd/include/rte_os_internal.h create mode 100644 lib/librte_eal/linux/include/rte_os_internal.h delete mode 100644 lib/librte_eal/windows/include/arpa/inet.h delete mode 100644 lib/librte_eal/windows/include/netinet/in.h delete mode 100644 lib/librte_eal/windows/include/netinet/ip.h create mode 100644 lib/librte_eal/windows/include/rte_os_internal.h delete mode 100644 lib/librte_eal/windows/include/sys/socket.h -- 2.29.2