From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0C63A034F; Tue, 23 Mar 2021 03:54:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19C7E140DEB; Tue, 23 Mar 2021 03:54:31 +0100 (CET) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id CFCCE4067E for ; Tue, 23 Mar 2021 03:54:29 +0100 (CET) Received: by mail-pg1-f169.google.com with SMTP id 32so4132016pgm.1 for ; Mon, 22 Mar 2021 19:54:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=juhCyCf8iidDpK4SgFyWXlPvduxuUZDZWQXgsrxjTaE=; b=ihzwW5d0nfyHpf4P5ESFCuVetA1jRohqfcqsLJs5TBFhQImbOfKqdkfyiYdLcW3qLL 3pP0OIoT3gdgzAbMOocNs9sMK9/piT8npUnXvp+0ob6+p2LNX2rneLmK2pbg6R4YyIdt yKt2qkxlGNrjeM2msrlRaRcW2cLakKvK0nuwzCV1HzFfzCCxECyw3fnVW6+VTNalb8C6 7+Ur02amIukFXOTn25AORTmvss8LuEW6I8goFCsTY5kSklEDEZNS13iU8QytPilzx2wW PqomYx2SgbiS1Qab8ggWPiaCjkixd/GXqrlzoZ3PNqye8cRM/nwr4AqjDoiiYCq+3tYK sADQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=juhCyCf8iidDpK4SgFyWXlPvduxuUZDZWQXgsrxjTaE=; b=Ei7dVX++DoFl3OWEYbtNOQbVPCeWfuHcm0t2eeJMD0WbDgqJk+91fyUbWPkP2bj0lg Kzlq0cmgxo6hOfWRxtfBZPI6ehXsYHEJci1vtVwmh7NJ8pp0iH1Jf84Zl35+Y7c5e5+d KeTKH0/16CfJJoVCUy1hOrGUxq6z2exv1pZOkQh9d/wljjsMS/NZFkQVez5/ELB8+GL9 Dtq2XY5fF+8NYYngFPKbTWUZI/J5diVwmBG64ce2/PWrHrVGUSQb81uq5ll7hE68lWb4 v6IZuoGn4XzcezqfPvQGni5/NBANl/ABvWqbcmWHj3xnIaduDL9HQ5lcaaW1VTsYikQG 7AKw== X-Gm-Message-State: AOAM530iXrnnboC5Hcsupzwy4hxwVBSSpx83anlkwuNmDMZlkyeJxafa Ezw6u6zhlLh77eTYASVufAk7bBxj0L1l8w== X-Google-Smtp-Source: ABdhPJxD7Ielle0Cf0KdklWF1N6bvGcWwzzbKjKDEEkkrOEw4TU6oe2rYRrJoIFJM1otRn8wwCbSpQ== X-Received: by 2002:aa7:94ad:0:b029:1ef:2392:4ee8 with SMTP id a13-20020aa794ad0000b02901ef23924ee8mr2702554pfl.75.1616468068428; Mon, 22 Mar 2021 19:54:28 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id u84sm16256607pfc.90.2021.03.22.19.54.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 19:54:28 -0700 (PDT) Date: Mon, 22 Mar 2021 19:54:19 -0700 From: Stephen Hemminger To: dev@dpdk.org Message-ID: <20210322195419.291b5584@hermes.local> In-Reply-To: <1616458835-28502-2-git-send-email-navasile@linux.microsoft.com> References: <1616029240-26588-2-git-send-email-navasile@linux.microsoft.com> <1616458835-28502-1-git-send-email-navasile@linux.microsoft.com> <1616458835-28502-2-git-send-email-navasile@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 01/10] eal: add thread id and simple thread functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 22 Mar 2021 17:20:26 -0700 Narcisa Ana Maria Vasile wrote: > @@ -59,7 +92,7 @@ void rte_thread_get_affinity(rte_cpuset_t *cpusetp); > * > * @return > * On success, zero. > - * On failure, a negative number. > + * On failure, return a positive errno-style error number. > */ The common pattern in DPDK is to return a negative value for errors. There is a tradeoff here, should the wrapper functions just mimic what Posix API's do or not. I prefer what this patch does; so users can just assume the rte_thread functions all work exactly like the pthread versions.