From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Nick Connolly <nick.connolly@mayadata.io>
Cc: Gabriel Ganne <gabriel.ganne@6wind.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Kevin Laatz <kevin.laatz@intel.com>,
dev@dpdk.org, olivier.matz@6wind.com, thierry.herbelot@6wind.com,
"Dmitry Malloy (MESHCHANINOV)" <dmitrym@microsoft.com>,
tal Shnaiderman <talshn@nvidia.com>,
"Menon, Ranjit" <ranjit.menon@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Tyler Retzlaff <roretzla@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/3] meson: use threads dependency as provided by meson
Date: Tue, 23 Mar 2021 01:18:00 +0300 [thread overview]
Message-ID: <20210323011800.2a50fde8@sovereign> (raw)
In-Reply-To: <ef970bc2-ff13-8d78-d564-eaefc24117c7@mayadata.io>
2021-03-22 16:04 (UTC+0000), Nick Connolly:
> > meson guarantees this is portable, so this also allows us to remove a
> > is_windows switch.
> Hi Gabriel,
>
> On Windows, there are at least three different compilation options:
>
> * MinGW-w64 with posix threads
> * MinGW-w64 with win32 threads (different download)
> * Clang without threads support
>
> The Windows EAL library doesn't use a threads package and instead uses
> it's own wrappers around the native Windows system calls. Given that, I
> believe the existing behaviour of not specifying the pthreads package
> for a Windows build is correct and shouldn't be changed.
Hi Nick,
Threads is a dummy dependency for Clang. For MinGW without pthread it still
adds -pthread switch (and it comes to libdpdk.pc), but executable doesn't
require pthread library to run. I can imagine DPDK built by MinGW without
pthread be linked via pkg-config to an app built by MinGW with pthread, then
-pthread switch will be added from libdpdk.pc. Do you think it's an issue?
next prev parent reply other threads:[~2021-03-22 22:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 14:07 Gabriel Ganne
2021-03-22 14:07 ` [dpdk-dev] [PATCH v2 3/3] meson: remove unnecessary explicit link to libpcap Gabriel Ganne
2021-04-09 8:39 ` [dpdk-dev] [PATCH v4] " Gabriel Ganne
2021-04-09 12:25 ` [dpdk-dev] [PATCH v5] build: remove redundant libpcap link Thomas Monjalon
2021-04-14 9:41 ` Thomas Monjalon
2021-04-14 21:02 ` Dmitry Kozlyuk
2021-04-14 21:10 ` Thomas Monjalon
2023-07-16 17:19 ` Stephen Hemminger
2023-07-16 17:21 ` [dpdk-dev] [PATCH v4] meson: remove unnecessary explicit link to libpcap Stephen Hemminger
2021-03-22 16:04 ` [dpdk-dev] [PATCH v2 2/3] meson: use threads dependency as provided by meson Nick Connolly
2021-03-22 22:18 ` Dmitry Kozlyuk [this message]
2021-03-23 13:35 ` Nick Connolly
2021-03-23 21:21 ` Dmitry Kozlyuk
2021-03-23 22:17 ` Nick Connolly
2021-03-24 6:35 ` Gabriel Ganne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323011800.2a50fde8@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitrym@microsoft.com \
--cc=gabriel.ganne@6wind.com \
--cc=kevin.laatz@intel.com \
--cc=nick.connolly@mayadata.io \
--cc=olivier.matz@6wind.com \
--cc=ranjit.menon@intel.com \
--cc=roretzla@microsoft.com \
--cc=talshn@nvidia.com \
--cc=thierry.herbelot@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).