From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 709A2A0579; Tue, 23 Mar 2021 13:12:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3828A4069E; Tue, 23 Mar 2021 13:12:06 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2045.outbound.protection.outlook.com [40.107.94.45]) by mails.dpdk.org (Postfix) with ESMTP id C0B7B40689; Tue, 23 Mar 2021 13:12:04 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kvi896b491qv7ezetu4xd+gRBoK0xI+TGHqgQxv3cjzjQB4ZcoeQvB6e22s8uGZMKiXA5SHaNkiHKcwkt6zJXPE0lcQYXUBZEfOAlDmkYvkpcOyr4gw0hTrwSv9nYwdVVA9PNNqlVDlTNnZhmErtRkni5hu2HHwbXAmUDfVepUb0r3pn47oW9WzKDWCfqGUZ22JS/S1dLQuo4w2LTCM4Q5cAkgHScXqyr2gBF9VUWOEknY8pV+iFGIZYsjnajRX/hOsy8MOUQWiouFSSys4IBqLc6+ImJQQcfsq+cTOGpD2DMk4WbR3MAAwfTQRsIr2VFY484MJ+dgLfW2SFWwWWvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c0euWJtem1UkKMELF73Egb2p2qXhnK6yd0jIs2r5vGk=; b=IE8BwRf85yJ5DDnZQ/U5gC7xkbeiXebHmT3qCfeDyqgdupZue2RVRUdYjGuRdtou57WaxphOzEWVA5ljOyEiaQZCXgUrR10GGHXE1GQRnOwLPMo4jYhacDR54F8Sdc5mKvxBpdGoNYR9QE4FFsS9rp3THVxebKJa7ffALLJR4vJ/87wc+w2orWYIm8gKeUkd7dBEad7BGCqIsN5ifIisfxS9N23xYSYBg78T6PydtOrDK8AT9l8Za1hvEv4PkvYnuFYTbOaHD/X/WUR1IhnzOehlDoIziYPscCs6H7wfOoIhnPUoWAgwI51nF1XTSMQLIgL19YIcGIP/btk0DqQ1bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c0euWJtem1UkKMELF73Egb2p2qXhnK6yd0jIs2r5vGk=; b=rFVNws7/koh4fzRzDYBFkJ6UxObgMfiPTK9mHE5Fs/QlEB0wwo2cYQJt1XWS01x6vTT9P0YWwv4ETKCAXFLctrEl2qfA1T/9bq5YH5M3/+Uh16fSVZCsfM0hEH30udirq1ByiU07lKr4kHCSINnHI/A2HORGxQyb87fkATptlgmQSLXNTfT90gGkOxSSAyyoaIhZ4G7JZw2E10dhm64tWZpZbW6S7uEX1RgjyHZ5UN3bKEBHmtOx4D6ffOnVLW9em0ojedq3sRhsqUu/jYrIfe0TBhngm/xBYdr5GodfPkc8D+c2usoc8gvcbQANmW+D1Gmym9Tabo/bfsaM97vqBw== Received: from BN8PR03CA0036.namprd03.prod.outlook.com (2603:10b6:408:94::49) by DM5PR12MB1644.namprd12.prod.outlook.com (2603:10b6:4:f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.24; Tue, 23 Mar 2021 12:11:48 +0000 Received: from BN8NAM11FT054.eop-nam11.prod.protection.outlook.com (2603:10b6:408:94:cafe::a7) by BN8PR03CA0036.outlook.office365.com (2603:10b6:408:94::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.18 via Frontend Transport; Tue, 23 Mar 2021 12:11:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT054.mail.protection.outlook.com (10.13.177.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.3955.18 via Frontend Transport; Tue, 23 Mar 2021 12:11:48 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 23 Mar 2021 12:11:46 +0000 From: Raslan Darawsheh To: CC: , , , Date: Tue, 23 Mar 2021 14:11:34 +0200 Message-ID: <20210323121134.19113-1-rasland@nvidia.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a9ff598e-5ee2-4bb1-148c-08d8edf4d5ca X-MS-TrafficTypeDiagnostic: DM5PR12MB1644: X-Microsoft-Antispam-PRVS: X-MS-Exchange-Transport-Forked: True X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZLEjtkXVQe5FOZ551N6TJYGbmLCcl1bDjBOLmzq5lMMFGBYghO70RUSwC661WfJ7siDzvPYX69K9o6xcM5wEfOAKDfm2j0aNxGYvzn90dSHCdsbD2AFfok43yqU+yLd6wtND+LmbSaxsddSSckpaieNwXdGo+AtbC3bmw4UjRkSuifp2YTvQqC/bANaUm9/AlOXdMTrOIl2JFDa9WcpGHx5kwMJShb81JvYpy18enAlTrwh4LqgXI02jTLVMB09BTGvTiDuRXvyHQaY5MnziY+Yg9rSnw6XcUnJcrjVlxVQhNGYBmYbA/IkzSTiCxy90dw3Tb65eYukU3Kl9af5uq96mBd5UFnIxMAV8gR3pISddn8Lu34fnm29SsJZar4ghUJtO/3OI24hs7s/2hyuPJrRqwIaQLxA2Ad9eBCKX3/vDBUxGBUrK02rTglFCxIowrD2pm9i/9wHHITo2yRqtLDG7hrmCoqxi5P7MnpxjnYLWPzk1C1AGZorv1Y8IfohoRS5uhh6FHSlBl7Wo7gJ38UXfr3EwMVMfYdN7UgEXIwxGjhD3BVJaKIvRuT+sO9+8YHMrjYV5KLdnvRDmGoPMU0Nc7skzOcleMAnXL/KZyhHE0vhjJisRxT6L65al7J6fChwCwD7vt4MoUX2cVNQf5c4U9rPlfRD35YOXf5Td57Y= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(376002)(39860400002)(136003)(346002)(36840700001)(46966006)(6666004)(83380400001)(36756003)(4326008)(70206006)(55016002)(36860700001)(5660300002)(186003)(6916009)(82310400003)(70586007)(1076003)(6286002)(356005)(82740400003)(7636003)(7696005)(86362001)(15650500001)(47076005)(8936002)(336012)(2616005)(426003)(2906002)(478600001)(26005)(36906005)(54906003)(16526019)(316002)(8676002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2021 12:11:48.5340 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a9ff598e-5ee2-4bb1-148c-08d8edf4d5ca X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT054.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1644 Subject: [dpdk-dev] [PATCH] ethdev: update qfi definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" qfi field is 8 bits which represent single bit for PPP (paging Policy Presence) single bit for RQI (Reflective QoS Indicator) and 6 bits for qfi (QoS Flow Identifier) This update the doxygen format and the mask for qfi to properly identify the full 8 bits of the field. note: changing the default mask would cause different patterns generated by testpmd. Fixes: 346553db5bd1 ("ethdev: add GTP extension header to flow API") Cc: ying.a.wang@intel.com Cc: stable@dpdk.org Signed-off-by: Raslan Darawsheh --- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 ++- lib/librte_ethdev/rte_flow.h | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index f59eb8a27d..dd39c4c3c2 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -3742,7 +3742,8 @@ This section lists supported pattern items and their attributes, if any. - ``gtp_psc``: match GTP PDU extension header with type 0x85. - ``pdu_type {unsigned}``: PDU type. - - ``qfi {unsigned}``: QoS flow identifier. + + - ``qfi {unsigned}``: PPP, RQI and QoS flow identifier. - ``pppoes``, ``pppoed``: match PPPoE header. diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h index 669e677e91..79106e0246 100644 --- a/lib/librte_ethdev/rte_flow.h +++ b/lib/librte_ethdev/rte_flow.h @@ -1392,14 +1392,14 @@ static const struct rte_flow_item_meta rte_flow_item_meta_mask = { */ struct rte_flow_item_gtp_psc { uint8_t pdu_type; /**< PDU type. */ - uint8_t qfi; /**< QoS flow identifier. */ + uint8_t qfi; /**< PPP, RQI, QoS flow identifier. */ }; /** Default mask for RTE_FLOW_ITEM_TYPE_GTP_PSC. */ #ifndef __cplusplus static const struct rte_flow_item_gtp_psc rte_flow_item_gtp_psc_mask = { - .qfi = 0x3f, + .qfi = 0xff, }; #endif -- 2.17.1