* [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
@ 2021-02-21 0:55 Dmitry Kozlyuk
2021-03-23 16:11 ` Ferruh Yigit
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Kozlyuk @ 2021-02-21 0:55 UTC (permalink / raw)
To: dev
Cc: Narcisa Ana Maria Vasile, Dmitry Malloy, Pallavi Kadam,
Dmitry Kozlyuk, Yong Wang
Remove OS restriction and update release notes.
Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
DPDK-kmods patch: http://patchwork.dpdk.org/patch/88046/
doc/guides/rel_notes/release_21_05.rst | 2 ++
drivers/net/vmxnet3/meson.build | 6 ------
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst
index 5aa9ed7db..574f9dcf6 100644
--- a/doc/guides/rel_notes/release_21_05.rst
+++ b/doc/guides/rel_notes/release_21_05.rst
@@ -55,6 +55,8 @@ New Features
Also, make sure to start the actual text at the margin.
=======================================================
+* **Enabled vmxnet3 PMD on Windows.**
+
Removed Items
-------------
diff --git a/drivers/net/vmxnet3/meson.build b/drivers/net/vmxnet3/meson.build
index 124238666..0641f776f 100644
--- a/drivers/net/vmxnet3/meson.build
+++ b/drivers/net/vmxnet3/meson.build
@@ -1,12 +1,6 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2018 Luca Boccassi <bluca@debian.org>
-if is_windows
- build = false
- reason = 'not supported on Windows'
- subdir_done()
-endif
-
sources += files(
'vmxnet3_ethdev.c',
'vmxnet3_rxtx.c',
--
2.29.2
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
2021-02-21 0:55 [dpdk-dev] [PATCH] net/vmxnet3: build on Windows Dmitry Kozlyuk
@ 2021-03-23 16:11 ` Ferruh Yigit
2021-03-23 17:13 ` Yong Wang
0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2021-03-23 16:11 UTC (permalink / raw)
To: Dmitry Kozlyuk, dev, Yong Wang
Cc: Narcisa Ana Maria Vasile, Dmitry Malloy, Pallavi Kadam
On 2/21/2021 12:55 AM, Dmitry Kozlyuk wrote:
> Remove OS restriction and update release notes.
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Build looks good, but I wonder if anyone tested the driver on Windows.
Yong,
Do you have any plan to test the driver on Windows, should we wait your ack?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
2021-03-23 16:11 ` Ferruh Yigit
@ 2021-03-23 17:13 ` Yong Wang
2021-03-24 17:50 ` Dmitry Kozlyuk
0 siblings, 1 reply; 6+ messages in thread
From: Yong Wang @ 2021-03-23 17:13 UTC (permalink / raw)
To: Ferruh Yigit, Dmitry Kozlyuk, dev
Cc: Narcisa Ana Maria Vasile, Dmitry Malloy, Pallavi Kadam
-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@intel.com>
Date: Tuesday, March 23, 2021 at 9:11 AM
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>, Yong Wang <yongwang@vmware.com>
Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
On 2/21/2021 12:55 AM, Dmitry Kozlyuk wrote:
> Remove OS restriction and update release notes.
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Build looks good, but I wonder if anyone tested the driver on Windows.
Yong,
Do you have any plan to test the driver on Windows, should we wait your ack?
Ferruh,
Unfortunately I don't have any Windows setup to test this change. Do you know what kind of tests have been done for this change?
Yong
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
2021-03-23 17:13 ` Yong Wang
@ 2021-03-24 17:50 ` Dmitry Kozlyuk
2021-03-24 18:32 ` Yong Wang
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Kozlyuk @ 2021-03-24 17:50 UTC (permalink / raw)
To: Yong Wang
Cc: Ferruh Yigit, dev, Narcisa Ana Maria Vasile, Dmitry Malloy,
Pallavi Kadam
2021-03-23 17:13 (UTC+0000), Yong Wang:
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Date: Tuesday, March 23, 2021 at 9:11 AM
> To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>, Yong Wang <yongwang@vmware.com>
> Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
>
> On 2/21/2021 12:55 AM, Dmitry Kozlyuk wrote:
> > Remove OS restriction and update release notes.
> >
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>
> Build looks good, but I wonder if anyone tested the driver on Windows.
>
> Yong,
>
> Do you have any plan to test the driver on Windows, should we wait your ack?
>
> Ferruh,
>
> Unfortunately I don't have any Windows setup to test this change. Do you know what kind of tests have been done for this change?
For the record, I tested the following setup with Windows Server 2019 in QEMU
(-device vmxnet3) before submitting the patch:
[ping ] [ ] [ ping]
[OS ] [ dpdk-skeleton ] [ OS]
[virtio---]--sockets--[---vmxnet3 vmxnet3---]--sockets--[---virtio]
[Debian VM] [ Windows VM ] [Debian VM]
Debian VMs successfully ping'd each other with Windows forwarding.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
2021-03-24 17:50 ` Dmitry Kozlyuk
@ 2021-03-24 18:32 ` Yong Wang
2021-03-25 16:04 ` Ferruh Yigit
0 siblings, 1 reply; 6+ messages in thread
From: Yong Wang @ 2021-03-24 18:32 UTC (permalink / raw)
To: Dmitry Kozlyuk
Cc: Ferruh Yigit, dev, Narcisa Ana Maria Vasile, Dmitry Malloy,
Pallavi Kadam
-----Original Message-----
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Date: Wednesday, March 24, 2021 at 10:50 AM
To: Yong Wang <yongwang@vmware.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
2021-03-23 17:13 (UTC+0000), Yong Wang:
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Date: Tuesday, March 23, 2021 at 9:11 AM
> To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>, Yong Wang <yongwang@vmware.com>
> Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
>
> On 2/21/2021 12:55 AM, Dmitry Kozlyuk wrote:
> > Remove OS restriction and update release notes.
> >
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>
> Build looks good, but I wonder if anyone tested the driver on Windows.
>
> Yong,
>
> Do you have any plan to test the driver on Windows, should we wait your ack?
>
> Ferruh,
>
> Unfortunately I don't have any Windows setup to test this change. Do you know what kind of tests have been done for this change?
For the record, I tested the following setup with Windows Server 2019 in QEMU
(-device vmxnet3) before submitting the patch:
[ping ] [ ] [ ping]
[OS ] [ dpdk-skeleton ] [ OS]
[virtio---]--sockets--[---vmxnet3 vmxnet3---]--sockets--[---virtio]
[Debian VM] [ Windows VM ] [Debian VM]
Debian VMs successfully ping'd each other with Windows forwarding.
Thanks Dmitri for the testing results. It will be good if you can try some basic tcp/udp traffic as well.
Acked-by: Yong Wang <yongwang@vmware.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
2021-03-24 18:32 ` Yong Wang
@ 2021-03-25 16:04 ` Ferruh Yigit
0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2021-03-25 16:04 UTC (permalink / raw)
To: Yong Wang, Dmitry Kozlyuk
Cc: dev, Narcisa Ana Maria Vasile, Dmitry Malloy, Pallavi Kadam
On 3/24/2021 6:32 PM, Yong Wang wrote:
>
> -----Original Message-----
> From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Date: Wednesday, March 24, 2021 at 10:50 AM
> To: Yong Wang <yongwang@vmware.com>
> Cc: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
>
> 2021-03-23 17:13 (UTC+0000), Yong Wang:
> > -----Original Message-----
> > From: Ferruh Yigit <ferruh.yigit@intel.com>
> > Date: Tuesday, March 23, 2021 at 9:11 AM
> > To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>, Yong Wang <yongwang@vmware.com>
> > Cc: Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>, Dmitry Malloy <dmitrym@microsoft.com>, Pallavi Kadam <pallavi.kadam@intel.com>
> > Subject: Re: [dpdk-dev] [PATCH] net/vmxnet3: build on Windows
> >
> > On 2/21/2021 12:55 AM, Dmitry Kozlyuk wrote:
> > > Remove OS restriction and update release notes.
> > >
> > > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> >
> > Build looks good, but I wonder if anyone tested the driver on Windows.
> >
> > Yong,
> >
> > Do you have any plan to test the driver on Windows, should we wait your ack?
> >
> > Ferruh,
> >
> > Unfortunately I don't have any Windows setup to test this change. Do you know what kind of tests have been done for this change?
>
> For the record, I tested the following setup with Windows Server 2019 in QEMU
> (-device vmxnet3) before submitting the patch:
>
> [ping ] [ ] [ ping]
> [OS ] [ dpdk-skeleton ] [ OS]
> [virtio---]--sockets--[---vmxnet3 vmxnet3---]--sockets--[---virtio]
> [Debian VM] [ Windows VM ] [Debian VM]
>
> Debian VMs successfully ping'd each other with Windows forwarding.
>
> Thanks Dmitri for the testing results. It will be good if you can try some basic tcp/udp traffic as well.
>
> Acked-by: Yong Wang <yongwang@vmware.com>
>
Applied to dpdk-next-net/main, thanks.
Added the above test detail to commit log for record.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-25 16:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-21 0:55 [dpdk-dev] [PATCH] net/vmxnet3: build on Windows Dmitry Kozlyuk
2021-03-23 16:11 ` Ferruh Yigit
2021-03-23 17:13 ` Yong Wang
2021-03-24 17:50 ` Dmitry Kozlyuk
2021-03-24 18:32 ` Yong Wang
2021-03-25 16:04 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).