From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0121A0A02; Thu, 25 Mar 2021 09:55:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D414A140D73; Thu, 25 Mar 2021 09:55:17 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id C10C5140D36 for ; Thu, 25 Mar 2021 09:55:15 +0100 (CET) IronPort-SDR: FjHQmeqso73YwQmdCSjh0RZUOFGHP6h0f24SH7ETK+JvLS2LxVwD/v85GErtV+BTVukLAuAkSn 42oMt3c4cPOg== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="190978005" X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="190978005" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 01:55:13 -0700 IronPort-SDR: 7CCDYJW/dgGG5FuSkv6uCRZNTNzCmZCP6ri6+d1cwIgdKX4YeSGBLkuJpNNmnPz9bcZ4CZfm6E ClEMolCQj/3A== X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="452980784" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.15.70]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 25 Mar 2021 01:55:12 -0700 Date: Thu, 25 Mar 2021 08:55:09 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20210325085509.GA1589@bricha3-MOBL.ger.corp.intel.com> References: <20210310172430.412405-1-bruce.richardson@intel.com> <5444524.CHRtvvORdv@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5444524.CHRtvvORdv@thomas> Subject: Re: [dpdk-dev] [PATCH 0/4] telemetry logging improvements and cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 24, 2021 at 10:11:55PM +0100, Thomas Monjalon wrote: > 10/03/2021 18:24, Bruce Richardson: > > This set adds support for using the regular rte_log functions from the telemetry > > library; avoiding circular dependencies by having EAL register the telemetry > > library itself and then passing the required handles to that library as part of > > the telemetry_init call. > > > > Beyond this change, the other three patches are cleanups to ensure that all > > internal functions are clearly separate from the public APIs. (Patches 3 & 4 may > > be merged into a single one on apply, for I've kept them separate for now for > > clarity). > > > > Bruce Richardson (4): > > telemetry: use rte_log for logging > > telemetry: make the legacy registration function internal > > telemetry: create internal-only header file > > telemetry: move init function to internal header > > Now that your patch "eal: fix querying DPDK version at runtime" > is in main branch, please could you rebase this series? > Sure, will do.