From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9C7CFA0A02;
	Thu, 25 Mar 2021 15:17:08 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id AD17B140D88;
	Thu, 25 Mar 2021 15:17:06 +0100 (CET)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by mails.dpdk.org (Postfix) with ESMTP id AD84E40147
 for <dev@dpdk.org>; Thu, 25 Mar 2021 15:17:01 +0100 (CET)
IronPort-SDR: Ts5pKFnoskPecdaXt5LteJBRK9bLq5ggeNMzgV57p+Uc5/k8N2O1DcyhOt8GOkj8HvOwt38JcI
 jHALf40Hh0uw==
X-IronPort-AV: E=McAfee;i="6000,8403,9934"; a="190967046"
X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="190967046"
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 25 Mar 2021 07:16:56 -0700
IronPort-SDR: 0poSN8NpJd64IXNBt2H7A0sgD6/Bw9vdJFtemCg+jpJQJmTnthC954+Cp214OWX7NGfrAOT6Ed
 dpkBXVd5zRZQ==
X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="442792671"
Received: from bricha3-mobl.ger.corp.intel.com ([10.252.15.70])
 by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;
 25 Mar 2021 07:16:53 -0700
Date: Thu, 25 Mar 2021 14:16:49 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,
 Ciara Power <ciara.power@intel.com>, Kevin Laatz <kevin.laatz@intel.com>
Message-ID: <20210325141649.GB1589@bricha3-MOBL.ger.corp.intel.com>
References: <20210310172430.412405-1-bruce.richardson@intel.com>
 <20210325135707.325536-1-bruce.richardson@intel.com>
 <20210325135707.325536-2-bruce.richardson@intel.com>
 <CAJFAV8yZ1cy1fZ2ZpznTQ0evVGg_RQDuXqsEVNdR2Sakb=cy_w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJFAV8yZ1cy1fZ2ZpznTQ0evVGg_RQDuXqsEVNdR2Sakb=cy_w@mail.gmail.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/4] telemetry: use rte_log for logging
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Mar 25, 2021 at 03:09:32PM +0100, David Marchand wrote:
> On Thu, Mar 25, 2021 at 2:57 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > Rather than passing back an error string to the caller, take as input the
> > rte_log function to use, and just use regular logging.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > Acked-by: Ciara Power <ciara.power@intel.com>
> 
> I guess this replaces
> http://patchwork.dpdk.org/project/dpdk/patch/20210308222339.819494-1-thomas@monjalon.net/
> ?
Yes, it would do.