From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95012A034F; Mon, 29 Mar 2021 09:29:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8277340151; Mon, 29 Mar 2021 09:29:13 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 0DCBC40042 for <dev@dpdk.org>; Mon, 29 Mar 2021 09:29:12 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 8A3AF5C00C8; Mon, 29 Mar 2021 03:29:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 29 Mar 2021 03:29:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm3; bh=kTsVIJCUmlncr jDvmkGp4stdoTb2/v3cbGBJ3CJCpoE=; b=0EbyclB++huviRwhwulekGj+g03Z/ xlRAW1SpLy0uZ9hnNB3QRoLzuibJt1pRqe3mxSyxADIvJAAtsruSTlvjtjZV9vcT KZd1XO3Ipe9RgNsh90Pn8A/AONqOI3Ea8vh4Sy1nFZCvoY4p9kRxBTFvj71zRlB2 o3KryRA4s0QhcU++xWdrp5KkUDur5Y4V7vzMuQmLipGH+rvso2XcVrKMoKyAN4HF pU/5BVvbFYITs4ORUYNy2I3r4gfBggSb6BOtoKdYAFrURMc3scTh0Xt37ycYIMVR cdMuX73AL4Y9oVGHKhlPYiSLSh+mGDPgA34nDqhNuIxVkIN+ZuioQfUFA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=kTsVIJCUmlncrjDvmkGp4stdoTb2/v3cbGBJ3CJCpoE=; b=FH8h96Hx XQK/vLjB85ANq+vIZzzO+rqSO+/BMhTi2cOKoH3X02TEy6TFIy/RIMVweMmaRrwa RavFF/TXegsoWzCyaqDC4DhFWFbO1JX/OiRBJ7jUs7VaPeh/LU861NlNMY1dTYAe wz7rw8IXcNfIloA4f1kATvgl0sGBgl7IJftPi1jwpL3lhZL1/UqgqCV6DKDtQ74/ jxf5/nGiRScE4GKlYwY7VWUdheJM0KoQhM7149JBOlOQHQ67/0UEodAugmwvz1l3 VQm+C0yTJb5Y1OBvXw5w1kbA5ahR7vi5Y8tqSTmx2A9LLRvRM1sVOegRh938rRki 1squdkEAJhvqIA== X-ME-Sender: <xms:xoFhYHSA00NHzTb8eoo5W4QyS90lRba1Rlf8mUSpZgZJDMaDOMC9cQ> <xme:xoFhYCac-sTK6oE9J1KCslcwYGcQbT2iH_vbgMnOl1rsocYuQdnWwXfkW44IZtsYT Uy49Kxywh380sScyw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehjedguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedvhefgiedvjeegtdevheefhfetleefgfeivefgffevfeejgedt gfeutdehtdegveenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: <xmx:xoFhYM2X2J-8Iw9D9DKZ5xZw_ipESiv9m84VXts_2ofPbvBT6jIO_Q> <xmx:xoFhYKXYFJMhmWCxc_qUI2dEldwFTDKRWgLr5EnR2FWmftbICoX-sg> <xmx:xoFhYOX_ahGyDdrxrliRsiqewWa39gdvtuzkKAoOPBj-Uv_sKvFXVA> <xmx:x4FhYBGgdqPLrqxB_ZdvSz46jS8K4il96VbyQSwYBOBXszWro_kdog> Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 198E024005D; Mon, 29 Mar 2021 03:29:09 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: dev@dpdk.org Cc: lihuisong@huawei.com, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru, ajit.khaparde@broadcom.com, jerinj@marvell.com, Somnath Kotur <somnath.kotur@broadcom.com>, Matan Azrad <matan@nvidia.com>, Shahaf Shuler <shahafs@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com> Date: Mon, 29 Mar 2021 09:28:53 +0200 Message-Id: <20210329072854.450188-1-thomas@monjalon.net> X-Mailer: git-send-email 2.30.1 In-Reply-To: <2a9f3c44-44da-854b-8b25-772a3570baa4@huawei.com> References: <2a9f3c44-44da-854b-8b25-772a3570baa4@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] drivers/net: remove useless autoneg capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> The flag ETH_LINK_SPEED_AUTONEG is 0, so it cannot be used in a capability bitmap. Having 0 in speed capability means all speeds are accepted. Signed-off-by: Thomas Monjalon <thomas@monjalon.net> --- drivers/net/bnxt/bnxt_ethdev.c | 2 -- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 4 ---- 2 files changed, 6 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index f1dd40591f..a2debdbb64 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -889,8 +889,6 @@ uint32_t bnxt_get_speed_capabilities(struct bnxt *bp) if (bp->link_info->auto_mode == HWRM_PORT_PHY_QCFG_OUTPUT_AUTO_MODE_NONE) speed_capa |= ETH_LINK_SPEED_FIXED; - else - speed_capa |= ETH_LINK_SPEED_AUTONEG; return speed_capa; } diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c index 0e8de9439e..58d56913ae 100644 --- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c +++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c @@ -409,8 +409,6 @@ mlx5_link_update_unlocked_gset(struct rte_eth_dev *dev, else dev_link.link_speed = link_speed; priv->link_speed_capa = 0; - if (edata.supported & SUPPORTED_Autoneg) - priv->link_speed_capa |= ETH_LINK_SPEED_AUTONEG; if (edata.supported & (SUPPORTED_1000baseT_Full | SUPPORTED_1000baseKX_Full)) priv->link_speed_capa |= ETH_LINK_SPEED_1G; @@ -517,8 +515,6 @@ mlx5_link_update_unlocked_gs(struct rte_eth_dev *dev, sc = ecmd->link_mode_masks[0] | ((uint64_t)ecmd->link_mode_masks[1] << 32); priv->link_speed_capa = 0; - if (sc & MLX5_BITSHIFT(ETHTOOL_LINK_MODE_Autoneg_BIT)) - priv->link_speed_capa |= ETH_LINK_SPEED_AUTONEG; if (sc & (MLX5_BITSHIFT(ETHTOOL_LINK_MODE_1000baseT_Full_BIT) | MLX5_BITSHIFT(ETHTOOL_LINK_MODE_1000baseKX_Full_BIT))) priv->link_speed_capa |= ETH_LINK_SPEED_1G; -- 2.30.1