From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20F04A0548; Thu, 1 Apr 2021 16:02:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A4218141260; Thu, 1 Apr 2021 16:02:00 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id B84D91411AA for ; Thu, 1 Apr 2021 16:01:58 +0200 (CEST) IronPort-SDR: pncD+o0G23kXYcAtYwSGj+JZt/F1lGap7slJ5se7IMW51M1E8eU60CYB98YBFyWAoUfxMyI7Yq 0L97tbG2vr0Q== X-IronPort-AV: E=McAfee;i="6000,8403,9941"; a="192352092" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="192352092" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 07:01:56 -0700 IronPort-SDR: 83dhYByWjgH8tUwmAdpmf/w00oiJBWEz3/q7iOBDwAWCQiyiUHzrqPadOv2iM2TqMijRrDuLx3 gERM7jFNuPpQ== X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="377711954" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.1.228]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 01 Apr 2021 07:01:55 -0700 Date: Thu, 1 Apr 2021 15:01:50 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com, bluca@debian.org Message-ID: <20210401140150.GC1627@bricha3-MOBL.ger.corp.intel.com> References: <20210401115009.1063844-1-bruce.richardson@intel.com> <20210401115009.1063844-4-bruce.richardson@intel.com> <7625994.vKDu1qXSfk@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7625994.vKDu1qXSfk@thomas> Subject: Re: [dpdk-dev] [RFC PATCH 03/14] build: correct indentation in list of libs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 01, 2021 at 03:30:24PM +0200, Thomas Monjalon wrote: > 01/04/2021 13:49, Bruce Richardson: > > With the lib/meson.build file changed from C-style indentation to > > python-style indentation, we need to correct the indentation of the lists > > of libraries, since these libs were not modified in the previous patches. > > > > Signed-off-by: Bruce Richardson > > --- > > + 'kvargs', # eal depends on kvargs > > + 'telemetry', # basic info querying > > + 'eal', # everything depends on eal > > + 'ring', > > + 'rcu', # rcu depends on ring > > + 'mempool', 'mbuf', 'net', 'meter', 'ethdev', 'pci', # core > > + 'cmdline', > > + 'metrics', # bitrate/latency stats depends on this > > + 'hash', # efd depends on this > > + 'timer', # eventdev depends on this > > + 'acl', 'bbdev', 'bitratestats', 'cfgfile', > > + 'compressdev', 'cryptodev', > > + 'distributor', 'efd', 'eventdev', > > + 'gro', 'gso', 'ip_frag', 'jobstats', > > + 'kni', 'latencystats', 'lpm', 'member', > > + 'power', 'pdump', 'rawdev', 'regexdev', > > + 'rib', 'reorder', 'sched', 'security', 'stack', 'vhost', > > + # ipsec lib depends on net, crypto and security > > + 'ipsec', > > + #fib lib depends on rib > > space missing > > > + 'fib', > > + # add pkt framework libs which use other libs from above > > + 'port', 'table', 'pipeline', > > + # flow_classify lib depends on pkt framework table lib > > + 'flow_classify', 'bpf', 'graph', 'node'] > > Some may deserve to be on their own line. > Maybe put them all on their own line, or would just just be too long a list?