From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DCCAAA0548;
	Fri,  2 Apr 2021 19:45:13 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B0CD0141149;
	Fri,  2 Apr 2021 19:45:13 +0200 (CEST)
Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com
 [209.85.215.179])
 by mails.dpdk.org (Postfix) with ESMTP id 11119141143
 for <dev@dpdk.org>; Fri,  2 Apr 2021 19:45:12 +0200 (CEST)
Received: by mail-pg1-f179.google.com with SMTP id k8so3974388pgf.4
 for <dev@dpdk.org>; Fri, 02 Apr 2021 10:45:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=Ky6KiRSpxMBgjMySvOmJIFZ1iUBOpVbAthH3cJMvRmE=;
 b=UW3hOVI1DKAJMtHi9iQRGXd/vnH/ZgRQwf89FkPs05j74bClNQcrkjDSL0q+wwTsMa
 kQR/sKWFDdxisMxagcpuWgYjyhdW6Q+zu9VNZ9nOLEy8GZhuo7zsUZSgjR45xCcGzvqA
 HdwqDSqTt5XPNfrgR7rFb2LDQsrg/v6b5hiPgG6+GGpATiRlRpX9+OZk733mOQLl5l6m
 8I+z7wSMka/tQCWAWI7kr1Ss1eQy0lHnQoM46JaKkbxOewV4OPvDttGLM9aBNKkAXyJW
 Dwgw5VhRYjB4u23w13Pl01/eiBB1t8PypKzDbkUPIx3nK7KVHf7WHfKHzYjpvjhu6OrN
 ZM/Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=Ky6KiRSpxMBgjMySvOmJIFZ1iUBOpVbAthH3cJMvRmE=;
 b=USCsSPx4X7zglAC/x8UBGCD+S31N4iYy4MRfY/iDo1n4xzO7xcLuwR4cS8rSfDQ7rw
 XW6JqyVFEcT3v5zj93OVVlAmNwL6lj1E1ufQEtwHvbyY/l/jcA2Pu3U8apRgOTf/2NwS
 r3+NmOejLsxqfI1wLfSj5J1f68lO8/jufpVW5O5aK953lpBNUzkRpu6QURlCCXJesmKf
 0185mUAv/a7Xh8gbPtpDhzbbFckNsT2xZwceh0D79BbG9xRqyy5+6DerBkF4ajdAwzee
 MoXGxFDGVQbaI0wZTHMj9TKhGNbHzEhaWLJbxL/QfjBdU7jIbh1qX6eDgDpLkjrRp7nR
 ZhvQ==
X-Gm-Message-State: AOAM531HQUZ55gs9xOkMOFy6IM7tUT+JITbUmeeCUMSFLpQzeoWykuyF
 1OWFw05g/cbH+mT2Tyf9B2XmyUzPbUYo7g==
X-Google-Smtp-Source: ABdhPJyiBfk5Zqlo6PQSK5RqJLyRbGwlCKkUqJEUOeb6mukTA/GX3gJVVFOpFTPtmq3T4pz45tmuhA==
X-Received: by 2002:a62:d15e:0:b029:218:4f9:d8ee with SMTP id
 t30-20020a62d15e0000b029021804f9d8eemr13036772pfl.28.1617385512205; 
 Fri, 02 Apr 2021 10:45:12 -0700 (PDT)
Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44])
 by smtp.gmail.com with ESMTPSA id e6sm2160781pgm.92.2021.04.02.10.45.11
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 02 Apr 2021 10:45:11 -0700 (PDT)
Date: Fri, 2 Apr 2021 10:45:04 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org
Message-ID: <20210402104504.166aa8da@hermes.local>
In-Reply-To: <20210401150517.234085-1-anatoly.burakov@intel.com>
References: <20210401150517.234085-1-anatoly.burakov@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 21.08] power: refactor pstate sysfs handling
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu,  1 Apr 2021 15:05:17 +0000
Anatoly Burakov <anatoly.burakov@intel.com> wrote:

>  
> +#define FOPEN_OR_ERR_GOTO(f, label) do { \
> +		if ((f) == NULL) { \
> +			RTE_LOG(ERR, POWER, "File not opened\n"); \
> +			goto label; \
> +		} \
> +} while (0)
> +

I am not a fan of macros like this that have gotos.
It is clearer to just open code it.