From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F0D3A0548; Sun, 4 Apr 2021 02:00:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BBD61140EA4; Sun, 4 Apr 2021 02:00:07 +0200 (CEST) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by mails.dpdk.org (Postfix) with ESMTP id A62824068C; Sun, 4 Apr 2021 02:00:05 +0200 (CEST) Received: by mail-lj1-f182.google.com with SMTP id f16so9187560ljm.1; Sat, 03 Apr 2021 17:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ptPIYMkguBvGZK32MYTmX/BlsOgU3lUh2RbmnTmL7Hw=; b=h+BBw50w7U/9v17cdxLlPvl1rAf0EDKqWThw+BGOYbIXuJTTU9unHqa/Hm3AWV21D0 fRgIv2t5XseEjfy72iN4JRlEnk+ljt5gE7pFmzHclnIBXz0/+TLFE/J2El8GRWiGG6hY eRs4M4Oe65z+uk7kDKYKtx85OUK2V0h3XG0EFq4l8NIt8MTdnmd/vzEwR1xfhuSXx3+k JhrOMsoCTcwwL/Bsm24MknvVUwD+5lRTA+usfjle4vhMdy8oAKD/S+QUM93gHBtb7alp QqeRkc7k2qEGXcDPzR+mDDK8MnyJH/DZj7mT4Va6OC1mrwRF7DR4INZbHzejrJwxZAzI iGYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ptPIYMkguBvGZK32MYTmX/BlsOgU3lUh2RbmnTmL7Hw=; b=QElIh8NQOIUKM03p4tYSvwcgoRBqEbB454X9Oz0WCCZRx7wxlZIQvcBQrf4XgXDqpW pWC81UGWwckYnXpvS/JsVaceQMtLYeLjoowJkjr00AdlfDHAXiwCiaXdcaQZA1so6iXK 22kw36WM/ZtEBTIA8rWUbwbj5ODI/dhELPGlPitHpKw41bXh3HID2CLqvp2v5Adzw0pP B9cFvsq+8qGfLSZALr3u4+ORm3jRFxGAg3TbJ5J+Hyz/0Wx3Z12AQ34UuOUhsOpAWA2S oTFmd7jqVuJMeAoCy93uFHRbk6IOEcuWHV4nOUkNXdr6poNrclw/oHuO1Z6donv68hPl /S/g== X-Gm-Message-State: AOAM5311sEPi4Jv3B0wHu0bETxWIj/okgYTuEXN62ABWFzO3AoBmSOIK M88QUeBi49/fy8WYm337wAs= X-Google-Smtp-Source: ABdhPJyriSphcNshVEXxIu2pVoukuPpooloNIi2Fe1EyruyPhgIkVFTs1eKVCm9+If4BB6gQ6rJJiQ== X-Received: by 2002:a2e:8159:: with SMTP id t25mr12413336ljg.84.1617494405108; Sat, 03 Apr 2021 17:00:05 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id z6sm1275369lfr.34.2021.04.03.17.00.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Apr 2021 17:00:04 -0700 (PDT) Date: Sun, 4 Apr 2021 03:00:03 +0300 From: Dmitry Kozlyuk To: Nick Connolly Cc: Bruce Richardson , Ranjit Menon , dev@dpdk.org, navasile@linux.microsoft.com, dmitrym@microsoft.com, pallavi.kadam@intel.com, stable@dpdk.org Message-ID: <20210404030003.54bf9565@sovereign> In-Reply-To: <20210401122723.23082-1-nick.connolly@mayadata.io> References: <20210401122723.23082-1-nick.connolly@mayadata.io> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] build: fix symlink of drivers for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-04-01 13:27 (UTC+0100), Nick Connolly: [...] > +def copy_pmd_files(pattern, to_dir): > + for file in glob.glob(os.path.join(pmd_dir, pattern)): > + to = os.path.join(to_dir, os.path.basename(file)) > + shutil.copy2(file, to) > + print(to + ' -> ' + file) > + > +copy_pmd_files('*rte_*.dll', bin_dir) > +copy_pmd_files('*rte_*.pdb', bin_dir) PDB (debuginfo) files can be quite large, do we want to install them? [...] > diff --git a/config/meson.build b/config/meson.build > index 66a2edcc4..c51669b7d 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -57,11 +57,8 @@ eal_pmd_path = join_paths(get_option('prefix'), driver_install_path) > # driver .so files often depend upon the bus drivers for their connect bus, > # e.g. ixgbe depends on librte_bus_pci. This means that the bus drivers need > # to be in the library path, so symlink the drivers from the main lib directory. > -if not is_windows > - meson.add_install_script('../buildtools/symlink-drivers-solibs.sh', > - get_option('libdir'), > - pmd_subdir_opt) > -endif > +meson.add_install_script(py3, '../buildtools/symlink-drivers-solibs.py', > + get_option('libdir'), pmd_subdir_opt, get_option('bindir')) > > # set the machine type and cflags for it > if meson.is_cross_build() As you may have seen, build fails because find_program() result cannot be used in meson.add_install_script() until 0.55. Since your script has Unix-specific part anyway and Windows recommends Meson 0.56, maybe Unices should continue using shell variant and Python script can be Windows-only.