From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48ACEA0548; Sun, 4 Apr 2021 02:05:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C0074140E9E; Sun, 4 Apr 2021 02:05:51 +0200 (CEST) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mails.dpdk.org (Postfix) with ESMTP id 431744068C for ; Sun, 4 Apr 2021 02:05:50 +0200 (CEST) Received: by mail-lf1-f45.google.com with SMTP id o126so12527960lfa.0 for ; Sat, 03 Apr 2021 17:05:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gN2ZkzDDd2tJO4+uUVO/WmsCEl4h56B1VSOjiCegwDM=; b=rvLyz48uRtDJE/Mn/NndFKRaIjg7oLO4L86NMzg6L9QgkJpyf/P2V+2PJf9GhVKIph UXje5zXfXMgMMogeunloS4/l3Qvlum1kxGcMi8s54143UUoIaSQFYGYMsqJB3PcSG4Zh iamn6iT/GwwT4hS09mJxQwknDSR9s/8sKknB0XplHjflh3cJ+sXo0hwlwesMQNhD9sZc hvdcTH07X1suuilShjb/Y8HtjVePNT7zo2sngLMngwqlhJXuFeZPsZRAxg2p96eEwkRl VvLNRbqjOgWofUybw0g+SD6AlRENltU547JK0HThHoDxZKjntZ/tl0zG7tPtthFMEoLc Fhyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gN2ZkzDDd2tJO4+uUVO/WmsCEl4h56B1VSOjiCegwDM=; b=Hi98zgqC/wfxqFV8FvJUwR+T9cDtgLphkKB69B2l3TFotmg2pQMt7Hes3sWhgEdL4H 3aeML82hv4P4VtLfFmgd1m2PfiFgy4S5cqyQnU6eZqnYN6gm3Tv7HO7ROEbId7wqbenk PRuxdvd/FnGKMiZKDSw9mysdjjZbNIGLHAatF/9fd0ibR+xencd2vNuOB3MtdvskgfaS SMwj8Knufj8kDSDoSZh/oZfYMKgQu6veupsn1FP73RbVk4F31QEAmq2hctYrRuohAIaP j1TEVkva2T6CHwjIS2EdiN8lMUBJmsH7GeSWboskGBfFYJE6XJBbf3HLjgMvFpKRjNST vd4g== X-Gm-Message-State: AOAM532lfEcTpqcFucNmNpthpxGNJlAOAFmL3h8LT2Iey3pmkEQZvU2D Z3wQklQjylHcDHzOdQxNFBk= X-Google-Smtp-Source: ABdhPJyCa77t37Eo8oI1HB4pNxUM3KQTYzKOjxt6zLW6scjCiAGaU3SgpbSMm/y6hOs1U1iSuJ5mSw== X-Received: by 2002:a05:6512:2001:: with SMTP id a1mr13728518lfb.458.1617494749782; Sat, 03 Apr 2021 17:05:49 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id e18sm1373640ljl.92.2021.04.03.17.05.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 03 Apr 2021 17:05:49 -0700 (PDT) Date: Sun, 4 Apr 2021 03:05:48 +0300 From: Dmitry Kozlyuk To: Gabriel Ganne Cc: Bruce Richardson , thierry.herbelot@6wind.com, dev@dpdk.org Message-ID: <20210404030548.434fd498@sovereign> In-Reply-To: <20210326082223.1398-1-gabriel.ganne@6wind.com> References: <20210326082223.1398-1-gabriel.ganne@6wind.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-03-26 09:22 (UTC+0100), Gabriel Ganne: > libpcap is already found and registered as a dependency by meson, and > the dependency is already correctly used in librte_port. This line is > just unnecessary. > > It also has the side effect of messing with the meson link line: dpdk > link will be declared twice: manually and then through pkg-config. If > you configure meson to prefer static linking over dynamic, this will > cause the build to fail on librte_port, since the pcap deps are not yet > seen by the linker. > > Signed-off-by: Gabriel Ganne > --- > config/meson.build | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/config/meson.build b/config/meson.build > index 66a2edcc47f5..95777cf33169 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -183,7 +183,6 @@ if not pcap_dep.found() > endif > if pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap_dep) > dpdk_conf.set('RTE_PORT_PCAP', 1) > - dpdk_extra_ldflags += '-lpcap' > endif > > # for clang 32-bit compiles we need libatomic for 64-bit atomic ops This patch also simplifies future changes to discover libpcap on Windows. Acked-by: Dmitry Kozlyuk