From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH] build: list symbols exports in a single file
Date: Tue, 6 Apr 2021 17:50:58 +0100 [thread overview]
Message-ID: <20210406165058.GD551@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <20210406163231.19663-1-david.marchand@redhat.com>
On Tue, Apr 06, 2021 at 06:32:30PM +0200, David Marchand wrote:
> Rather than have two files that keeps getting out of sync, let's
> annotate the version.map to generate the Windows export file.
>
> Note: EAL version.map annotation achieved with:
> $ ./buildtools/map-list-symbol.sh lib/librte_eal/version.map |
> while read file version sym; do
> ! git grep -qw $sym lib/librte_eal/*.def || continue;
> sed -i -e "s/$sym;/$sym; # WINDOWS_NO_EXPORT/" lib/librte_eal/*.map;
> done
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
+1 to the idea, this is great to see.
> MAINTAINERS | 1 -
> buildtools/map_to_win.py | 8 +-
> devtools/check-symbol-maps.sh | 20 --
> lib/librte_eal/rte_eal_exports.def | 336 -----------------------------
> lib/librte_eal/version.map | 136 ++++++------
> 5 files changed, 69 insertions(+), 432 deletions(-)
> delete mode 100644 lib/librte_eal/rte_eal_exports.def
>
<snip>
> -# special case, allow override if an def file already exists alongside map file
> - override_file = join(dirname(args[1]), basename(args[2]))
> - if exists(override_file):
> - with open(override_file) as f_in:
> - functions = f_in.readlines()
> -
If this is removed, then drivers/common/mlx5/version.map similarly needs to
be annotated so that we can remove rte_common_mlx5_exports.def
next prev parent reply other threads:[~2021-04-06 16:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 16:32 David Marchand
2021-04-06 16:40 ` David Marchand
2021-04-06 16:50 ` Bruce Richardson [this message]
2021-04-06 16:53 ` David Marchand
2021-04-07 20:06 ` Kinsella, Ray
2021-04-06 17:59 ` [dpdk-dev] [PATCH v2] " David Marchand
2021-04-06 18:52 ` Thomas Monjalon
2021-04-06 20:09 ` David Marchand
2021-04-06 22:39 ` Thomas Monjalon
2021-04-07 8:16 ` David Marchand
2021-04-07 8:53 ` Dmitry Kozlyuk
2021-04-07 8:57 ` Thomas Monjalon
2021-04-07 11:38 ` Tal Shnaiderman
2021-04-08 14:51 ` Thomas Monjalon
2021-04-08 16:11 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210406165058.GD551@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=mdr@ashroe.eu \
--cc=navasile@linux.microsoft.com \
--cc=nhorman@tuxdriver.com \
--cc=pallavi.kadam@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).