From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22ADEA0546; Tue, 6 Apr 2021 18:51:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A03B40F35; Tue, 6 Apr 2021 18:51:07 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 548BF4067C for ; Tue, 6 Apr 2021 18:51:05 +0200 (CEST) IronPort-SDR: AAGpGhwdyRuf3etOf6jcZCtegUBt8e8GV8NVfDh8RSb3kDFesjem8TbKDOZ/zmpwVNdXlg1U6A 0Qbm5s93/12Q== X-IronPort-AV: E=McAfee;i="6000,8403,9946"; a="189904429" X-IronPort-AV: E=Sophos;i="5.82,201,1613462400"; d="scan'208";a="189904429" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2021 09:51:04 -0700 IronPort-SDR: OFlx1ojHJFJrCPfUye6COMOzzZ7V8EcXqxJoKS2i+oQQPYQKCwZvZMmubidCG20TPiDFY3DchV gR2slUjkLXIQ== X-IronPort-AV: E=Sophos;i="5.82,201,1613462400"; d="scan'208";a="414855104" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.31.235]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 06 Apr 2021 09:51:02 -0700 Date: Tue, 6 Apr 2021 17:50:58 +0100 From: Bruce Richardson To: David Marchand Cc: dev@dpdk.org, thomas@monjalon.net, Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Ray Kinsella , Neil Horman Message-ID: <20210406165058.GD551@bricha3-MOBL.ger.corp.intel.com> References: <20210406163231.19663-1-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406163231.19663-1-david.marchand@redhat.com> Subject: Re: [dpdk-dev] [PATCH] build: list symbols exports in a single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 06, 2021 at 06:32:30PM +0200, David Marchand wrote: > Rather than have two files that keeps getting out of sync, let's > annotate the version.map to generate the Windows export file. > > Note: EAL version.map annotation achieved with: > $ ./buildtools/map-list-symbol.sh lib/librte_eal/version.map | > while read file version sym; do > ! git grep -qw $sym lib/librte_eal/*.def || continue; > sed -i -e "s/$sym;/$sym; # WINDOWS_NO_EXPORT/" lib/librte_eal/*.map; > done > > Signed-off-by: David Marchand > --- +1 to the idea, this is great to see. > MAINTAINERS | 1 - > buildtools/map_to_win.py | 8 +- > devtools/check-symbol-maps.sh | 20 -- > lib/librte_eal/rte_eal_exports.def | 336 ----------------------------- > lib/librte_eal/version.map | 136 ++++++------ > 5 files changed, 69 insertions(+), 432 deletions(-) > delete mode 100644 lib/librte_eal/rte_eal_exports.def > > -# special case, allow override if an def file already exists alongside map file > - override_file = join(dirname(args[1]), basename(args[2])) > - if exists(override_file): > - with open(override_file) as f_in: > - functions = f_in.readlines() > - If this is removed, then drivers/common/mlx5/version.map similarly needs to be annotated so that we can remove rte_common_mlx5_exports.def