From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A59BEA0546; Wed, 7 Apr 2021 10:53:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D54A1410D4; Wed, 7 Apr 2021 10:53:33 +0200 (CEST) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by mails.dpdk.org (Postfix) with ESMTP id 5C848407FF for ; Wed, 7 Apr 2021 10:53:32 +0200 (CEST) Received: by mail-lf1-f46.google.com with SMTP id n138so27264062lfa.3 for ; Wed, 07 Apr 2021 01:53:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EYRyngLoIhRicdwLm2ST88mIw8gbUS+MNRxIZA3oz3Y=; b=XR+KXzScJD46oUKcjButc/lPaQ+ccReQtGfqKdAMJp8gwuoYbLSkneFdEkiSbJUFp+ E5nHC2mg/lUBpYuZty5L2yayvCO1V1+d7qbNnXyh8wuRDzbhjFcVaCE5XiepE7V97Tci KHlsECAU1UTcnfrP6bUlKGGAagWNEZHKGAJlg2hWcF5JD7hjajM192j5Ag7BpVy41aLA TOFFNSuMVmD97M3KrROLMtYMOlOfiAx1jPmMhKSLbGe1XlnZKpUWgWJ6oo3mNBLTN0+N aRrzhHDg0xCgafsSzHGjMdYC/ZPjknGW9Y0v9m6puvQW2/NWk4zGRGq3ZvZQn0fwG3+e WWiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EYRyngLoIhRicdwLm2ST88mIw8gbUS+MNRxIZA3oz3Y=; b=soMDl5KvPcfV4jjvBl0ihxRbzG1tmUU87E5FZah1NnrMl8AhPoK96uVGxXTdDs7Qr5 7bxMHJFseMdvyp5ulyBb9MQeS2JXiWebBrQ6f2MEJ2iLQBREwWKrp5QFxVAD3E574NLu QRUwuxNC8Ogh3NCt+7+9fbvSn9NWxRCggzJ7f49Dv58o0aENE/2+ZzOovLDeHv4/0SuD PsLq38UK5U1EwrK4PtAd280p/RgnXvmVXFDJzx/viGlge8afAdl8bBhwrTpecVXh/idU NH6Zx/pGXSS0Mk1efo6Al2/IExGceffHaFAjhVwSTdMf+eFWKZYx/p3Zy0Mt4C0m9NCL Gnjg== X-Gm-Message-State: AOAM530XzSV6+emiKDbPEpcg4/AfkhyjbVZ/jTwlcz9I6JHwMQCYRB7q q48txYce9FFe7W4cYcxGk3M= X-Google-Smtp-Source: ABdhPJwFfOF6FOignat41RN+NsXm2zWqyrtb2o1F2ifW6wP0p4CBcVj7dG7GyAkA6udkifCnYpzj8A== X-Received: by 2002:a19:e347:: with SMTP id c7mr1764028lfk.632.1617785611943; Wed, 07 Apr 2021 01:53:31 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id y10sm2481765lfl.240.2021.04.07.01.53.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Apr 2021 01:53:31 -0700 (PDT) Date: Wed, 7 Apr 2021 11:53:30 +0300 From: Dmitry Kozlyuk To: David Marchand Cc: Thomas Monjalon , Narcisa Ana Maria Vasile , Dmitry Malloy , dev , Bruce Richardson , Pallavi Kadam , Ray Kinsella , Neil Horman , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko Message-ID: <20210407115330.42701deb@sovereign> In-Reply-To: References: <20210406163231.19663-1-david.marchand@redhat.com> <20210406175910.24450-1-david.marchand@redhat.com> <4303766.JfoNgE5a7G@thomas> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] build: list symbols exports in a single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-04-07 10:16 (UTC+0200), David Marchand: > On Tue, Apr 6, 2021 at 10:09 PM David Marchand > wrote: > > We have exports missing in EAL for some series posted on the ml > > waiting for merges. > > I suspect some recent merged changes have issues too (but did not check yet). > > This current patch does not address such issues and we need fixes > > afterwards if this is what you mean. > > I did a first pass. > > I see symbols from rte_random.c and rte_version.c not exported, while > those files are compiled for Windows. > Could you explain why these are not exported? These are just forgotten, can be safely exported.