From: Shijith Thotton <shijith.thotton@gmail.com>
To: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
Cc: Anoob Joseph <anoobj@marvell.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
"sachin.saxena@oss.nxp.com" <sachin.saxena@oss.nxp.com>,
"matan@nvidia.com" <matan@nvidia.com>,
"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"g.singh@nxp.com" <g.singh@nxp.com>,
"Carrillo, Erik G" <erik.g.carrillo@intel.com>,
"Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>,
Akhil Goyal <gakhil@marvell.com>,
Shijith Thotton <sthotton@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4 2/3] event/octeontx2: support crypto adapter forward mode
Date: Thu, 8 Apr 2021 12:15:39 +0530 [thread overview]
Message-ID: <20210408064539.GA21@BG-LT7405.marvell.com> (raw)
In-Reply-To: <DM6PR11MB3548613FB4B2E011285FF421E8759@DM6PR11MB3548.namprd11.prod.outlook.com>
On Wed, Apr 07, 2021 at 03:06:16PM +0000, Gujjar, Abhinandan S wrote:
>
>
> > -----Original Message-----
> > From: Anoob Joseph <anoobj@marvell.com>
> > Sent: Tuesday, April 6, 2021 8:31 PM
> > To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> > Cc: thomas@monjalon.net; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> > hemant.agrawal@nxp.com; nipun.gupta@nxp.com;
> > sachin.saxena@oss.nxp.com; matan@nvidia.com; Zhang, Roy Fan
> > <roy.fan.zhang@intel.com>; g.singh@nxp.com; Carrillo, Erik G
> > <erik.g.carrillo@intel.com>; Jayatheerthan, Jay
> > <jay.jayatheerthan@intel.com>; Pavan Nikhilesh Bhagavatula
> > <pbhagavatula@marvell.com>; Van Haaren, Harry
> > <harry.van.haaren@intel.com>; Akhil Goyal <gakhil@marvell.com>; Shijith
> > Thotton <sthotton@marvell.com>; dev@dpdk.org
> > Subject: RE: [PATCH v4 2/3] event/octeontx2: support crypto adapter
> > forward mode
> >
> > Hi Abhinandan,
> >
> > Please see inline.
> >
> > Thanks,
> > Anoob
> >
> > > >
> > > > Advertise crypto adapter forward mode capability and set crypto
> > > > adapter enqueue function in driver.
> > > >
> > > > Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> >
> > [snip]
> >
> > > > +
> > > > + if (!ev->sched_type)
> > > > + otx2_ssogws_head_wait(tag_op);
> > > > + if (qp->ca_enable)
> > > > + return cdev->enqueue_burst(qp, &crypto_op, 1);
> > > > +
> > > > +free_op:
> > > > + rte_pktmbuf_free(crypto_op->sym->m_src);
> > > > + rte_crypto_op_free(crypto_op);
> > > > + return 0;
> > > > +}
> > >
> > > I am trying to understand this in requirement perspective. This
> > > enqueue function is same as SW adapter's enqueue function.
> > > Currently, application could directly enqueue to cryptodev in NEW
> > > mode. By having this in PMD, how is FORWARD mode taken care?
> > >
> >
> > [Anoob] Difference is the ordering point when used with ORDERED flows.
> >
> > If application is working on an ORDERED flow, with OP_NEW, application
> > would require to queue to an ATOMIC queue before submitting to cryptodev
> > (to maintain ordering). But with OP_FORWARD, application can provide an
> > event to the event PMD and internally it can take care of ordering as well
> > enqueue to crypto "hardware". This becomes particularly useful when event
> > hardware can support ordering while enqueueing to crypto hardware(and
> > hence the "internal port").
> Got it.
> Referring to the above code, if qp->ca_enable is not enabled, the ops and
> mbuf will be freed and returned 0. Does not this make the application/worker
> to think that enqueue is not successful and it should retry enqueuing same
> buffers again?
>
Thanks for pointing out. Will use proper error number for failures in next
version.
> >
> > With the current spec, OP_FORWARD would allow application to enqueue
> > crypto_op as an event to event device. But this event doesn't have any
> > additional information which would indicate it is destined to crypto. The
> > new API would solve this issue.
> >
> > [snip]
next prev parent reply other threads:[~2021-04-08 6:45 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 18:12 [dpdk-dev] [PATCH] [RFC] eventdev: introduce crypto adapter enqueue API Akhil Goyal
2021-03-26 9:12 ` [dpdk-dev] [PATCH v1 0/2] Enhancements to crypto adapter forward mode Shijith Thotton
2021-03-26 9:12 ` [dpdk-dev] [PATCH v1 1/2] eventdev: introduce crypto adapter enqueue API Shijith Thotton
2021-03-27 6:04 ` Pavan Nikhilesh Bhagavatula
2021-03-26 9:12 ` [dpdk-dev] [PATCH v1 2/2] event/octeontx2: support crypto adapter forward mode Shijith Thotton
2021-03-27 6:27 ` Pavan Nikhilesh Bhagavatula
2021-03-29 4:31 ` Shijith Thotton
2021-03-29 15:04 ` [dpdk-dev] [PATCH v2 0/2] Enhancements to " Shijith Thotton
2021-03-29 15:04 ` [dpdk-dev] [PATCH v2 1/2] eventdev: introduce crypto adapter enqueue API Shijith Thotton
2021-03-29 15:04 ` [dpdk-dev] [PATCH v2 2/2] event/octeontx2: support crypto adapter forward mode Shijith Thotton
2021-04-02 15:03 ` [dpdk-dev] [PATCH v3 0/3] Enhancements to " Shijith Thotton
2021-04-02 15:03 ` [dpdk-dev] [PATCH v3 1/3] eventdev: introduce crypto adapter enqueue API Shijith Thotton
2021-04-02 15:03 ` [dpdk-dev] [PATCH v3 2/3] event/octeontx2: support crypto adapter forward mode Shijith Thotton
2021-04-02 15:03 ` [dpdk-dev] [PATCH v3 3/3] test/event_crypto: use crypto adapter enqueue API Shijith Thotton
2021-04-02 17:01 ` [dpdk-dev] [PATCH v4 0/3] Enhancements to crypto adapter forward mode Shijith Thotton
2021-04-02 17:01 ` [dpdk-dev] [PATCH v4 1/3] eventdev: introduce crypto adapter enqueue API Shijith Thotton
2021-04-03 12:32 ` Gujjar, Abhinandan S
2021-04-05 17:40 ` Akhil Goyal
2021-04-07 15:28 ` Gujjar, Abhinandan S
2021-04-08 14:56 ` Akhil Goyal
2021-04-08 16:57 ` Gujjar, Abhinandan S
2021-04-08 18:44 ` Akhil Goyal
2021-04-02 17:01 ` [dpdk-dev] [PATCH v4 2/3] event/octeontx2: support crypto adapter forward mode Shijith Thotton
2021-04-03 10:20 ` Gujjar, Abhinandan S
2021-04-06 15:01 ` Anoob Joseph
2021-04-07 15:06 ` Gujjar, Abhinandan S
2021-04-08 6:45 ` Shijith Thotton [this message]
2021-04-02 17:01 ` [dpdk-dev] [PATCH v4 3/3] test/event_crypto: use crypto adapter enqueue API Shijith Thotton
2021-04-03 11:08 ` Gujjar, Abhinandan S
2021-04-05 6:10 ` Shijith Thotton
2021-04-08 19:24 ` [dpdk-dev] [PATCH v5 0/3] Enhancements to crypto adapter forward mode Shijith Thotton
2021-04-08 19:24 ` [dpdk-dev] [PATCH v5 1/3] eventdev: introduce crypto adapter enqueue API Shijith Thotton
2021-04-08 19:24 ` [dpdk-dev] [PATCH v5 2/3] event/octeontx2: support crypto adapter forward mode Shijith Thotton
2021-04-08 19:24 ` [dpdk-dev] [PATCH v5 3/3] test/event_crypto: use crypto adapter enqueue API Shijith Thotton
2021-04-09 14:00 ` [dpdk-dev] [PATCH v6 0/3] Enhancements to crypto adapter forward mode Shijith Thotton
2021-04-09 14:00 ` [dpdk-dev] [PATCH v6 1/3] eventdev: introduce crypto adapter enqueue API Shijith Thotton
2021-04-09 14:00 ` [dpdk-dev] [PATCH v6 2/3] event/octeontx2: support crypto adapter forward mode Shijith Thotton
2021-04-09 14:00 ` [dpdk-dev] [PATCH v6 3/3] test/event_crypto: use crypto adapter enqueue API Shijith Thotton
2021-04-12 5:10 ` Gujjar, Abhinandan S
2021-04-12 7:02 ` Shijith Thotton
2021-04-12 7:24 ` Gujjar, Abhinandan S
2021-04-12 7:35 ` Shijith Thotton
2021-04-12 13:52 ` Shijith Thotton
2021-04-12 15:00 ` Gujjar, Abhinandan S
2021-04-12 7:43 ` [dpdk-dev] [PATCH v7 0/3] Enhancements to crypto adapter forward mode Shijith Thotton
2021-04-12 7:43 ` [dpdk-dev] [PATCH v7 1/3] eventdev: introduce crypto adapter enqueue API Shijith Thotton
2021-04-13 3:23 ` Gujjar, Abhinandan S
2021-04-12 7:43 ` [dpdk-dev] [PATCH v7 2/3] event/octeontx2: support crypto adapter forward mode Shijith Thotton
2021-04-13 3:34 ` Gujjar, Abhinandan S
2021-04-13 8:51 ` Shijith Thotton
2021-04-12 7:43 ` [dpdk-dev] [PATCH v7 3/3] test/event_crypto: use crypto adapter enqueue API Shijith Thotton
2021-04-13 3:45 ` Gujjar, Abhinandan S
2021-04-13 10:29 ` [dpdk-dev] [PATCH v8 0/3] Enhancements to crypto adapter forward mode Shijith Thotton
2021-04-13 10:29 ` [dpdk-dev] [PATCH v8 1/3] eventdev: introduce crypto adapter enqueue API Shijith Thotton
2021-04-14 7:28 ` Jerin Jacob Kollanukkaran
2021-04-14 7:58 ` Akhil Goyal
2021-04-14 8:18 ` Thomas Monjalon
2021-04-14 8:39 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-04-14 8:43 ` Thomas Monjalon
2021-04-14 12:20 ` [dpdk-dev] [PATCH v9 0/4] Enhancements to crypto adapter forward mode gakhil
2021-04-14 12:20 ` [dpdk-dev] [PATCH v9 1/4] eventdev: introduce crypto adapter enqueue API gakhil
2021-04-14 18:04 ` [dpdk-dev] [PATCH v10 0/4] Enhancements to crypto adapter forward mode gakhil
2021-04-14 18:04 ` [dpdk-dev] [PATCH v10 1/4] devtools: add exception for reserved fields gakhil
2021-04-14 20:57 ` David Marchand
2021-04-15 5:32 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-04-15 7:26 ` David Marchand
2021-04-15 8:25 ` Bruce Richardson
2021-04-15 8:27 ` Thomas Monjalon
2021-04-15 8:31 ` Akhil Goyal
2021-04-15 19:56 ` Stephen Hemminger
2021-04-15 9:13 ` [dpdk-dev] [PATCH v11 0/3] Enhancements to crypto adapter forward mode gakhil
2021-04-15 9:13 ` [dpdk-dev] [PATCH v11 1/3] eventdev: introduce crypto adapter enqueue API gakhil
2021-04-17 16:54 ` Jerin Jacob
2021-04-15 9:13 ` [dpdk-dev] [PATCH v11 2/3] event/octeontx2: support crypto adapter forward mode gakhil
2021-04-15 9:13 ` [dpdk-dev] [PATCH v11 3/3] test/event_crypto: use crypto adapter enqueue API gakhil
2021-04-14 18:04 ` [dpdk-dev] [PATCH v10 2/4] eventdev: introduce " gakhil
2021-04-14 18:04 ` [dpdk-dev] [PATCH v10 3/4] event/octeontx2: support crypto adapter forward mode gakhil
2021-04-14 18:04 ` [dpdk-dev] [PATCH v10 4/4] test/event_crypto: use crypto adapter enqueue API gakhil
2021-04-14 12:20 ` [dpdk-dev] [PATCH v9 2/4] event/octeontx2: support crypto adapter forward mode gakhil
2021-04-14 12:20 ` [dpdk-dev] [PATCH v9 3/4] test/event_crypto: use crypto adapter enqueue API gakhil
2021-04-14 12:20 ` [dpdk-dev] [PATCH v9 4/4] devtools: add exception for reserved fields gakhil
2021-04-14 12:53 ` Thomas Monjalon
2021-04-14 14:16 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-04-14 14:22 ` Thomas Monjalon
2021-04-14 17:56 ` Akhil Goyal
2021-04-13 10:29 ` [dpdk-dev] [PATCH v8 2/3] event/octeontx2: support crypto adapter forward mode Shijith Thotton
2021-04-13 10:29 ` [dpdk-dev] [PATCH v8 3/3] test/event_crypto: use crypto adapter enqueue API Shijith Thotton
2021-04-13 19:40 ` Jerin Jacob
2021-03-30 4:04 ` [dpdk-dev] [PATCH v1 0/2] Enhancements to crypto adapter forward mode Jerin Jacob
2021-03-30 4:57 ` Gujjar, Abhinandan S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408064539.GA21@BG-LT7405.marvell.com \
--to=shijith.thotton@gmail.com \
--cc=abhinandan.gujjar@intel.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=g.singh@nxp.com \
--cc=gakhil@marvell.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
--cc=matan@nvidia.com \
--cc=nipun.gupta@nxp.com \
--cc=pbhagavatula@marvell.com \
--cc=roy.fan.zhang@intel.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=sthotton@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).