From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F3D9A0C45; Sun, 11 Apr 2021 23:49:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B2C5141465; Sun, 11 Apr 2021 23:49:46 +0200 (CEST) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by mails.dpdk.org (Postfix) with ESMTP id 750C9141464 for ; Sun, 11 Apr 2021 23:49:45 +0200 (CEST) Received: by mail-lf1-f49.google.com with SMTP id n138so18253319lfa.3 for ; Sun, 11 Apr 2021 14:49:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WUolM7d0QabbKiTaTa4chDSMQUzriKSLWEIcZZDLMm8=; b=W2K7JDq3Of6QH8wtLcYM6MG4QthH3E4TvDhja/paM1Liy/TRJAtAfXta3g6afawLYw EclkSSiUjZd6IWWKS+U1Gnf6KiochYXTIEZ29AemEotYxmRadWHSVDrBn+Y9UmBx5cHT UAeCw3hptFLUjd2I9FC1EZO0qsvCRbViQIx/u548ELvqLOF/qOjHDGTyknEPoAiGgmlJ ZgEy+cpNR4PyacuGACBqcvNFVC7K2MqHse1e4g+7i90gZL8gFXMJ4ZyNCODo3KRe+4q7 tSzOiXYsVkkeoqtivA6h+Mnh+Ms8aUct/SoW/z6g0LA7kc0fzFS2YxnN0SKD+eIMuHzG Cxdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WUolM7d0QabbKiTaTa4chDSMQUzriKSLWEIcZZDLMm8=; b=lqyL/P+GhRAaS+Ob4Y1vsMT9x+wpd6TJE3yORZB4E0czyutn9OJlCwATDGTdhvZWwC 2spfhAUpLfXOKjJMAapADLXckzlP/pqpzS9U+f8yLf3kGNy2leGBwNfl09Yd8KIU7H+i eWRkYWab6JFDd3j+3qtJRrAnMjOBHMuC1sLdgepsonggk0oMsF09g22OTZbCuQMyxDfG 3s+8qjacZW/JVl1qaRMKkhTz267L7fDUNuYWwJOViWUtQ2yPlGNxPdjfQuUBk9JLqOlQ ijUjH8aLpLYLLifOCNeGYZjKbRkFNIK6qeEa0fv30kLkMws/UzKH7sF7IUvD/ArqnuUA Ra1Q== X-Gm-Message-State: AOAM5301E5aZRNgsoXTVgsfJdu7S1lNsq99IujaK1VG+giWIC1V6iT6g nsygZlW5FV+wLs7hwYtlj/M= X-Google-Smtp-Source: ABdhPJxYRqm7f+b+u2a/zIXJpulIat2gyf9lkiXYiydZXkKjlr2EQ7r/QeVW/Dr8q9lG0HuataljXw== X-Received: by 2002:ac2:4949:: with SMTP id o9mr16834304lfi.174.1618177785000; Sun, 11 Apr 2021 14:49:45 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id l7sm565329ljj.19.2021.04.11.14.49.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Apr 2021 14:49:44 -0700 (PDT) Date: Mon, 12 Apr 2021 00:49:43 +0300 From: Dmitry Kozlyuk To: Jie Zhou Cc: "Kadam, Pallavi" , dev@dpdk.org, xiaoyun.li@intel.com, roretzla@microsoft.com, thomas@monjalon.net, bruce.richardson@intel.com, ferruh.yigit@intel.com Message-ID: <20210412004943.7a693d6a@sovereign> In-Reply-To: <20210402221401.GA6573@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1616048795-16906-1-git-send-email-jizh@linux.microsoft.com> <1616172695-28505-1-git-send-email-jizh@linux.microsoft.com> <0ec41402-6cb4-265b-5e97-6c274b0264a8@intel.com> <20210402221401.GA6573@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] app/test-pmd: enable testpmd on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-04-02 15:14 (UTC-0700), Jie Zhou: > On Wed, Mar 31, 2021 at 12:10:03PM -0700, Kadam, Pallavi wrote: > >=20 > > On 3/19/2021 9:51 AM, Jie Zhou wrote: =20 > > >From: Jie Zhou [...] > > >--- a/app/test-pmd/testpmd.c > > >+++ b/app/test-pmd/testpmd.c > > >@@ -9,7 +9,9 @@ > > > #include > > > #include > > > #include > > >+#ifndef RTE_EXEC_ENV_WINDOWS > > > #include > > >+#endif =20 > >=20 > > Can 'mmap' and 'munmap' be replaced with 'rte_mem_map' and > > 'rte_mem_unmap'=C2=A0 and #include instead? > > =20 > Thanks Pallavi, will address in next version.=20 Note that rte_mem_map() doesn't allow mapping hugepages of different sizes, so xmemhuge will probably remain unsupported on Windows for now.