* [dpdk-dev] [PATCH] net/memif: fix missing Tx-bps stats for zero-copy
@ 2021-04-12 8:22 Tianyu Li
2021-04-14 8:13 ` Ferruh Yigit
2021-05-19 7:57 ` Ferruh Yigit
0 siblings, 2 replies; 6+ messages in thread
From: Tianyu Li @ 2021-04-12 8:22 UTC (permalink / raw)
To: Jakub Grajciar, Ferruh Yigit; +Cc: dev, nd, Tianyu Li, stable
Fix the missing Tx-bps counter for memif zero-copy mode
Before
Rx-pps: 6891450 Rx-bps: 3528438928
Tx-pps: 6891482 Tx-bps: 0
After
Throughput (since last show)
Rx-pps: 11157056 Rx-bps: 5712413016
Tx-pps: 11157056 Tx-bps: 5712413016
Fixes: 43b815d88188 ("net/memif: support zero-copy slave")
Cc: stable@dpdk.org
Signed-off-by: Tianyu Li <tianyu.li@arm.com>
---
drivers/net/memif/rte_eth_memif.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
index 77c95bcb7..dd2825968 100644
--- a/drivers/net/memif/rte_eth_memif.c
+++ b/drivers/net/memif/rte_eth_memif.c
@@ -706,6 +706,7 @@ memif_tx_one_zc(struct pmd_process_private *proc_private, struct memif_queue *mq
/* populate descriptor */
d0 = &ring->desc[slot & mask];
d0->length = rte_pktmbuf_data_len(mbuf);
+ mq->n_bytes += rte_pktmbuf_data_len(mbuf);
/* FIXME: get region index */
d0->region = 1;
d0->offset = rte_pktmbuf_mtod(mbuf, uint8_t *) -
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/memif: fix missing Tx-bps stats for zero-copy
2021-04-12 8:22 [dpdk-dev] [PATCH] net/memif: fix missing Tx-bps stats for zero-copy Tianyu Li
@ 2021-04-14 8:13 ` Ferruh Yigit
2021-04-27 6:30 ` Tianyu Li
2021-05-19 7:57 ` Ferruh Yigit
1 sibling, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2021-04-14 8:13 UTC (permalink / raw)
To: Tianyu Li, Jakub Grajciar; +Cc: dev, nd, stable
On 4/12/2021 9:22 AM, Tianyu Li wrote:
> Fix the missing Tx-bps counter for memif zero-copy mode
> Before
> Rx-pps: 6891450 Rx-bps: 3528438928
> Tx-pps: 6891482 Tx-bps: 0
> After
> Throughput (since last show)
> Rx-pps: 11157056 Rx-bps: 5712413016
> Tx-pps: 11157056 Tx-bps: 5712413016
>
> Fixes: 43b815d88188 ("net/memif: support zero-copy slave")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tianyu Li <tianyu.li@arm.com>
> ---
> drivers/net/memif/rte_eth_memif.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c
> index 77c95bcb7..dd2825968 100644
> --- a/drivers/net/memif/rte_eth_memif.c
> +++ b/drivers/net/memif/rte_eth_memif.c
> @@ -706,6 +706,7 @@ memif_tx_one_zc(struct pmd_process_private *proc_private, struct memif_queue *mq
> /* populate descriptor */
> d0 = &ring->desc[slot & mask];
> d0->length = rte_pktmbuf_data_len(mbuf);
> + mq->n_bytes += rte_pktmbuf_data_len(mbuf);
> /* FIXME: get region index */
> d0->region = 1;
> d0->offset = rte_pktmbuf_mtod(mbuf, uint8_t *) -
>
Looks good to me, but let's wait Jakub's review for it.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/memif: fix missing Tx-bps stats for zero-copy
2021-04-14 8:13 ` Ferruh Yigit
@ 2021-04-27 6:30 ` Tianyu Li
2021-05-18 12:08 ` Ferruh Yigit
0 siblings, 1 reply; 6+ messages in thread
From: Tianyu Li @ 2021-04-27 6:30 UTC (permalink / raw)
To: Ferruh Yigit, Jakub Grajciar; +Cc: dev, nd, stable
Hi Jakub,
Any comments about the patch?
-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@intel.com>
Sent: Wednesday, April 14, 2021 4:13 PM
To: Tianyu Li <Tianyu.Li@arm.com>; Jakub Grajciar <jgrajcia@cisco.com>
Cc: dev@dpdk.org; nd <nd@arm.com>; stable@dpdk.org
Subject: Re: [PATCH] net/memif: fix missing Tx-bps stats for zero-copy
On 4/12/2021 9:22 AM, Tianyu Li wrote:
> Fix the missing Tx-bps counter for memif zero-copy mode Before
> Rx-pps: 6891450 Rx-bps: 3528438928
> Tx-pps: 6891482 Tx-bps: 0
> After
> Throughput (since last show)
> Rx-pps: 11157056 Rx-bps: 5712413016
> Tx-pps: 11157056 Tx-bps: 5712413016
>
> Fixes: 43b815d88188 ("net/memif: support zero-copy slave")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tianyu Li <tianyu.li@arm.com>
> ---
> drivers/net/memif/rte_eth_memif.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/memif/rte_eth_memif.c
> b/drivers/net/memif/rte_eth_memif.c
> index 77c95bcb7..dd2825968 100644
> --- a/drivers/net/memif/rte_eth_memif.c
> +++ b/drivers/net/memif/rte_eth_memif.c
> @@ -706,6 +706,7 @@ memif_tx_one_zc(struct pmd_process_private *proc_private, struct memif_queue *mq
> /* populate descriptor */
> d0 = &ring->desc[slot & mask];
> d0->length = rte_pktmbuf_data_len(mbuf);
> + mq->n_bytes += rte_pktmbuf_data_len(mbuf);
> /* FIXME: get region index */
> d0->region = 1;
> d0->offset = rte_pktmbuf_mtod(mbuf, uint8_t *) -
>
Looks good to me, but let's wait Jakub's review for it.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/memif: fix missing Tx-bps stats for zero-copy
2021-04-27 6:30 ` Tianyu Li
@ 2021-05-18 12:08 ` Ferruh Yigit
2021-05-18 16:57 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2021-05-18 12:08 UTC (permalink / raw)
To: Tianyu Li, Jakub Grajciar, Damjan Marion (damarion); +Cc: dev, nd, stable
On 4/27/2021 7:30 AM, Tianyu Li wrote:
> Hi Jakub,
>
> Any comments about the patch?
>
+Damjan.
Hi Damjan,
Is Jakub still maintaining the net/memif?
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Wednesday, April 14, 2021 4:13 PM
> To: Tianyu Li <Tianyu.Li@arm.com>; Jakub Grajciar <jgrajcia@cisco.com>
> Cc: dev@dpdk.org; nd <nd@arm.com>; stable@dpdk.org
> Subject: Re: [PATCH] net/memif: fix missing Tx-bps stats for zero-copy
>
> On 4/12/2021 9:22 AM, Tianyu Li wrote:
>> Fix the missing Tx-bps counter for memif zero-copy mode Before
>> Rx-pps: 6891450 Rx-bps: 3528438928
>> Tx-pps: 6891482 Tx-bps: 0
>> After
>> Throughput (since last show)
>> Rx-pps: 11157056 Rx-bps: 5712413016
>> Tx-pps: 11157056 Tx-bps: 5712413016
>>
>> Fixes: 43b815d88188 ("net/memif: support zero-copy slave")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Tianyu Li <tianyu.li@arm.com>
>> ---
>> drivers/net/memif/rte_eth_memif.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/memif/rte_eth_memif.c
>> b/drivers/net/memif/rte_eth_memif.c
>> index 77c95bcb7..dd2825968 100644
>> --- a/drivers/net/memif/rte_eth_memif.c
>> +++ b/drivers/net/memif/rte_eth_memif.c
>> @@ -706,6 +706,7 @@ memif_tx_one_zc(struct pmd_process_private *proc_private, struct memif_queue *mq
>> /* populate descriptor */
>> d0 = &ring->desc[slot & mask];
>> d0->length = rte_pktmbuf_data_len(mbuf);
>> + mq->n_bytes += rte_pktmbuf_data_len(mbuf);
>> /* FIXME: get region index */
>> d0->region = 1;
>> d0->offset = rte_pktmbuf_mtod(mbuf, uint8_t *) -
>>
>
> Looks good to me, but let's wait Jakub's review for it.
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/memif: fix missing Tx-bps stats for zero-copy
2021-05-18 12:08 ` Ferruh Yigit
@ 2021-05-18 16:57 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
0 siblings, 0 replies; 6+ messages in thread
From: Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco) @ 2021-05-18 16:57 UTC (permalink / raw)
To: Ferruh Yigit, Tianyu Li, Damjan Marion (damarion); +Cc: dev, nd, stable
Hi,
Sorry for the inconvenience, the thread got filtered so I only found it in spam after Damjan notified me.
The patch looks good. Thanks for the fix!
Reviewd-By: Jakub Grajciar <jgrajcia@cisco.com>
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Tuesday, May 18, 2021 2:09 PM
> To: Tianyu Li <Tianyu.Li@arm.com>; Jakub Grajciar -X (jgrajcia - PANTHEON
> TECH SRO at Cisco) <jgrajcia@cisco.com>; Damjan Marion (damarion)
> <damarion@cisco.com>
> Cc: dev@dpdk.org; nd <nd@arm.com>; stable@dpdk.org
> Subject: Re: [PATCH] net/memif: fix missing Tx-bps stats for zero-copy
>
> On 4/27/2021 7:30 AM, Tianyu Li wrote:
> > Hi Jakub,
> >
> > Any comments about the patch?
> >
>
> +Damjan.
>
> Hi Damjan,
>
> Is Jakub still maintaining the net/memif?
>
> > -----Original Message-----
> > From: Ferruh Yigit <ferruh.yigit@intel.com>
> > Sent: Wednesday, April 14, 2021 4:13 PM
> > To: Tianyu Li <Tianyu.Li@arm.com>; Jakub Grajciar <jgrajcia@cisco.com>
> > Cc: dev@dpdk.org; nd <nd@arm.com>; stable@dpdk.org
> > Subject: Re: [PATCH] net/memif: fix missing Tx-bps stats for zero-copy
> >
> > On 4/12/2021 9:22 AM, Tianyu Li wrote:
> >> Fix the missing Tx-bps counter for memif zero-copy mode Before
> >> Rx-pps: 6891450 Rx-bps: 3528438928
> >> Tx-pps: 6891482 Tx-bps: 0
> >> After
> >> Throughput (since last show)
> >> Rx-pps: 11157056 Rx-bps: 5712413016
> >> Tx-pps: 11157056 Tx-bps: 5712413016
> >>
> >> Fixes: 43b815d88188 ("net/memif: support zero-copy slave")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Tianyu Li <tianyu.li@arm.com>
> >> ---
> >> drivers/net/memif/rte_eth_memif.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/net/memif/rte_eth_memif.c
> >> b/drivers/net/memif/rte_eth_memif.c
> >> index 77c95bcb7..dd2825968 100644
> >> --- a/drivers/net/memif/rte_eth_memif.c
> >> +++ b/drivers/net/memif/rte_eth_memif.c
> >> @@ -706,6 +706,7 @@ memif_tx_one_zc(struct pmd_process_private
> *proc_private, struct memif_queue *mq
> >> /* populate descriptor */
> >> d0 = &ring->desc[slot & mask];
> >> d0->length = rte_pktmbuf_data_len(mbuf);
> >> + mq->n_bytes += rte_pktmbuf_data_len(mbuf);
> >> /* FIXME: get region index */
> >> d0->region = 1;
> >> d0->offset = rte_pktmbuf_mtod(mbuf, uint8_t *) -
> >>
> >
> > Looks good to me, but let's wait Jakub's review for it.
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/memif: fix missing Tx-bps stats for zero-copy
2021-04-12 8:22 [dpdk-dev] [PATCH] net/memif: fix missing Tx-bps stats for zero-copy Tianyu Li
2021-04-14 8:13 ` Ferruh Yigit
@ 2021-05-19 7:57 ` Ferruh Yigit
1 sibling, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2021-05-19 7:57 UTC (permalink / raw)
To: Tianyu Li, Jakub Grajciar; +Cc: dev, nd, stable
On 4/12/2021 9:22 AM, Tianyu Li wrote:
> Fix the missing Tx-bps counter for memif zero-copy mode
> Before
> Rx-pps: 6891450 Rx-bps: 3528438928
> Tx-pps: 6891482 Tx-bps: 0
> After
> Throughput (since last show)
> Rx-pps: 11157056 Rx-bps: 5712413016
> Tx-pps: 11157056 Tx-bps: 5712413016
>
> Fixes: 43b815d88188 ("net/memif: support zero-copy slave")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tianyu Li <tianyu.li@arm.com>
Reviewed-by: Jakub Grajciar <jgrajcia@cisco.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-19 7:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-12 8:22 [dpdk-dev] [PATCH] net/memif: fix missing Tx-bps stats for zero-copy Tianyu Li
2021-04-14 8:13 ` Ferruh Yigit
2021-04-27 6:30 ` Tianyu Li
2021-05-18 12:08 ` Ferruh Yigit
2021-05-18 16:57 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
2021-05-19 7:57 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).