From: Stanislaw Kardach <kda@semihalf.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, Stanislaw Kardach <kda@semihalf.com>, stable@dpdk.org
Subject: [dpdk-dev] [PATCH 0/3] add lock-free stack support discovery
Date: Mon, 12 Apr 2021 10:28:58 +0200 [thread overview]
Message-ID: <20210412082901.652736-1-kda@semihalf.com> (raw)
The lock-free stack implementation (RTE_STACK_F_LF) is supported only on a
subset of platforms, namely x86_64 and arm64. Platforms supporting 128b atomics
have to opt-in to a generic or C11 implementations. All other platforms use a
stubbed implementation for push/pop operations which are basically NOPs.
However rte_stack_create() will not fail and application can proceed assuming
it has a working lock-free stack.
This means that among other things the stack_lf fast and perf tests will fail
as if implementation is wrong (which one can argue is). Therefore this patchset
tries to give user a way to check whether a lock_free is supported or not both
at compile time (build flag) and at runtime (ENOTSUP errno in rte_stack_create).
I have added cc to stable@dpdk.org because check-git-log.sh suggested it. I'm
not sure if adding a binary compatible change to API is worth stable@dpdk.org.
Cc: stable@dpdk.org
Stanislaw Kardach (3):
stack: update lock-free supported archs
stack: add compile flag for lock-free support
test: run lock-free stack tests when supported
app/test/test_stack.c | 4 ++++
app/test/test_stack_perf.c | 4 ++++
doc/guides/rel_notes/release_21_05.rst | 4 ++++
lib/librte_stack/rte_stack.c | 4 +++-
lib/librte_stack/rte_stack.h | 3 ++-
lib/librte_stack/rte_stack_lf.h | 5 +++++
6 files changed, 22 insertions(+), 2 deletions(-)
--
2.27.0
next reply other threads:[~2021-04-12 8:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 8:28 Stanislaw Kardach [this message]
2021-04-12 8:28 ` [dpdk-dev] [PATCH 1/3] stack: update lock-free supported archs Stanislaw Kardach
2021-04-27 13:54 ` Olivier Matz
2021-04-12 8:29 ` [dpdk-dev] [PATCH 2/3] stack: add lock-free support indication Stanislaw Kardach
2021-04-27 13:54 ` Olivier Matz
2021-04-12 8:29 ` [dpdk-dev] [PATCH 3/3] test: run lock-free stack tests when supported Stanislaw Kardach
2021-04-27 13:55 ` Olivier Matz
2021-04-16 6:34 ` [dpdk-dev] [PATCH 0/3] add lock-free stack support discovery David Marchand
2021-04-19 14:44 ` Stanisław Kardach
2021-05-03 14:21 ` David Marchand
2021-05-03 14:28 ` Olivier Matz
2021-05-03 18:34 ` Stanisław Kardach
2021-05-04 6:44 ` David Marchand
2021-05-04 6:44 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412082901.652736-1-kda@semihalf.com \
--to=kda@semihalf.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).