From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BE49A0524; Wed, 14 Apr 2021 00:07:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F13EA1613CA; Wed, 14 Apr 2021 00:07:27 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 5918B40683 for ; Wed, 14 Apr 2021 00:07:26 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1061) id 549FD20B8001; Tue, 13 Apr 2021 15:07:25 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 549FD20B8001 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1618351645; bh=1CDtGCAprsfi4c8DGE1oAIWSiDO+XUj9RGaQdcu3O6Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l49AjYyYhicz4JnstEnF+VOc0jZT8KARxwU+5XMoqN2HVpezX6rMuAKv312jwhxtq +JZef9unqt/42FLmLWKP7QliZ7IadbLxDpksLfvwqL3SNcC7QPoX+K1CM2Ejzfj32D uLuyacvK/cXU7wXGPf5tQE7NP+p2oNi/63d1Lk44= Date: Tue, 13 Apr 2021 15:07:25 -0700 From: Jie Zhou To: Tal Shnaiderman Cc: "dev@dpdk.org" , "dmitry.kozliuk@gmail.com" , "xiaoyun.li@intel.com" , "roretzla@microsoft.com" , "pallavi.kadam@intel.com" , NBU-Contact-Thomas Monjalon , "bruce.richardson@intel.com" , "ferruh.yigit@intel.com" Message-ID: <20210413220725.GA26422@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1616172695-28505-1-git-send-email-jizh@linux.microsoft.com> <1618334363-15147-1-git-send-email-jizh@linux.microsoft.com> <1618334363-15147-7-git-send-email-jizh@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v3 6/6] app/testpmd: enable testpmd on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 13, 2021 at 06:58:16PM +0000, Tal Shnaiderman wrote: > > Subject: [dpdk-dev] [PATCH v3 6/6] app/testpmd: enable testpmd on > > Windows > > > > External email: Use caution opening links or attachments > > > > > > From: Jie Zhou > > > > I think this patch can be split further since it contains different topics, I would've split it at least to the following: > > 1) Resolve name collisions with Windows types. > 2) Add clock_gettime_monotic for testpmd on Windows. > 3) Replace unix specific functions and code to OS independent. > 4) build testpmd. > > > This patch is to enable testpmd on windows. It mainly includes: > > - Disable unsupported Apps on Windows under app\ except testpmd > Patch 4 > > - Resolve name collisions with Windows types > Patch 1 > > - Add clock_gettime_monotic for testpmd on Windows > Patch 2 > > - Make printf format work for both Linux and Windows > Patch 3 > > - Replace htons with RTE_BE16 > Patch 3 > > - Replace inet_aton with inet_pton > Patch 3, also explain why this change is needed > > - Fix parse_fec_mode to return fec_capa to remove compilation warning > Patch 3, unless this is a real fix and needs its own patch. > > - Replace mman.h POSIX APIs with rte_mem_xxx APIs > Patch 3 > > - Use OS independant rte_rand > Patch 3 > > > > Signed-off-by: Jie Zhou > > Signed-off-by: Jie Zhou > > --- Thanks Tal. Will have more granular patches in V4.