From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 285A4A0524;
	Wed, 14 Apr 2021 00:08:23 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1049B1613D3;
	Wed, 14 Apr 2021 00:08:23 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id A537A40683
 for <dev@dpdk.org>; Wed, 14 Apr 2021 00:08:21 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1061)
 id 1A0A720B8001; Tue, 13 Apr 2021 15:08:21 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1A0A720B8001
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1618351701;
 bh=cyjmHOmKfud4qhgFSoaxAYevCCfNz0rcodYCQHnuxxw=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=pBbUJ+M00OvTBKb4ErC0wjbXhH1qZEpIXrItV6VXy3fNx9OoujleBBqCbkAFeDsUL
 VuetdkeMAMIWysihOyYni0dEKtKKbtr8TEDDqqiMK8ZPTdZ7YdyJxV9Ojo9za0uw2n
 +CX0kzf6Bu6XzLV5kiFsOTt1DqGk2ef7fd/c3wQQ=
Date: Tue, 13 Apr 2021 15:08:21 -0700
From: Jie Zhou <jizh@linux.microsoft.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, xiaoyun.li@intel.com, roretzla@microsoft.com,
 pallavi.kadam@intel.com, thomas@monjalon.net,
 bruce.richardson@intel.com, ferruh.yigit@intel.com
Message-ID: <20210413220821.GB26422@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1616172695-28505-1-git-send-email-jizh@linux.microsoft.com>
 <1618334363-15147-1-git-send-email-jizh@linux.microsoft.com>
 <1618334363-15147-5-git-send-email-jizh@linux.microsoft.com>
 <20210413231038.5f29386d@sovereign>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210413231038.5f29386d@sovereign>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v3 4/6] app/testpmd: add device event stubs
 on Windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Apr 13, 2021 at 11:10:38PM +0300, Dmitry Kozlyuk wrote:
> Commit topic is incorrect, suggesting "eal/windows: add device event stubs".
> 
> 2021-04-13 10:19 (UTC-0700), Jie Zhou:
> > Add hot_plug related device event stubs in eal_dev.c on Windows.
> > 
> > Signed-off-by: Jie Zhou <jizh@microsoft.com>
> > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> > ---
> >  lib/librte_eal/windows/eal_dev.c   | 35 ++++++++++++++++++++++++++++++
> >  lib/librte_eal/windows/meson.build |  1 +
> >  2 files changed, 36 insertions(+)
> >  create mode 100644 lib/librte_eal/windows/eal_dev.c
> > 
> > diff --git a/lib/librte_eal/windows/eal_dev.c b/lib/librte_eal/windows/eal_dev.c
> > new file mode 100644
> > index 000000000..4c51d07df
> > --- /dev/null
> > +++ b/lib/librte_eal/windows/eal_dev.c
> > @@ -0,0 +1,35 @@
> > +/* SPDX-License-Identifier: BSD-3-Clause
> > + * Copyright(c) 2018 Intel Corporation
> 
> 2018 Intel?
> 
> > + */
> > +
> > +#include <rte_log.h>
> > +#include <rte_compat.h>
> 
> Not needed.
> 
> [...]

Thanks Dmitry. Will fix all in V4.