From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D8FDA0562; Wed, 14 Apr 2021 23:02:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A589161D21; Wed, 14 Apr 2021 23:02:49 +0200 (CEST) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by mails.dpdk.org (Postfix) with ESMTP id 2F848161D12; Wed, 14 Apr 2021 23:02:48 +0200 (CEST) Received: by mail-lj1-f174.google.com with SMTP id l22so17412626ljc.9; Wed, 14 Apr 2021 14:02:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L1z6A1vzRg6Du708ilrRsxBW5q7i2u1xrvjVqSlrXps=; b=rDY9RqlGU/qD+kxV/yhQV+A6jlBWsHEeEe4wMA59vUSE69mRBtOoh7XIxo6OhSMbDy 5turmBECmQs5gJytC16hUxZbj4EyRTEgZ20Fgwe/0GevPDzYBa0QswpX2YuNWQAT70IR jWBnaBfv8et1iMQ9RVzSEgJ7esRXJZTqAjVgv1AflNIMUwReHiOLgqGJxQ9/ORxYAOR7 f5Rv4iqPursqRC27LURbVEVbFcvXk0lpkMK1chWo6kEGCXB+PAfZyv0zXq4Ateb+v2Ac 8SSnDTs3KcPvz1TnQC9myNGUrcKFW1rnASXzMkXviTugoFxUZrzggjlH7p0CmtGwFD6+ HdZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L1z6A1vzRg6Du708ilrRsxBW5q7i2u1xrvjVqSlrXps=; b=rAd0ZQMB5eiSwd0MK6QJuxL9IohLNbzd3dsIp9L1/ha9AG+wxu5V70olrqJr0daESA kBIMHQP4tvY7PcSRew4+a0bz7s4Qqflx+K9JODWXZLRG/yWTUGT4ACd3DT/vU+/06cN+ hLkF6qRdAF7ypL0OH44vEys2dPzPrOugirlcU2NnfnHRP4QYH7NYUqX2rmF8jXgTpCEc S6AxEqiPRCM1Iv/j1+K0GzRdVLZz+amBY6nizMw6TMx9SnOqqhJ4wtUlC7V0EDCSuzwt tksbRp3ODLOzbosWrSxkWvbaM3QhLG7BSQrwtTw1fVfH1ZJcsYjRuV1McYDmMjrL6GMR FrdA== X-Gm-Message-State: AOAM530XBxbEmIU45HjGrQjNy5bL+hbwxtKv6MP94c4yUieZuHXKveUM hfN1wnMi3LgSwq2WHnIWjew= X-Google-Smtp-Source: ABdhPJw1LEb3cY/+VAzM59/fI5cTt00y44JDN5bPrf8G3ZZzTNcV42THxIFM9AUzushg5m4dJwP1Zw== X-Received: by 2002:a05:651c:222:: with SMTP id z2mr14444161ljn.109.1618434167722; Wed, 14 Apr 2021 14:02:47 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id f20sm223676lfu.245.2021.04.14.14.02.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Apr 2021 14:02:47 -0700 (PDT) Date: Thu, 15 Apr 2021 00:02:45 +0300 From: Dmitry Kozlyuk To: Thomas Monjalon Cc: dev@dpdk.org, bruce.richardson@intel.com, bluca@debian.org, olivier.matz@6wind.com, thierry.herbelot@6wind.com, Gabriel Ganne , stable@dpdk.org, Harry van Haaren , Luca Boccassi , Keith Wiles , david.marchand@redhat.com Message-ID: <20210415000245.0b1d45c1@sovereign> In-Reply-To: <3119483.LeJDoi8FaI@thomas> References: <20210409083927.8345-1-gabriel.ganne@6wind.com> <20210409122551.265939-1-thomas@monjalon.net> <3119483.LeJDoi8FaI@thomas> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5] build: remove redundant libpcap link X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-04-14 11:41 (UTC+0200), Thomas Monjalon: > 09/04/2021 14:25, Thomas Monjalon: > > From: Gabriel Ganne > > > > The pcap PMD and the librte_port both declare their dependency to libpcap > > with a line "ext_deps += pcap_dep". > > Then meson automatically adds this dependency to the pkg-config file > > in the "Requires.private" section for static builds. > > > > The additional update of dpdk_extra_ldflags was adding the dependency > > in the "Libs.private" section of the pkg-config, that is unnecessary. > > > > Fixes: efd5d1a8d8dd ("drivers/net: build some vdev PMDs with meson") > > Fixes: 268fa581b1ff ("port: fix pcap support with meson") > > Cc: stable@dpdk.org > > > > Signed-off-by: Gabriel Ganne > > Signed-off-by: Thomas Monjalon > > --- > > I have a doubt whether this option is really always useless. > > In the case of an old pcap (<1.9) without pkg-config support, > > and with the minimum meson supported (0.47.1), > > are we sure the generated pkg-config file will include -lpcap? > > Any volunteer to test please? Ubuntu 16.04, Meson 0.47.1, libpcap 1.7.4-2ubuntu0.1, after the patch libdpdk.pc contains: Libs.private: -lpcap -lpcap -lpcap -lpcap -lpcap -lpcap -lpcap -lpcap -lpcap -lpcap [...DPDK libraries...] Note that -lpcap comes _before_ DPDK libraries that require it. As a consequence, this doesn't link with unresolved libpcap symbols: gcc test.c `pkg-config --static --cflags --libs libdpdk` Before the patch -lpcap was _after_ DPDK libraries, link succeeded (there was also _one_ -lpcap before DPDK libraries). Meson 0.55.1 places -lpcap _after_ DPDK libraries, link succeeds both before and after the patch. Conclusion: this patch really breaks .pc file for older meson. If it can't be merged, dependent patches for net/pcap on Windows can be easily adjusted to work without it.