From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D767AA0C41; Fri, 16 Apr 2021 18:32:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BD83340687; Fri, 16 Apr 2021 18:32:17 +0200 (CEST) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 4049840150 for ; Fri, 16 Apr 2021 18:32:16 +0200 (CEST) Received: by mail-pj1-f49.google.com with SMTP id u14-20020a17090a1f0eb029014e38011b09so10076784pja.5 for ; Fri, 16 Apr 2021 09:32:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pLGDuvK6L+eBHP8UiAtx+ZvbDIqweYcGdZiKj3zUUeM=; b=RArDjtKaFlHIC+apS/7537BOiWLk//qIt7/5z3VW58+R+jFVvcWA8eMiRDaeaWykhr 9+swgAPzuKxxcC6gw3j1iAd0JizBslAGYQcgTGKMDGdrAww22Xh1eYoZXSNl08CE+KNX UN9P9QPpbnQBGZKo6ZlYcaF7bcwhfczAxY4ViEp72CrGNJuqlxc3YtnagcH32G05S5cB axv73yTFVi1EMxmAMNODKBv0Ignpd+rdyx6pk0OFzmq0XTpEqtYcO5ELEM3348QKCtg6 hqkMr6wTbAt/WF3ia0EDnByW7Vg73t3hvHITi4Ybavb1dAX3im9/hU0hFivb9QnBpTDR cu6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pLGDuvK6L+eBHP8UiAtx+ZvbDIqweYcGdZiKj3zUUeM=; b=e0TD5nbdrMQBrm2uHz/dBjq9VIpCdxsFdzqjfUuj+JeDu4AmW31kFELljvZa5r1MgA 89MSECSTLuGZaEp8ElfBLUtOZdpMBxNbJpF9+QHG/KK0xp9wKYbKKEkiBOs66FbMsKij CRUXWFikgrlLjMuAs5cM9HrcmNofVhQEhOWfY3ol5Vs7OMNKVn/TUFpwwAnq0NOMlA5z cFKNGmmj8V1XKztn/Jfr/3DmqnKaj0CVM8NSJLLKtpwTK92rtJeB6WtogBwmoszIPe3M +H7ri/GnrpEAFAtS4u/qL9Z5zff1/nama4RDE9kd/cntSv9M/KVvEpesiaXtmrzD+xrw gjSA== X-Gm-Message-State: AOAM532Aypi/MWCN9vXtG/s1TwiRQgtrk3u+tlqAhmWo05L9338bWIJB h3dI5QB4pfAma2yzG8ZDE6g80A== X-Google-Smtp-Source: ABdhPJwZ11n5mTQaxyebBmkPxMbugb9AsUs4GQ7zouj9NRLoKHa87afABSLXYM8chctRNOBnGqQZ/A== X-Received: by 2002:a17:90a:2acb:: with SMTP id i11mr10268004pjg.131.1618590735392; Fri, 16 Apr 2021 09:32:15 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id mz18sm6223553pjb.13.2021.04.16.09.32.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 09:32:15 -0700 (PDT) Date: Fri, 16 Apr 2021 09:19:34 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: "Min Hu (Connor)" , dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, thomas@monjalon.net Message-ID: <20210416091934.6e0c37a9@hermes.local> In-Reply-To: <4f0b93e4-3490-7823-ecf9-7cc499a1571b@intel.com> References: <1618046334-39857-1-git-send-email-humin29@huawei.com> <1618484959-4360-1-git-send-email-humin29@huawei.com> <4f0b93e4-3490-7823-ecf9-7cc499a1571b@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5] ethdev: add sanity checks in control APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 15 Apr 2021 16:38:16 +0100 Ferruh Yigit wrote: > When the line is long, can you break the message part to next line, to reduce > the length at least a few columns, like: > > RTE_ETHDEV_LOG(ERR, > "Failed to setup ethdev port %u Rx hairpin queue to NULL\n", > port_id); > > Same for all long messages. Why does message have to be so long? "Port %u failed: NULL Rx hairpin queue"