From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4702EA0C41; Fri, 16 Apr 2021 18:28:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C3FF340687; Fri, 16 Apr 2021 18:28:58 +0200 (CEST) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id A8AF840150 for ; Fri, 16 Apr 2021 18:28:57 +0200 (CEST) Received: by mail-pj1-f45.google.com with SMTP id q14-20020a17090a430eb02901503aaee02bso3844542pjg.3 for ; Fri, 16 Apr 2021 09:28:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OKIqRSgYJnJ2+PEvd3EEt1wSgpEia0VJNuzy3qpoVEk=; b=eamsOVaCGXEZFC3vnwSSGtox+cUwrjOQaNuBHPrjjySXR7wPMB2auo7jSjImwiD5xy rmQGpkr2TWBGJnpKMrvzvwfQIxvU/MqsbiCB34A0dhdPOBd3Ufe+xlmEPK5wn4Bxd9QQ bcgkbVP/yOaKHTQFXGHnSodqK8zopN9Oe7Ovu/o9o+PB7bq5YU8q2C0MbnVosDdlYCSR PxvxWGhI81P3bMe+fc1YVUdacyMWMtqjpzReovx88EZDkokQ7fx8Uk9lWNf+R9R6r89N 8K88TgNccegNUc5rjRlwhpiGAfBNiYnhMXwxicCzPm72KQewaAkhg/eP834wmRiI9TnR QFTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OKIqRSgYJnJ2+PEvd3EEt1wSgpEia0VJNuzy3qpoVEk=; b=kqchdXXCG78SQv6MWv5Zt1SbbciGxzEbKi4afh/u2kmeL6/fl/wCxky3ZmJFjzNbqN iaKak6lGz/HHYkrVfxhS+gIt4NAqgkpwcYsbhz/lWpbWzaBp++nXaiOsb5WUb9+9yEeG vTQO74MjBki6Du67KBiArjS7IfYB/gThPzOwO+Qh6T+xu9FcWDdofVwev91mTIjX9nvt 1c1JWnOEHsf/FI6hg/ls9Pn5YReVrOcVCg7uXCZhIq5kq9oglVojHBl8biIvIzp7mTAN GsUf57d8yr6vsrKyCZTxogm6c0iCTDP1EL3U9/AuCVBfSpLfSE1B+78wvWGwBwYKtqfL aBOw== X-Gm-Message-State: AOAM531StdwpWdEGtwf7bNJcHk2xV8Gy1bwm+n7TLIZBESLOfoUT39at 6GBrn1QHcxz2qQwLdJgSy2Juxw== X-Google-Smtp-Source: ABdhPJy360M3qTv01KgJZIwj0ebnv+ak2K1vyM02d2DfYZXZBdeHFi1uUmHBfqLhuwQpX2LR7BKSkA== X-Received: by 2002:a17:90b:3b87:: with SMTP id pc7mr10856312pjb.87.1618590536670; Fri, 16 Apr 2021 09:28:56 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id y204sm5618218pfc.198.2021.04.16.09.28.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 09:28:56 -0700 (PDT) Date: Fri, 16 Apr 2021 09:28:53 -0700 From: Stephen Hemminger To: Kevin Traynor Cc: "Min Hu (Connor)" , dev@dpdk.org, ferruh.yigit@intel.com, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru Message-ID: <20210416092853.39a1517e@hermes.local> In-Reply-To: References: <1618046334-39857-1-git-send-email-humin29@huawei.com> <1618555931-25858-1-git-send-email-humin29@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6] ethdev: add sanity checks in control APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 16 Apr 2021 11:22:02 +0100 Kevin Traynor wrote: > > + if (dev_conf == NULL) { > > + RTE_ETHDEV_LOG(ERR, > > + "Cannot configure ethdev port %u to NULL dev_conf\n", > > The others use a natural sounding names instead of argument name. If you > wanted to match that it could be "..to NULL conf" I would prefer that error messages don't try to be English sentences. The wording ends up awkward. and overly wordy. If function name is automatically included by RTE_ETHDEV_LOG() then Just: RTE_ETHDEV_LOG(ERR, "NULL ethdev") should be enough for programmer to find/fix the problem