From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 227EEA0547; Sun, 18 Apr 2021 22:23:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AE7641108; Sun, 18 Apr 2021 22:23:33 +0200 (CEST) Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by mails.dpdk.org (Postfix) with ESMTP id D7404410D7 for ; Sun, 18 Apr 2021 22:23:32 +0200 (CEST) Received: by mail-lj1-f180.google.com with SMTP id r22so26303355ljc.5 for ; Sun, 18 Apr 2021 13:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ljCt+8Qih+Eq5i5oFOssIhWAqZJ3J4shTgkyn4xQSJA=; b=HdC5GgaUzgDG3/Qhd7CMvmzZ2Hc4WCfGSHvLWynXp0bR9AaXG9HftuAJtR6mSluRZ3 7DI+bN8OkrPUJn1qoqmuGChe+xPt/VTk0ziY2U5v/YKKH46NnB5hsTCCOej3Ll0SKNcI nbPnUDZE9sT79H2IPdp4xLY/MPGsmrP09eDpEs5PkDmJFWmspXFvDf/8qTej6vWoLR5C EC9MA+bjtAbzDj/7o5uLmRc1e+q6D5pF6CRcttZc9ngYMaTwXXGhaPACdPYgo8pkcW1A FE1hspBQJais3O1p2IaGyN01c+I5P2gUlD1zN8Efboqs1hgizWqb+z4D9nlKiuWG46MK m8nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ljCt+8Qih+Eq5i5oFOssIhWAqZJ3J4shTgkyn4xQSJA=; b=Ckmxa0Xs6jv7jZhL/abUHmjxv4J5kelrttxryEgu0RDTwt3waEGxMWKzm1yW2KfJGd S7V+LmYCispKCdDUPJKsuNsIdyHbkwHwE984lPETH08/MOx87QfRgDMsh7PGdBsPcJki LSklxZyvJvH9Y+UW6h5ds4PLIMiyd8Ey/1Mi4YDAdoBj2SIyUh4rIwPfAbtKwqFj4Jid WHDTa0XGcHkbfa6hzORH2LrR3l0ez5r0hd3SkZO8l1lfNaMyrPgYAwPxMUwiOrKIzLVO 4FCFGa4387fOPNZf8z3MIJ2EdqCmxOVjWtf0vceZ6MPVeMPRWyfQN9Lzbm9T1fMfMQML cuug== X-Gm-Message-State: AOAM5306oZ6SCKtBi0UNF9UMr4eax0qmiBnC/HjqkJzHEm385/+uqkAR 5hGrsRwFBrp2hZdfziION18= X-Google-Smtp-Source: ABdhPJxGv9g4dUW7/4TC8wLZBgl7Y+T3G1WcNCDCClc2tHGsopisUbCoD169QoBlhBZHwc6RgIhvHQ== X-Received: by 2002:a2e:1519:: with SMTP id s25mr9324029ljd.277.1618777412410; Sun, 18 Apr 2021 13:23:32 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id s7sm1660640ljg.31.2021.04.18.13.23.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Apr 2021 13:23:31 -0700 (PDT) Date: Sun, 18 Apr 2021 23:23:30 +0300 From: Dmitry Kozlyuk To: Tal Shnaiderman Cc: NBU-Contact-Thomas Monjalon , "dev@dpdk.org" , "pallavi.kadam@intel.com" , "navasile@linux.microsoft.com" , "dmitrym@microsoft.com" Message-ID: <20210418232330.2471f913@sovereign> In-Reply-To: References: <20210418170803.15684-1-talshn@nvidia.com> <2018619.JnGxiWPmQR@thomas> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal/windows: fix build warnings in MinGW X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Tal, 2021-04-18 19:04 (UTC+0000), Tal Shnaiderman: > > Subject: Re: [PATCH] eal/windows: fix build warnings in MinGW > > > > External email: Use caution opening links or attachments > > > > > > 18/04/2021 19:08, Tal Shnaiderman: > > > the strncasecmp marco defined in rte_os_shim.h is already defined in > > > MinGW-w64, as a result the compiler prints out the warning below on > > > function redefinition whenever compiling a file including the header. > > > > > > ..\lib/librte_eal/windows/include/rte_os_shim.h:21: > > > warning: "strncasecmp" redefined > > > #define strncasecmp(s1, s2, count) _strnicmp(s1, s2, count) > > > > Why the tests are passing? Are we allowing warnings in build test? > > It's a good question, I see CI is passing without warnings, Dmitry can you reproduce it? > > On my side the collision is with the following file: > > C:/mingw-w64/x86_64/mingw64/x86_64-w64-mingw32/include/string.h:119: note: this is the location of the previous definition > #define strncasecmp _strnicmp > > I'm using: > -gcc (x86_64-win32-seh-rev0, Built by MinGW-W64 project) 8.1.0 > -meson 0.53.2 I can't reproduce it using the same versions. Do you invoke meson with other options than "-Dexamples=..."?