From: Stephen Hemminger <stephen@networkplumber.org>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@intel.com>,
<maryam.tahhan@intel.com>, <reshma.pattan@intel.com>,
<xiaoyun.li@intel.com>, <david.hunt@intel.com>,
<jerinj@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] app: fix redundant comparison
Date: Mon, 19 Apr 2021 08:06:43 -0700 [thread overview]
Message-ID: <20210419080643.4688f88f@hermes.local> (raw)
In-Reply-To: <1618835391-54882-1-git-send-email-humin29@huawei.com>
On Mon, 19 Apr 2021 20:29:51 +0800
"Min Hu (Connor)" <humin29@huawei.com> wrote:
> The return value of 'rte_eal_cleanup' is always zero, so comparison
> with zero is redundant.
>
> This patch fixed it by deleting the redundant comparison.
>
> Fixes: 67684d1e87b6 ("app/procinfo: call EAL cleanup before exit")
> Fixes: b68a82425da4 ("app/compress-perf: add performance measurement")
> Fixes: 5e516c89830a ("app/testpmd: call cleanup on exit")
> Fixes: 613ce6691c0d ("examples/l3fwd-power: implement proper shutdown")
> Fixes: 48be180de631 ("eal: move OS common debug functions to single file")
> Cc: stable@dpdk.org
>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Please keep it in testpmd, which should be checking everything.
For the others, the message doesn't add any value to the user and can be removed.
prev parent reply other threads:[~2021-04-19 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 12:29 Min Hu (Connor)
2021-04-19 12:44 ` David Hunt
2021-07-23 20:16 ` Andrew Rybchenko
2021-07-24 0:35 ` Min Hu (Connor)
2021-04-19 15:06 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210419080643.4688f88f@hermes.local \
--to=stephen@networkplumber.org \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
--cc=jerinj@marvell.com \
--cc=maryam.tahhan@intel.com \
--cc=reshma.pattan@intel.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).