From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A9ABA0524; Mon, 19 Apr 2021 17:06:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DFD434130F; Mon, 19 Apr 2021 17:06:54 +0200 (CEST) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 52770412E6 for ; Mon, 19 Apr 2021 17:06:53 +0200 (CEST) Received: by mail-pl1-f175.google.com with SMTP id v13so4273939ple.9 for ; Mon, 19 Apr 2021 08:06:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KM3H0z0UI7ERAcQWQTFbUUDFK7MC/AdbD9LZIgXCYp8=; b=O7MsJfVz9zzA6LiIrubaAa0QxJLoVNm+cISr/U/+mDaCi4mNq/rVv6Ef67JdrSFEaN muTzQW6KOEGbU1+SzqzfzDnfxG4xFyMbMlHWFs2EXgfEEWAQgxAD7JdnjH2LZ2d07CfD nFPGFAb3oEcSs3jFaPs7XItDD9y9Mz4ixajh4eTPSRHXdVaQORyRDwVRisbKpjge1iZC MC5VE07ePTcwXty2KOdlX0bZ8YZw/PsvohWTeP0M5IXRube/e4YF228aki2L6ZAqyemt Zd07b+O+OnG5+nX11HKGbCvyu55pAOEwrZd7dY6ZmW+OkFIsdkLHcTaLrcMTz6gIItcz cEvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KM3H0z0UI7ERAcQWQTFbUUDFK7MC/AdbD9LZIgXCYp8=; b=tBQClh/HArL21YkcMI3ZW4uVwJdSVDvCuGvGi1SkXqKbcbdQ5fgQuMzFakAs+1AhXf UvYaOX5rcnIm77V+w3soLJLav9R8mTn/lUpP9sYN58iprc+qj1endv9KCdbKFA5AXE2U w4Pshi5kvsuEDVpTsxy3SOJhsTreQyiECQB+/8J8wBhifm6G612UejWZ5og6WrmiwH7l qv9A9jwnEB8Igi3NeU1fca/DVi5N8QCVTwRmkc6NimeP8T5IAkzj9VX9UZj1po3kQpLf gAGFrzGom7N5kNaRnIhjNkZO6p96baZ0OBGqGWPZH1FA+leiwL86qNdUaFoojFgniZmr AnMg== X-Gm-Message-State: AOAM531h5gOyC6EmbAQYLNe8LE3CP0aCpV1BzQvCqy2Y8PrDRtH1bXME 2UeiS+hylpNCmr78Vhaggzd5yg== X-Google-Smtp-Source: ABdhPJxArXCahD4/ICtVLlNEU8TT0bpo8XwmFqWBOPWdKZvUz8Ed1lhftBrjXEE7avjxo/Y+6aeLZA== X-Received: by 2002:a17:90b:950:: with SMTP id dw16mr5067207pjb.68.1618844812303; Mon, 19 Apr 2021 08:06:52 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id b136sm13176456pfb.126.2021.04.19.08.06.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Apr 2021 08:06:51 -0700 (PDT) Date: Mon, 19 Apr 2021 08:06:43 -0700 From: Stephen Hemminger To: "Min Hu (Connor)" Cc: , , , , , , Message-ID: <20210419080643.4688f88f@hermes.local> In-Reply-To: <1618835391-54882-1-git-send-email-humin29@huawei.com> References: <1618835391-54882-1-git-send-email-humin29@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app: fix redundant comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 19 Apr 2021 20:29:51 +0800 "Min Hu (Connor)" wrote: > The return value of 'rte_eal_cleanup' is always zero, so comparison > with zero is redundant. > > This patch fixed it by deleting the redundant comparison. > > Fixes: 67684d1e87b6 ("app/procinfo: call EAL cleanup before exit") > Fixes: b68a82425da4 ("app/compress-perf: add performance measurement") > Fixes: 5e516c89830a ("app/testpmd: call cleanup on exit") > Fixes: 613ce6691c0d ("examples/l3fwd-power: implement proper shutdown") > Fixes: 48be180de631 ("eal: move OS common debug functions to single file") > Cc: stable@dpdk.org > > Signed-off-by: Min Hu (Connor) Please keep it in testpmd, which should be checking everything. For the others, the message doesn't add any value to the user and can be removed.