From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA240A0524; Mon, 19 Apr 2021 19:37:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBB434140D; Mon, 19 Apr 2021 19:37:42 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id E0A30413DE for ; Mon, 19 Apr 2021 19:37:40 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1061) id 3600F20B8000; Mon, 19 Apr 2021 10:37:40 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3600F20B8000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1618853860; bh=w8BlIEpKLVqvRLbRJEnqeRTaMIK6x/zY7Il+POKA3lI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dXnsVLeOdvw0YkHbPKpzaMFmzCjakDR9WpkciKTGqO+mgJ6BqBOqfsBTH4kQR707L 4pOOdWgLHoqEiw1/za5LbnqjIW8xQGuqb5rl5LXOzeBr1Vg7NPDElD5rF60ayKkxCx 2psxqgMnqTmED09z+ggh362Wu9Ztq1D7i+aycByI= Date: Mon, 19 Apr 2021 10:37:40 -0700 From: Jie Zhou To: Tal Shnaiderman Cc: NBU-Contact-Thomas Monjalon , "dev@dpdk.org" , "dmitry.kozliuk@gmail.com" , "xiaoyun.li@intel.com" , "roretzla@microsoft.com" , "pallavi.kadam@intel.com" , "bruce.richardson@intel.com" , "ferruh.yigit@intel.com" Message-ID: <20210419173740.GA13557@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1618594501-23795-10-git-send-email-jizh@linux.microsoft.com> <1618595864-27839-10-git-send-email-jizh@linux.microsoft.com> <1637838.CI588iCA6l@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v5 9/9] app/testpmd: enable building testpmd on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Apr 18, 2021 at 07:20:18PM +0000, Tal Shnaiderman wrote: > > Subject: Re: [dpdk-dev] [PATCH v5 9/9] app/testpmd: enable building > > testpmd on Windows > > > > External email: Use caution opening links or attachments > > > > > > > Subject: Re: [dpdk-dev] [PATCH v5 9/9] app/testpmd: enable building > > > testpmd on Windows > > > > > > External email: Use caution opening links or attachments > > > > > > > > > 18/04/2021 19:21, Tal Shnaiderman: > > > > Building testpmd results in 2 warnings in clang: > > > > > > > > ../app/test-pmd/config.c:4254:1: warning: unused function > > > > 'print_fdir_mask' [-Wunused-function] print_fdir_mask(struct > > > > rte_eth_fdir_masks *mask) ^ > > > > ../app/test-pmd/config.c:4289:1: warning: unused function > > > > 'print_fdir_flex_payload' [-Wunused-function] > > > > print_fdir_flex_payload(struct rte_eth_fdir_flex_conf *flex_conf, > > > > uint32_t num) ^ > > > > 2 warnings generated. > > > > > > Why all tests are passing in the CI? > > > I feel there is something wrong. We must test with -werror. > > > > I know that the UNH Windows CI runs with -werror however the test didn't > > run on clang yet [1]. > > This patch passed Intel compilation test on Windows, however I don't know if > > -werror is used there [2]. > > > > [1] - https://lab.dpdk.org/results/dashboard/patchsets/16593/ > > [2] - http://mails.dpdk.org/archives/test-report/2021-April/188796.html > > Update: the UNH test run a few minutes ago and as expected, failed with the compilation warnings. > For some reason however the test appears as 'passed' in patchwork. This cannot be repro'd on my Win10 + clang 10 system. Notice that the UNH is using Win2019 + clang 9. These two functions print_fdir_mask and print_fdir_flex_payload triggered "unused function" warning are both called in fdir_get_infos, and fdir_get_infos is called under "#if defined(RTE_NET_I40E) || defined(RTE_NET_IXGBE)". I can add #if defined(RTE_NET_I40E) || defined(RTE_NET_IXGBE) for the print_fdir_mask and prting_fdir_flex_payload as well, but it's not clear to me why fdir_get_infos is not called when i40e is already enabled on Windows.