From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70879A0547; Tue, 20 Apr 2021 04:21:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED08941448; Tue, 20 Apr 2021 04:21:16 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2077.outbound.protection.outlook.com [40.107.243.77]) by mails.dpdk.org (Postfix) with ESMTP id 8B1B840688 for ; Tue, 20 Apr 2021 04:21:15 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=doiClLmFp1Y/a692zoF1MybQAyFUAMF83PIUacPWn1oVPToIXtwZjbnMk8feZdV5Xp4Z/E6repg+kpF1CubQOR10tkkiWJIIghq+xnmcm9FWhY/KvxzcQOO5+pG8/0NFXYklKieuII4FrQ62yRZiuUQVbpWlNn8QVOJP+Y2LhpcBS3jQlzdLzmQgZ9WGWR6JZ4W1ZzTiJSwNTt0z63AxRrAI9TbJvycIgHLKv1Ba/SCVDELrbsG7KpVvcb56bubP5MTHisNHF4p0Zh+mePK3/rAxVTpmU182QG1yXjYO+4s1aEdIIaRH6SYovymyzYz/NLkX5FppwkDmtODZl3kHMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rDCPXXy0HsBtuwIA2l0/9XBYGuf9AxI6gEy7sTa4uRo=; b=VzVxSgvNYe7HEQkJZRjiOA0vqkyFF9Hvn0aMUKCELaN/05JddF9XuRFOlE36S6FqauqHGOMVoh18eTGJ2SJQvIEqmbzkuY5LKc4+mcUln9w0lCWmIcSwiovVPJTtMBIfTwX973oT/EZ6r6KY7wc4Ta/vCO8huIuwZ5WS8d6Pl9ezKbyYzwBUbtoVm8MjsK6tN8ZL4eSnx5Vc0B6TYlTyrTHQ5E7UvaNQ5mqC1gUvCQMMYAUj4OBH9TBoL0RJ8heLPnMulD1XdVfiqbgI84fCKNRyX6sV6uolhkj8W9I5xSQGIVGoNUTF4RBA7VpIllT3aLoo/pgMtzw9pHEtMeYXZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rDCPXXy0HsBtuwIA2l0/9XBYGuf9AxI6gEy7sTa4uRo=; b=TazoyRuFQzPA+301r9VcUCPGZcPGmhdbSsL0k9qtCAlKlBk2sBUzEzQ1iRMaDHp9UDmY1KRAmzCD5TtmjXe+kvRJ4tI5OaKT8n9mXUzxU7oieiOybLf1+wafjXlKuaUTNefBDutl1jmfMf5aPWuo+s+njUwnpzLTX9sly/5oma5nAHmKb/lXNx/6Z1eWNFxrD58UlZG8ZB50ZuC0hwBRFVB4I2iGhsWOaabLCJ7IHZ1POBaIosvlpzAhqCdjG7fXL0vfdVxCVcc4ZdINbpPUJlcnPo6SLvQXO4oeLqZwSJYuYljUDpGFcWt26MT8UnukcJnR7pf77q8cGr5zTQFDMw== Received: from MN2PR12MB3344.namprd12.prod.outlook.com (2603:10b6:208:c5::10) by MN2PR12MB3534.namprd12.prod.outlook.com (2603:10b6:208:108::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.18; Tue, 20 Apr 2021 02:21:14 +0000 Received: from MN2PR12MB3344.namprd12.prod.outlook.com ([fe80::19c7:88a6:a563:a659]) by MN2PR12MB3344.namprd12.prod.outlook.com ([fe80::19c7:88a6:a563:a659%7]) with mapi id 15.20.4042.024; Tue, 20 Apr 2021 02:21:13 +0000 From: Jack Min To: Ferruh Yigit CC: Jeff Guo , Ori Kam , "qi.z.zhang@intel.com" , "beilei.xing@intel.com" , "xiaoyun.li@intel.com" , "jingjing.wu@intel.com" , "dev@dpdk.org" , "ting.xu@intel.com" Thread-Topic: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add packet id for IP fragment Thread-Index: AQHXMD1IJAZGgipb0kySNh3KSEi6kaq7fvcAgACFKICAALMQAA== Date: Tue, 20 Apr 2021 02:21:13 +0000 Message-ID: <20210420022112.bw4lzk3a74t7ajhk@nvidia.com> References: <20210324134844.60410-1-jia.guo@intel.com> <20210413081032.60509-1-jia.guo@intel.com> <20210413081032.60509-2-jia.guo@intel.com> <20210419074344.tpjzwc5xisjykgzd@nvidia.com> <3f464ec1-f6c3-1969-611d-c000b1172d16@intel.com> In-Reply-To: <3f464ec1-f6c3-1969-611d-c000b1172d16@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [183.195.50.112] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 452802ca-36a2-4023-d21d-08d903a2f897 x-ms-traffictypediagnostic: MN2PR12MB3534: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2512; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wpWJ4Lis8kHXUDrUGcJT/4qahedJd8QqNGzL36pc6R6U8B1iXoDBJrS23Uc4CD7rg9bjNhUBugG8tbaJNzN5P3DjfYGgvDYWGfdB9yKblMFzq9dBIKQuzXdvS12+UsfLoYI22AN6s3dFyJMQS2Sw9nxBiaea6nCTD+ecd4s1nJP/K46xnUBPoJOaC3J5QKjsBgv0do/DCMEUNs7mm+/e4V3nU2MnPki88fKcLAZlijedE28uz92vA7DaeRgYfxjRNV9zc4V1+M1mRMTvXAGHjwZvoEEX/8HUmraGsCNg+ZblCbbO5k7F4lTx9UegDWK52CuAnijN5nylupVufD1PM8J3OPaZ3WxnrdCaYHjt+HHyKd5cVB6bqf3QjMMgw2h9JeLK4bFi1lIOwwcrVYo46iGuV/iADE6rf86sfWNdMHquq7YyGVzrwTHCw4tluSP1MEsUyiYYaurqV0BwIljJBSifrHnHIXWYUvhUCIFNyUxckeUOA3Hudc9Ygy/JOFMsFejU3/1BFG68PdpiwFVlsuunuihuZAQD5Szhw+VSsulb4J9d1mXlrXpuMrK6/xXeC42dkG8gzCvdJkOC7nnK4ydLIcN6/Y270FuT4SoJPEg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB3344.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(39860400002)(396003)(366004)(376002)(2616005)(478600001)(8936002)(26005)(186003)(83380400001)(8676002)(122000001)(1076003)(5660300002)(64756008)(6916009)(36756003)(6486002)(71200400001)(53546011)(91956017)(4326008)(6506007)(66556008)(76116006)(54906003)(6512007)(66946007)(86362001)(316002)(66446008)(2906002)(66476007)(38100700002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?tG/EqmoY6Em7EhxcGEOq5LQR1EuFYWbiLYB9/DLlZBEnXR6J0bIhunL+rP1X?= =?us-ascii?Q?Shv/tfI0F7ZXUIWofhyKW6iw0COzNdkJ8ZdJiVg57xzuniBBRlO8iEfKrvvl?= =?us-ascii?Q?Mvir6eUv/aLCgb6bfIcTl8EgVLrmmbpnqYw4RJk0Eco6hFPMUAWG5hKaITCn?= =?us-ascii?Q?WWhJyqhFSfKFxlfx1EJbEPZIiWGCRTs+Ek01KWYB97rbo5b6+IXQWDZ2FxzF?= =?us-ascii?Q?rU4XJiYypheT8NgHxPsIImQ4mFGHHFoSgiMC2NzYophfa58woSXN4dDyu2UO?= =?us-ascii?Q?+QJdhyn/8vAMT7CneAL+dG2xvFICv2M3mjL5lV7zvaC44mC1mqaoPC+9pEwJ?= =?us-ascii?Q?SxTqDOCpt05EmliqMT/xfQ00l1uAsV3ss8SQOCNf3HAlMy+foFnL54iWfP/g?= =?us-ascii?Q?2DAW0pdbToRzr7yPhpL93ZHR4L8SiRm3Tg8LHCkZaHyiHurqZxtBcz3ONNdu?= =?us-ascii?Q?QsGMnTkRmo4zCVga9YujbUQvZzB62Ny22oTDUBqWl6WHhIDoUvP0NMUtye4O?= =?us-ascii?Q?/hj38uOysHl97lO0BSbsUbkSd8faE9c0VDPKSo5aBtMoV7/PFPydpvTDmmSS?= =?us-ascii?Q?W0INPEOoyFLgW87EZLethQ8rJ/ifZg69pACKr6Wj7OwoFC7j86QHbwfLhID6?= =?us-ascii?Q?lBRW/OKjDkuQHvKF5HG/yu7CiJPMwDWn3hE3OtYPD/SrO6r4dWh3nap7QDYv?= =?us-ascii?Q?LM1tPdMoFYM4UpJiBQYUTZWPukRIwEIRfA52HD2vKu4odeR7JqfkB9HEBOVO?= =?us-ascii?Q?eFH9mWfsPc/fMzjIVXGWPPkKbG2XIkP6CtLvS7ZDpan2trIiCrwxEWEqu1b2?= =?us-ascii?Q?GDpAr8yjJS/TrhFJfNIQW8tvMmopvU5qJcWdBXQ1P/YDB1dT3xpmmSn7NtnY?= =?us-ascii?Q?r0XlvJvzCfNfM26EaxP6D9MFilCPsClY2AnjKpGSd2QkTqESjth1DWQTWKnv?= =?us-ascii?Q?TpFhutfHo0h90QggQNZwf5wRQtz0A4QlJQ9ccEwpD35NrL8Wma4CTyFVwys5?= =?us-ascii?Q?bbMALj3QXgUxGsxxKjEoMpUoWaH7z3G/qqRCYkCNun13J+c6syqF0AnYiE3W?= =?us-ascii?Q?6Ty1oq0B+7pjO1U+SeeJjmbsk8KsY4AQcdDnle1yyHMTNR8ArOpq4B4aPIwl?= =?us-ascii?Q?IXe+QTN0XWoFd0MfDm+4ILOhYnnANzhWBM0zTakwHTnVgzY6s6IYohmoEJq0?= =?us-ascii?Q?n7MIut47GZ6bb25I2G2JyOTRe53rcs40uzeSBnwTlaqWLfe/rzohj9uHyTJp?= =?us-ascii?Q?Y7OKz8pJNWt2BcwvREFGuRYVBfMmTv/V/0roiaLLam3Z98El/A8jn4S7gdPj?= =?us-ascii?Q?loMrSRDgzYwcdGDeL50jBuAb?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3344.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 452802ca-36a2-4023-d21d-08d903a2f897 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2021 02:21:13.8661 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JqFORGI+CohPHo7w+uz+zFTig8Z3Hs7nl3RxDbReq8/W8EAVrteIJPtoeVXnjLXHQh0zU3pxwrjl8Tq7JMfzJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3534 Subject: Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add packet id for IP fragment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 21-04-19, 16:40, Ferruh Yigit wrote: > On 4/19/2021 8:43 AM, Jack Min wrote: > > On Tue, 21-04-13, 16:10, Jeff Guo wrote: > > > Add the new items to support the flow configuration for IP fragment > > > packets. > > >=20 > > > Signed-off-by: Ting Xu > > > Signed-off-by: Jeff Guo > > > --- > > > app/test-pmd/cmdline_flow.c | 21 ++++++++++++++++++++- > > > 1 file changed, 20 insertions(+), 1 deletion(-) > >=20 > > [...snip...] > >=20 > > > + [ITEM_IPV4_ID] =3D { > > > + .name =3D "packet_id", > > > + .help =3D "fragment packet id", > > > + .next =3D NEXT(item_ipv4, NEXT_ENTRY(UNSIGNED), item_param), > > > + .args =3D ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_ipv4, > > > + hdr.packet_id)), > > > + }, > > > [ITEM_IPV4_FRAGMENT_OFFSET] =3D { > > > .name =3D "fragment_offset", > > > .help =3D "fragmentation flags and fragment offset", > > > @@ -2969,12 +2980,20 @@ static const struct token token_list[] =3D { > > > }, > > > [ITEM_IPV6_FRAG_EXT_FRAG_DATA] =3D { > > > .name =3D "frag_data", > > > - .help =3D "Fragment flags and offset", > > > + .help =3D "fragment flags and offset", > > Will it be better to have a seperate fix patch for this ? > >=20 >=20 > You refer the case update of the help string, 'F' -> 'f', right? Right. > If so this is so small, and cosmetic, update, I think no need to have its > own patch, and while this patch is touching related area, acceptable to f= ix > it here. Yes it's so small so I don't insist my point. :) Reviewed-by: Xiaoyu Min -Jack=