From: Tal Shnaiderman <talshn@nvidia.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, pallavi.kadam@intel.com,
dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com,
dmitrym@microsoft.com
Subject: [dpdk-dev] [PATCH v2] eal/windows: fix build warnings in MinGW
Date: Wed, 21 Apr 2021 19:09:42 +0300 [thread overview]
Message-ID: <20210421160942.17700-1-talshn@nvidia.com> (raw)
In-Reply-To: <20210418170803.15684-1-talshn@nvidia.com>
the strncasecmp macro defined in rte_os_shim.h is already
defined in MinGW-w64, as a result the compiler prints out
the warning below on function redefinition whenever compiling
a file including the header in debug mode.
..\lib/librte_eal/windows/include/rte_os_shim.h:21:
warning: "strncasecmp" redefined
#define strncasecmp(s1, s2, count) _strnicmp(s1, s2, count)
Fixed by defining the macro only to the clang compiler.
Fixes: 45d62067c237 ("eal: make OS shims internal")
Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
v2: fix commit message typo [Thomas]
---
lib/librte_eal/windows/include/rte_os_shim.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_eal/windows/include/rte_os_shim.h b/lib/librte_eal/windows/include/rte_os_shim.h
index f40fb62d1d..db0ea6f1b3 100644
--- a/lib/librte_eal/windows/include/rte_os_shim.h
+++ b/lib/librte_eal/windows/include/rte_os_shim.h
@@ -17,7 +17,9 @@
#define strdup(str) _strdup(str)
#define strtok_r(str, delim, saveptr) strtok_s(str, delim, saveptr)
+#ifndef RTE_TOOLCHAIN_GCC
#define strncasecmp(s1, s2, count) _strnicmp(s1, s2, count)
+#endif
#define open(path, flags, ...) _open(path, flags, ##__VA_ARGS__)
#define read(fd, buf, n) _read(fd, buf, n)
--
2.16.1.windows.4
next prev parent reply other threads:[~2021-04-21 16:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 17:08 [dpdk-dev] [PATCH] " Tal Shnaiderman
2021-04-18 18:13 ` Thomas Monjalon
2021-04-18 19:04 ` Tal Shnaiderman
2021-04-18 20:23 ` Dmitry Kozlyuk
2021-04-19 6:57 ` Tal Shnaiderman
2021-04-19 18:06 ` Tal Shnaiderman
2021-04-19 18:15 ` Thomas Monjalon
2021-04-19 19:29 ` [dpdk-dev] [dpdk-ci] " Aaron Conole
2021-04-19 20:09 ` Dmitry Kozlyuk
2021-04-19 20:33 ` Lincoln Lavoie
2021-04-20 11:01 ` Tal Shnaiderman
2021-04-19 19:45 ` [dpdk-dev] " Dmitry Kozlyuk
2021-04-19 18:55 ` Dmitry Kozlyuk
2021-04-21 16:09 ` Tal Shnaiderman [this message]
2021-04-26 15:58 ` [dpdk-dev] [PATCH v2] " Dmitry Kozlyuk
2021-05-04 17:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421160942.17700-1-talshn@nvidia.com \
--to=talshn@nvidia.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).