From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B9487A0547;
	Thu, 29 Apr 2021 18:29:19 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A8BC6410F1;
	Thu, 29 Apr 2021 18:29:19 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 16B4E410DD
 for <dev@dpdk.org>; Thu, 29 Apr 2021 18:29:18 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 61C7620B8000; Thu, 29 Apr 2021 09:29:17 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 61C7620B8000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1619713757;
 bh=8WMIYJjgXAlIFG0XLUSmipM9Jq5XpqrNZlqkuUKHiNk=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=CMEibeoK9rbo79ehQDOjq+MuPvrak6URbL7dgs9VMgzr+lpYzDS0fD7LkTK0oNU0E
 0G5RVPsGq/ZwZFEZGObCX4lEw7ngzd2Nte9nvqNU7ftVW0R5RjxYXjFpZn+hWtLe9H
 mM5fopmNlaQGi3tHQxOfKJtNBzNdU6RRiwA/1Ti8=
Date: Thu, 29 Apr 2021 09:29:17 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: Raslan Darawsheh <rasland@nvidia.com>, dev@dpdk.org,
 ferruh.yigit@intel.com, orika@nvidia.com,
 andrew.rybchenko@oktetlabs.ru, ivan.malov@oktetlabs.ru,
 ying.a.wang@intel.com, viacheslavo@nvidia.com, shirik@nvidia.com
Message-ID: <20210429162917.GC21799@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20210330075036.6579-2-rasland@nvidia.com>
 <20210404074552.24190-1-rasland@nvidia.com>
 <20210404074552.24190-2-rasland@nvidia.com>
 <20210408122956.GX1650@platinum>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210408122956.GX1650@platinum>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v4 1/2] ethdev: add new ext hdr for gtp psc
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Apr 08, 2021 at 02:29:56PM +0200, Olivier Matz wrote:
> Hi Raslan,
> 
> > +/**
> > + * Optional extension for GTP with next_ext set to 0x85
> > + * defined based on RFC 38415-g30.
> > + */
> > +__extension__
> > +struct rte_gtp_psc_hdr {
> > +	uint8_t ext_hdr_len; /**< PDU ext hdr len in multiples of 4 bytes */
> > +	uint8_t type:4; /**< PDU type */
> > +	uint8_t qmp:1; /**< Qos Monitoring Packet */

would it be a lot ot ask to have the structure defined using standard C
instead of using compiler specific extensions?