From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A7610A0547;
	Thu, 29 Apr 2021 19:48:37 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 26151410F1;
	Thu, 29 Apr 2021 19:48:37 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id B19E3410DD
 for <dev@dpdk.org>; Thu, 29 Apr 2021 19:48:35 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 0208B20B8000; Thu, 29 Apr 2021 10:48:35 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0208B20B8000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1619718515;
 bh=Pl6n+fZhYEjGgdRwi7eMCOsafi3tX86HYozPurakNVY=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=fAC7+fdmP8R8xvqZLv0HyehAcBpcqifuBoPtMGlEDZgvXC+BtmedBBBwS16NWruKd
 OwtQNL0+uj0I1BT9jgQiNNg6GqMjJRDgc8Y6gIfevwE1DfIb2wQhn+ZtmjCakHiYb5
 5Sq4JlVi+vo4sScAxZVP7jokXF0bNrLqSCxpxjDw=
Date: Thu, 29 Apr 2021 10:48:34 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, thomas@monjalon.net,
 andrew.rybchenko@oktetlabs.ru
Message-ID: <20210429174834.GE21799@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1618046334-39857-1-git-send-email-humin29@huawei.com>
 <1618284134-26152-1-git-send-email-humin29@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1618284134-26152-1-git-send-email-humin29@huawei.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add sanity checks in control APIs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Apr 13, 2021 at 11:22:14AM +0800, Min Hu (Connor) wrote:
> This patch adds more sanity checks in control path APIs.
> 
> Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input")
> Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables")
> Fixes: 0366137722a0 ("ethdev: check for invalid device name")
> Fixes: d948f596fee2 ("ethdev: fix port data mismatched in multiple process model")
> Fixes: 5b7ba31148a8 ("ethdev: add port ownership")
> Fixes: f8244c6399d9 ("ethdev: increase port id range")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---

this whole patch breaks abi since it returns new errno that were not
previously documented or returned. even if it is accepted it probably
should not be backported to stable.

it is entirely conceivable that you can have code that was calling these
functions and checking for specific return values where the new return
values will not be handled at all or improperly handled.

you can't just start emitting brand new errors or different errors for
the same input parameters.

thanks.