From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA15DA0546; Fri, 30 Apr 2021 20:07:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4800F4014F; Fri, 30 Apr 2021 20:07:03 +0200 (CEST) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by mails.dpdk.org (Postfix) with ESMTP id CF6F04013F for ; Fri, 30 Apr 2021 20:07:01 +0200 (CEST) Received: by mail-lf1-f51.google.com with SMTP id x20so81127671lfu.6 for ; Fri, 30 Apr 2021 11:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6bzus/SGdzOdW8gbt3ghDN1lwQbYNZTA6/4aOYDUGNE=; b=SB4i5m9gNDJ4xHy3KMJTFuBMe62zbjHbBUc4+PvO0XJu31eZHeUiwFkcVH9VRi+xLq xK8bxIS8WmkjIBX1lpxzbt6P3nkC7d9AD2IS/Sll2psEQzu7k/Cj9QfsRJ0/QF7zMSyk G36yT3n9vJHhXMB+RkqxBLZ2pbOIkXBolX5V8cQxi9DWg3q3NfcWOZR9Fq4BYdSoaw2E MlXfOJ1J7FI97PO7hWDzConDbNdRl/QBJ2cdKpOY/SBzWGa7JVwkGmaVzyn9dOwnUA2W 6bu3CdLIwq4Rf/qBuhSk6NClyc39+9JsbiQsvfCBOuQnV8PD3nxOkVSH/ijLwlAxFtMj edCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6bzus/SGdzOdW8gbt3ghDN1lwQbYNZTA6/4aOYDUGNE=; b=AzyOviXuZQeLY5uEcMFNPZWkZBc4EYlTtmAZ5H6bQDZOKHFtWb1GIIHryz3ssfWGnI SRMlHcUJMHz8zuzi2O9dd+3e6AcUDta2C3BEZZ8NWy2F6QuzKkP5aDFhPI+nSgXrx8An rRJbpJlRbt33VAxox1JBK1spAe29ZpUBNcAFPkx3ur5jETRBo8c6DYyOCtsdd0qakVwT 2r0SCGh6dE41wAO9DyxXoG+WSX8IZeT7JI+X53ZmoDj+GgqPep/H8CNdxwfuQLlmoOi/ B0fEq+VdsfedBPbksQmCT0hJ1C1TlG3L3jOp4l2i33WlyIQ11k+EWbWto0FOgLISctRq nP+g== X-Gm-Message-State: AOAM532Csr9e67hL3zU940KMJidga6gzNjzDg5rDmF8MS0Da0cPJzTvW edxW7Dvy+IB/Sl+IjAER77E= X-Google-Smtp-Source: ABdhPJx9deDealupuxvRPAvKzu8cINEyFgEApuXwZUt0/QIW9Ng8eQ9dc0Qr93B56Yl1kwqgPHC58g== X-Received: by 2002:ac2:5f0c:: with SMTP id 12mr4164060lfq.116.1619806021382; Fri, 30 Apr 2021 11:07:01 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id g24sm321737ljl.44.2021.04.30.11.07.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Apr 2021 11:07:00 -0700 (PDT) Date: Fri, 30 Apr 2021 21:06:57 +0300 From: Dmitry Kozlyuk To: Narcisa Ana Maria Vasile Cc: dev@dpdk.org, thomas@monjalon.net, khot@microsoft.com, navasile@microsoft.com, dmitrym@microsoft.com, roretzla@microsoft.com, talshn@nvidia.com, ocardona@microsoft.com, bruce.richardson@intel.com, david.marchand@redhat.com, pallavi.kadam@intel.com Message-ID: <20210430210657.3c72aedb@sovereign> In-Reply-To: <1617413948-10504-9-git-send-email-navasile@linux.microsoft.com> References: <1617057640-24301-2-git-send-email-navasile@linux.microsoft.com> <1617413948-10504-1-git-send-email-navasile@linux.microsoft.com> <1617413948-10504-9-git-send-email-navasile@linux.microsoft.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 08/10] eal: implement functions for thread barrier management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-04-02 18:39 (UTC-0700), Narcisa Ana Maria Vasile: > [...] > diff --git a/lib/librte_eal/include/rte_thread_types.h b/lib/librte_eal/include/rte_thread_types.h > index 37bc7af2b..b055bbf67 100644 > --- a/lib/librte_eal/include/rte_thread_types.h > +++ b/lib/librte_eal/include/rte_thread_types.h > @@ -7,6 +7,7 @@ > > #include > > +#define RTE_THREAD_BARRIER_SERIAL_THREAD PTHREAD_BARRIER_SERIAL_THREAD > #define RTE_THREAD_MUTEX_INITIALIZER PTHREAD_MUTEX_INITIALIZER > > #define EAL_THREAD_PRIORITY_NORMAL 0 > @@ -14,5 +15,6 @@ > > typedef pthread_t rte_thread_t; > typedef pthread_mutex_t rte_thread_mutex_t; > +typedef pthread_barrier_t rte_thread_barrier_t; > > #endif /* _RTE_THREAD_TYPES_H_ */ > diff --git a/lib/librte_eal/windows/include/rte_windows_thread_types.h b/lib/librte_eal/windows/include/rte_windows_thread_types.h > index 47c6b2664..b6209e6eb 100644 > --- a/lib/librte_eal/windows/include/rte_windows_thread_types.h > +++ b/lib/librte_eal/windows/include/rte_windows_thread_types.h > @@ -7,10 +7,13 @@ > > #include > > +#define RTE_THREAD_BARRIER_SERIAL_THREAD TRUE > + > #define EAL_THREAD_PRIORITY_NORMAL THREAD_PRIORITY_NORMAL > #define EAL_THREAD_PRIORITY_REALTIME_CIRTICAL THREAD_PRIORITY_TIME_CRITICAL > > typedef DWORD rte_thread_t; > typedef CRITICAL_SECTION rte_thread_mutex_t; > +typedef SYNCHRONIZATION_BARRIER rte_thread_barrier_t; > > #endif /* _RTE_THREAD_TYPES_H_ */ Please ensure that for both backends sizeof(rte_thread_barrier_t) is the same and RTE_THREAD_BARRIER_SERIAL_THREAD has same value.