From: Stephen Hemminger <stephen@networkplumber.org>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Tyler Retzlaff <roretzla@linux.microsoft.com>,
Bruce Richardson <bruce.richardson@intel.com>,
John McNamara <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] examples/rxtx_callbacks: fix port ID format specifier
Date: Wed, 5 May 2021 19:56:12 -0700 [thread overview]
Message-ID: <20210505195612.347322b4@hermes.local> (raw)
In-Reply-To: <20210505215435.22336-1-dmitry.kozliuk@gmail.com>
On Thu, 6 May 2021 00:54:35 +0300
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
> This fixes -Wformat warning with clang 10.0.0 on Windows.
>
> Fixes: f8244c6399d9 ("ethdev: increase port id range")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
> v3: PRIx16 -> PRIu16
> v2: u% and a cast -> PRIx16 (Tyler, Thomas)
> examples/rxtx_callbacks/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/rxtx_callbacks/main.c b/examples/rxtx_callbacks/main.c
> index b57b2fc6bc..192521c3c6 100644
> --- a/examples/rxtx_callbacks/main.c
> +++ b/examples/rxtx_callbacks/main.c
> @@ -329,7 +329,7 @@ main(int argc, char *argv[])
> /* initialize all ports */
> RTE_ETH_FOREACH_DEV(portid)
> if (port_init(portid, mbuf_pool) != 0)
> - rte_exit(EXIT_FAILURE, "Cannot init port %"PRIu8"\n",
> + rte_exit(EXIT_FAILURE, "Cannot init port %"PRIu16"\n",
> portid)
Ok, that matches what is used in rte_ethdev.h
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2021-05-06 2:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-02 2:56 [dpdk-dev] [PATCH] " Dmitry Kozlyuk
2021-05-04 0:11 ` Tyler Retzlaff
2021-05-04 6:48 ` Dmitry Kozlyuk
2021-05-05 16:00 ` Tyler Retzlaff
2021-05-05 21:39 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-05-05 22:45 ` Tyler Retzlaff
2021-05-05 23:13 ` Thomas Monjalon
2021-05-11 22:34 ` Tyler Retzlaff
2021-05-11 23:35 ` Thomas Monjalon
2021-05-05 21:51 ` [dpdk-dev] [PATCH v2] " Dmitry Kozlyuk
2021-05-05 21:54 ` [dpdk-dev] [PATCH v3] " Dmitry Kozlyuk
2021-05-06 2:56 ` Stephen Hemminger [this message]
2021-05-12 19:37 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-05-06 2:54 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210505195612.347322b4@hermes.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=john.mcnamara@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).