From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
stable@dpdk.org, dev@dpdk.org,
Bruce Richardson <bruce.richardson@intel.com>,
John McNamara <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/rxtx_callbacks: fix port ID format specifier
Date: Wed, 5 May 2021 15:45:21 -0700 [thread overview]
Message-ID: <20210505224521.GA32065@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <10660804.QYKOPib57F@thomas>
On Wed, May 05, 2021 at 11:39:23PM +0200, Thomas Monjalon wrote:
> 05/05/2021 18:00, Tyler Retzlaff:
> > On Tue, May 04, 2021 at 09:48:22AM +0300, Dmitry Kozlyuk wrote:
> > > >
> > > > what was the -Wformat clang on windows complaint?
> > >
> > > PRIx16 would work, but I noticed that in other places where port ID is
> > > printed, the pattern above is used. IMO uniform approach is better.
> >
> > ah, consistency. yes i'll have some of that. maybe one day in the future
> > we can change them all in one shot, but not today.
> >
> > Acked-By: Tyler Retzlaff <roretzla@linux.microsoft.com>
>
> I think PRIu16 is more appropriate.
works for me.
> Consistency doesn't matter if an approach is better.
well, there is some value in having consistency even if it is something
sub-optimal if we intend to do a mechanical change of all instances in
the future.
as a side question, what is the projects stance on getting more warnings
clean? there are a few not enabled that i'd really like to see e.g.
format, conversion, truncation etc..
i looked at lib/eal previously and there are... hundreds? of instances so
it's a non-trivial task. the problem i see is somehow getting to a
warnings clean state where we can enable -Werror in the CI pipeline but
at the same time figuring out how to prevent new instances from
appearing until we do.
next prev parent reply other threads:[~2021-05-05 22:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-02 2:56 [dpdk-dev] " Dmitry Kozlyuk
2021-05-04 0:11 ` Tyler Retzlaff
2021-05-04 6:48 ` Dmitry Kozlyuk
2021-05-05 16:00 ` Tyler Retzlaff
2021-05-05 21:39 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-05-05 22:45 ` Tyler Retzlaff [this message]
2021-05-05 23:13 ` Thomas Monjalon
2021-05-11 22:34 ` Tyler Retzlaff
2021-05-11 23:35 ` Thomas Monjalon
2021-05-05 21:51 ` [dpdk-dev] [PATCH v2] " Dmitry Kozlyuk
2021-05-05 21:54 ` [dpdk-dev] [PATCH v3] " Dmitry Kozlyuk
2021-05-06 2:56 ` Stephen Hemminger
2021-05-12 19:37 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-05-06 2:54 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210505224521.GA32065@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=john.mcnamara@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).