From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91927A0524; Fri, 7 May 2021 00:24:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B7BA40686; Fri, 7 May 2021 00:24:01 +0200 (CEST) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by mails.dpdk.org (Postfix) with ESMTP id C3B1640040 for ; Fri, 7 May 2021 00:23:59 +0200 (CEST) Received: by mail-lj1-f173.google.com with SMTP id s25so9110617lji.0 for ; Thu, 06 May 2021 15:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FBJpBKVm9SxhNohOsmNHb81s5i/z8IXJFOPtQRglWek=; b=tS7/y4T4MqGrL1L26YsSdBHU8YZNpO/pBljWEELXN+C/ZnSmjeFaMqqMt3tav2fGD8 2XrEMKzoQbmpV/FEqGZ+5gpuTse9x6189So4+vlyLcz9dy5auLsAAunOvS9+mHb7u98v vpp/Ye0pzcv05rEXrzzGR7vKbet5a6d2Gl/N6PyygaZI+uA+9pZjsLLWqAsLcBhup3Ui W1Y+zxzKalrnBnqulYNvyk996Y5g6+pm2hs+MUOSKBTfuD7ZN7SkLdkoVx21VkTCzvtl eTUjbh588Qz4s4n5tep+ftg3qXrkzSDCliqv/bH2mZPOttj+tDcsZSmo6i3zzdIFkYPE HqiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FBJpBKVm9SxhNohOsmNHb81s5i/z8IXJFOPtQRglWek=; b=I5H+XGmW3zU5VMCCW1Y401lJbUTqzuKv+O4fs9xUArCTROioQ3acmExgy2HDv9hMGv n3SIMBERiHv1BZRE2oxsf2Oqo9vgjo32DWYtQKiEg6cTCGBRADDK6yXjV/WUM6lcUz1l 0iwDYXWUZuyzpRD9QDN+6NES/upRE4MgmAqrNng5YKCE8A3GKjCz3Q8m0rAwQ89ubhBZ 98vj8/Kn3WVXQ4RKZ9V2c7g7t87aMsJc7DTyv4rlaBeaUV+AQpoFjSurQqjJrIg5jNKx KcuycwYVAM0dWznOKPVqRLbZ4aeJ4go2HjSBgI/z9NAvGKgNNFgc1e5KfSFZQD1dIXR/ L2/g== X-Gm-Message-State: AOAM530lsEAbPsrHMZrbDabKTGEE5WGyVUqIjS1k+PFx7F5Zje6t8NrK 0P1VJkBXxx8N45Aa4s9BVMA= X-Google-Smtp-Source: ABdhPJwCtZ7YENOzhkob+pa8yGUVL02k4cOEhtmI181m6F5B/oBMFg1Dt3WzXk3R7zo7ALdZqSOgrA== X-Received: by 2002:a05:651c:39d:: with SMTP id e29mr5391121ljp.97.1620339839254; Thu, 06 May 2021 15:23:59 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id u10sm990484lfq.243.2021.05.06.15.23.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 May 2021 15:23:58 -0700 (PDT) Date: Fri, 7 May 2021 01:23:56 +0300 From: Dmitry Kozlyuk To: David Marchand Cc: dev@dpdk.org, ian.stokes@intel.com, ktraynor@redhat.com, Olivier Matz , Ranjit Menon Message-ID: <20210507012356.216f1f49@sovereign> In-Reply-To: <20210506151426.28202-3-david.marchand@redhat.com> References: <20210506151426.28202-1-david.marchand@redhat.com> <20210506151426.28202-3-david.marchand@redhat.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] net: fix header include order for FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-05-06 17:14 (UTC+0200), David Marchand: > Spotted by sparse in OVS build: > ../../lib/netdev-dpdk.c: note: in included file (through > /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_ip.h, > /home/runner/work/ovs/ovs/dpdk-dir/build/include/rte_flow.h, ...): > ../../include/sparse/arpa/inet.h:22:2: error: "Must include > before for FreeBSD support" > > This is a check enforced by OVS itself. > See [1] for some context. > > 1: https://github.com/openvswitch/ovs/commit/b2befd5bb2db > > Fixes: 89813a522e68 ("net: provide IP-related API on any OS") > > Signed-off-by: David Marchand > --- > lib/net/rte_ip.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h > index 8c189009b0..4b728969c1 100644 > --- a/lib/net/rte_ip.h > +++ b/lib/net/rte_ip.h > @@ -22,8 +22,8 @@ > #else > #include > #include > -#include > #include > +#include > #include > #endif > Acked-by: Dmitry Kozlyuk It would be interesting to know exact issue this solves for OVS. Referenced commit only says FreeBSD "insists" on this include order, but DPDK and standalone files with these includes build either way.