From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BFAB2A0548; Sun, 9 May 2021 21:39:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3801640140; Sun, 9 May 2021 21:39:42 +0200 (CEST) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id E25CC4003E for ; Sun, 9 May 2021 21:39:40 +0200 (CEST) Received: by mail-pl1-f178.google.com with SMTP id t21so8087691plo.2 for ; Sun, 09 May 2021 12:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BiS1qzzkMMIuqRs4vWu7p3f3KpHKDtNLqmMB1fiknNo=; b=on1PXyTVA9ikcUxDFS+WB5oOLdXohDMtV8FxzN1NT+HHSkg4NkSzxVaPnLNW4YZU0W Bj8WTOqMKJaUNeOPVH/N6hw//0MymJJzVh7fUJZmpzVPhTra9E8PtmwhKNPnwpuBgm2k WV9lPhUr07UKKKsjb6wJYWnH+krK+/Z1zWMBvsu3MeZv3qOWTOkwfecWeYLVQgm34wAN 811wD/7B2CasTvi4ieUYuseR6th0MqdngJrv3UxiSY11C5ffQg6hMH/ClVqcgeHP1irf b1LsKi9grG4aNUoZUrJuaMov6ecRmbTXI0NLlV8ofyPKnm80L/QLfVxoF1R3VsPp5Joi ynLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BiS1qzzkMMIuqRs4vWu7p3f3KpHKDtNLqmMB1fiknNo=; b=gTfK+wplN/83Fw0xUyikoALDCKdXjcUdoom5d5yYa2niVDOLcFmo+z0tSzpgY5HBFU BLWQJtcIhdpDzpHpoTEO+oqjORNs0L2SC10O6ZBmct49gKp3PxEZhLGgFJQ6ELjV0ykY m4T7ZG3uMe7Q/mOKiAD0D4c5U8lSS/U0CqtKkgU2q5C3kiSGyGchAUEYA+AzylS0BtUv fY4GxSxqrFuNfVL0D1aUjn/LwCZx9EX2TN5FciXeE8snZwQhugQxFPTXFejpL77P+hZA ku/4sksKlmokbc8l/MiATWkN0uP/zj1wOFD+ZAzWb+u+6IZEoXQDQrn/xy+/63uE/unn lQjg== X-Gm-Message-State: AOAM532Brbp2Ltsm7qCeVQdns1wM6oEc2Jd7GMgByd8Br3LOaO0mOZI0 ej3w9c9YIRI6U4gAKw/lecxHbA== X-Google-Smtp-Source: ABdhPJyq35305Y7PheidP2ftuIxydVL+S4KZrfZYLlZPvVqvP7439/38Eu2r2j/Cuia7OsEmBhZFUA== X-Received: by 2002:a17:902:bc88:b029:ee:7ef1:e770 with SMTP id bb8-20020a170902bc88b02900ee7ef1e770mr21168402plb.19.1620589179928; Sun, 09 May 2021 12:39:39 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id mg11sm9204042pjb.24.2021.05.09.12.39.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 May 2021 12:39:39 -0700 (PDT) Date: Sun, 9 May 2021 12:39:31 -0700 From: Stephen Hemminger To: Cc: , Haiyue Wang , "Jiawen Wu" , Jian Wang , "Thomas Monjalon" , Ferruh Yigit , "Andrew Rybchenko" , , Message-ID: <20210509123931.463d6861@hermes.local> In-Reply-To: <20210509171803.1385-2-pbhagavatula@marvell.com> References: <20210509171803.1385-1-pbhagavatula@marvell.com> <20210509171803.1385-2-pbhagavatula@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] eal: fix side effects in ptr align macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, 9 May 2021 22:48:02 +0530 wrote: > From: Pavan Nikhilesh > > Avoid expanding parameters inside RTE_*_ALIGN macros. > Update common_autotest to detect macro side effects. > Workaround static arrays relying on RTE_ALIGN macros. > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Pavan Nikhilesh > Signed-off-by: David Marchand Why not split these up? It looks like the Intel driver and common part could be separate?