From: Feifei Wang <feifei.wang2@arm.com>
To: Jerin Jacob <jerinj@marvell.com>
Cc: dev@dpdk.org, nd@arm.com, Feifei Wang <feifei.wang2@arm.com>,
Ruifeng Wang <ruifeng.wang@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Subject: [dpdk-dev] [PATCH] app/eventdev: remove unnecessary barrier for order test
Date: Mon, 10 May 2021 14:11:48 +0800 [thread overview]
Message-ID: <20210510061148.1674641-1-feifei.wang2@arm.com> (raw)
For "order_launch_lcores" function, wmb after that the main lcore
updates the variable "t->err", which represents the end of the test
signal, is unnecessary. Because after the main lcore updates this
siginal variable, it will jump out of the launch function loop, and wait
other lcores stop or return error in the main function(evt_main.c).
During this time, there is no storing operation and thus no need for
wmb.
Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
---
app/test-eventdev/test_order_common.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/app/test-eventdev/test_order_common.c b/app/test-eventdev/test_order_common.c
index 04456d56db..d7760061ba 100644
--- a/app/test-eventdev/test_order_common.c
+++ b/app/test-eventdev/test_order_common.c
@@ -308,7 +308,6 @@ order_launch_lcores(struct evt_test *test, struct evt_options *opt,
rte_event_dev_dump(opt->dev_id, stdout);
evt_err("No schedules for seconds, deadlock");
t->err = true;
- rte_smp_wmb();
break;
}
old_remaining = remaining;
--
2.25.1
next reply other threads:[~2021-05-10 6:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 6:11 Feifei Wang [this message]
[not found] ` <AM5PR0802MB2465F23DEA897DA3CFB06B029E2C9@AM5PR0802MB2465.eurprd08.prod.outlook.com>
2021-05-18 9:27 ` [dpdk-dev] 回复: " Feifei Wang
2021-05-18 14:05 ` Jerin Jacob
2021-05-19 2:00 ` [dpdk-dev] 回复: " Feifei Wang
2021-06-30 6:49 ` [dpdk-dev] " Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510061148.1674641-1-feifei.wang2@arm.com \
--to=feifei.wang2@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).